Bug 593539: Refactor See Also to use separate modules for each type of URL

r/a=mkanat

1 files changed, 105 insertions, 0 deletions

diff --git a/Bugzilla/BugUrl/Bugzilla/Local.pm b/Bugzilla/BugUrl/Bugzilla/Local.pm
new file mode 100644
index 000000000..22812d085
--- /dev/null
+++ b/Bugzilla/BugUrl/Bugzilla/Local.pm
@@ -0,0 +1,105 @@
+# -*- Mode: perl; indent-tabs-mode: nil -*-
+#
+# The contents of this file are subject to the Mozilla Public
+# License Version 1.1 (the "License"); you may not use this file
+# except in compliance with the License. You may obtain a copy of
+# the License at http://www.mozilla.org/MPL/
+#
+# Software distributed under the License is distributed on an "AS
+# IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
+# implied. See the License for the specific language governing
+# rights and limitations under the License.
+#
+# The Original Code is the Bugzilla Bug Tracking System.
+#
+# The Initial Developer of the Original Code is Tiago Mello
+# Portions created by Tiago Mello are Copyright (C) 2010
+# Tiago Mello. All Rights Reserved.
+#
+# Contributor(s): Tiago Mello <timello@linux.vnet.ibm.com>
+
+package Bugzilla::BugUrl::Bugzilla::Local;
+use strict;
+use base qw(Bugzilla::BugUrl::Bugzilla);
+
+use Bugzilla::Error;
+use Bugzilla::Util;
+
+###############################
+####    Initialization     ####
+###############################
+
+use constant VALIDATOR_DEPENDENCIES => {
+    value => ['bug_id'],
+};
+
+###############################
+####        Methods        ####
+###############################
+
+sub insert_create_data {
+    my ($class, $field_values) = @_;
+
+    my $ref_bug = delete $field_values->{ref_bug};
+    my $url = $class->local_uri . $field_values->{bug_id};
+    my $bug_url = $class->SUPER::insert_create_data($field_values);
+
+    # Check if the ref bug has already the url and then,
+    # update the ref bug to point to the current bug.
+    if (!grep { $_ eq $url } @{ $ref_bug->see_also }) {
+        $class->SUPER::insert_create_data(
+            { value => $url, bug_id => $ref_bug->id } );
+    }
+
+    return $bug_url;
+}
+
+sub should_handle {
+    my ($class, $uri) = @_;
+
+    return $uri->as_string =~ m/^\w+$/ ? 1 : 0;
+
+    my $canonical_local = URI->new($class->_local_uri)->canonical;
+
+    # Treating the domain case-insensitively and ignoring http(s)://
+    return ($canonical_local->authority eq $uri->canonical->authority
+            and $canonical_local->path eq $uri->canonical->path) ? 1 : 0;
+}
+
+sub _check_value {
+    my ($class, $uri, undef, $params) = @_;
+
+    # At this point we are going to treat any word as a
+    # bug id/alias to the local Bugzilla.
+    my $value = $uri->as_string;
+    if ($value =~ m/^\w+$/) {
+        $uri = new URI($class->local_uri . $value);
+    } else {
+        # It's not a word, then we have to check
+        # if it's a valid Bugzilla url.
+        $uri = $class->SUPER::_check_value($uri);
+    }
+
+    my $ref_bug_id  = $uri->query_param('id');
+    my $ref_bug     = Bugzilla::Bug->check($ref_bug_id);
+    my $self_bug_id = $params->{bug_id};
+    $params->{ref_bug} = $ref_bug;
+
+    if ($ref_bug->id == $self_bug_id) {
+        ThrowUserError('see_also_self_reference');
+    }
+ 
+    my $product = $ref_bug->product_obj;
+    if (!Bugzilla->user->can_edit_product($product->id)) {
+        ThrowUserError("product_edit_denied",
+                       { product => $product->name });
+    }
+
+    return $uri;
+}
+
+sub local_uri {
+    return correct_urlbase() . "show_bug.cgi?id=";
+}
+
+1;