diff options
author | Dylan William Hardison <dylan@hardison.net> | 2016-09-11 16:10:35 +0200 |
---|---|---|
committer | Dylan William Hardison <dylan@hardison.net> | 2017-02-26 02:46:14 +0100 |
commit | d3a58e043a804feacc1d401dd4e1be02c56fc93d (patch) | |
tree | 147a0fd604c7d0b76e0af06a735998f80f52c2ef /Bugzilla/Comment.pm | |
parent | 84ebf678974927ed94561b34c2f8a89f217d08a4 (diff) | |
download | bugzilla-d3a58e043a804feacc1d401dd4e1be02c56fc93d.tar.gz bugzilla-d3a58e043a804feacc1d401dd4e1be02c56fc93d.tar.xz |
Bug 1301951 - Fix Bugzilla::Bug memory leaks
Diffstat (limited to 'Bugzilla/Comment.pm')
-rw-r--r-- | Bugzilla/Comment.pm | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/Bugzilla/Comment.pm b/Bugzilla/Comment.pm index d995d4509..2f063934a 100644 --- a/Bugzilla/Comment.pm +++ b/Bugzilla/Comment.pm @@ -21,7 +21,7 @@ use Bugzilla::User; use Bugzilla::Util; use List::Util qw(first); -use Scalar::Util qw(blessed); +use Scalar::Util qw(blessed weaken isweak); ############################### #### Initialization #### @@ -232,8 +232,11 @@ sub collapsed { sub bug { my $self = shift; require Bugzilla::Bug; - $self->{bug} ||= new Bugzilla::Bug($self->bug_id); - return $self->{bug}; + + # note $bug exists as a strong reference to keep $self->{bug} defined until the end of this method + my $bug = $self->{bug} ||= new Bugzilla::Bug($self->bug_id); + weaken($self->{bug}) unless isweak($self->{bug}); + return $bug; } sub is_about_attachment { |