summaryrefslogtreecommitdiffstats
path: root/Bugzilla/Field
diff options
context:
space:
mode:
authorSunil Joshi <joshi_sunil@in.com>2012-09-19 21:55:56 +0200
committerFrédéric Buclin <LpSolit@gmail.com>2012-09-19 21:55:56 +0200
commitc658f1b025d74ae9b4c7716d81377b68a1cc5a52 (patch)
treee461c2d47edf64ac6f47a66061f4343b3e656aed /Bugzilla/Field
parent526f38381f781317eb58d08800232172d79edd9e (diff)
downloadbugzilla-c658f1b025d74ae9b4c7716d81377b68a1cc5a52.tar.gz
bugzilla-c658f1b025d74ae9b4c7716d81377b68a1cc5a52.tar.xz
Bug 308709: Misleading confirmation when entering an invalid sort key for a field value
r/a=LpSolit
Diffstat (limited to 'Bugzilla/Field')
-rw-r--r--Bugzilla/Field/Choice.pm2
1 files changed, 1 insertions, 1 deletions
diff --git a/Bugzilla/Field/Choice.pm b/Bugzilla/Field/Choice.pm
index 2b6d8195f..52fb7b409 100644
--- a/Bugzilla/Field/Choice.pm
+++ b/Bugzilla/Field/Choice.pm
@@ -257,7 +257,7 @@ sub _check_sortkey {
return 0 if !$value;
# Store for the error message in case detaint_natural clears it.
my $orig_value = $value;
- detaint_natural($value)
+ (detaint_natural($value) && $value <= MAX_SMALLINT)
|| ThrowUserError('fieldvalue_sortkey_invalid',
{ sortkey => $orig_value,
field => $invocant->field });