diff options
| author | myk%mozilla.org <> | 2005-04-22 11:17:14 +0200 |
|---|---|---|
| committer | myk%mozilla.org <> | 2005-04-22 11:17:14 +0200 |
| commit | 1f6e1616c3e2f66d1982809a8d399129911d242b (patch) | |
| tree | 26a4f2582b8e73dbd1195b2d24f0df9cded3d2d0 /Bugzilla/Flag.pm | |
| parent | 993f0b3529d4c708fcbaa3fc8efcdeee9e1775d5 (diff) | |
| download | bugzilla-1f6e1616c3e2f66d1982809a8d399129911d242b.tar.gz bugzilla-1f6e1616c3e2f66d1982809a8d399129911d242b.tar.xz | |
Fix for bug 291391: allows users to rerequest set flags even if they don't have the privilege to set them; r=lpsolit; a=myk
Diffstat (limited to 'Bugzilla/Flag.pm')
| -rw-r--r-- | Bugzilla/Flag.pm | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/Bugzilla/Flag.pm b/Bugzilla/Flag.pm index de9c3d23b..8e03284d0 100644 --- a/Bugzilla/Flag.pm +++ b/Bugzilla/Flag.pm @@ -320,9 +320,9 @@ sub validate { # - The flag is unchanged next if ($status eq $flag->{status}); - # - User in the $request_gid group can clear pending requests - next if ($status eq 'X' - && $flag->{status} eq '?' + # - User in the $request_gid group can clear pending requests and set flags + # and can rerequest set flags. + next if (($status eq 'X' || $status eq '?') && (!$flag->{type}->{request_gid} || $user->in_group(&::GroupIdToName($flag->{type}->{request_gid})))); |