summaryrefslogtreecommitdiffstats
path: root/Bugzilla/Flag.pm
diff options
context:
space:
mode:
authorHugo Seabrook <hugo.seabrook@gmail.com>2013-02-15 07:08:31 +0100
committerByron Jones <bjones@mozilla.com>2013-02-15 07:08:31 +0100
commit82bab122d14431f4bf3f1c31988434aec2386515 (patch)
tree41e42e583fb0438c3382079f634df65d52cb0cbd /Bugzilla/Flag.pm
parent921e81caf7ffc083ac664459b015d38fc250437d (diff)
downloadbugzilla-82bab122d14431f4bf3f1c31988434aec2386515.tar.gz
bugzilla-82bab122d14431f4bf3f1c31988434aec2386515.tar.xz
Bug 830330: Make flags honour bug_check_can_change_field
r=dkl, a=LpSolit
Diffstat (limited to 'Bugzilla/Flag.pm')
-rw-r--r--Bugzilla/Flag.pm6
1 files changed, 6 insertions, 0 deletions
diff --git a/Bugzilla/Flag.pm b/Bugzilla/Flag.pm
index 3660e2a7f..98029a1b1 100644
--- a/Bugzilla/Flag.pm
+++ b/Bugzilla/Flag.pm
@@ -294,6 +294,12 @@ sub set_flag {
ThrowCodeError('flag_unexpected_object', { 'caller' => ref $obj });
}
+ # Make sure the user can change flags
+ my $privs;
+ $bug->check_can_change_field('flagtypes.name', 0, 1, \$privs)
+ || ThrowUserError('illegal_change',
+ { field => 'flagtypes.name', privs => $privs });
+
# Update (or delete) an existing flag.
if ($params->{id}) {
my $flag = $class->check({ id => $params->{id} });