Bug 348070: An arrayref is always "true" - Patch by Frédéric Buclin <LpSolit@gmail.com> a=myk

1 files changed, 4 insertions, 2 deletions

diff --git a/Bugzilla/Flag.pm b/Bugzilla/Flag.pm
index e46a9b17c..42d747d60 100644
--- a/Bugzilla/Flag.pm
+++ b/Bugzilla/Flag.pm
@@ -838,12 +838,14 @@ sub notify {
     # to make sure we don't send email about it to unauthorized users
     # on the request type's CC: list, so we have to trawl the list for users
     # not in those groups or email addresses that don't have an account.
-    if ($bug->groups || $attachment_is_private) {
+    my @bug_in_groups = grep {$_->{'ison'} || $_->{'mandatory'}} @{$bug->groups};
+
+    if (scalar(@bug_in_groups) || $attachment_is_private) {
         my @new_cc_list;
         foreach my $cc (split(/[, ]+/, $flag->type->cc_list)) {
             my $ccuser = Bugzilla::User->new_from_login($cc) || next;
 
-            next if ($bug->groups && !$ccuser->can_see_bug($bug->bug_id));
+            next if (scalar(@bug_in_groups) && !$ccuser->can_see_bug($bug->bug_id));
             next if $attachment_is_private
               && Bugzilla->params->{"insidergroup"}
               && !$ccuser->in_group(Bugzilla->params->{"insidergroup"});