diff options
author | dkl%redhat.com <> | 2008-07-21 10:06:27 +0200 |
---|---|---|
committer | dkl%redhat.com <> | 2008-07-21 10:06:27 +0200 |
commit | 1929d7a070ce311b7c0534eb1752d410d5e7d20b (patch) | |
tree | 857486c8346bd20b3bab1447fc5c02ccf333e28f /Bugzilla | |
parent | c71b9d012970dd5e887076bf18df7c40bdc2976c (diff) | |
download | bugzilla-1929d7a070ce311b7c0534eb1752d410d5e7d20b.tar.gz bugzilla-1929d7a070ce311b7c0534eb1752d410d5e7d20b.tar.xz |
Bug 445885 â User.login should ThrowUserError when called with incorrect parameters
Patch by David Lawrence <dkl@redhat.com> - a/r=mkanat
Diffstat (limited to 'Bugzilla')
-rwxr-xr-x | Bugzilla/WebService/User.pm | 12 |
1 files changed, 11 insertions, 1 deletions
diff --git a/Bugzilla/WebService/User.pm b/Bugzilla/WebService/User.pm index 35e4daad4..10537138c 100755 --- a/Bugzilla/WebService/User.pm +++ b/Bugzilla/WebService/User.pm @@ -43,7 +43,13 @@ use constant LOGIN_EXEMPT => { sub login { my ($self, $params) = @_; my $remember = $params->{remember}; - + + # Username and password params are required + foreach my $param ("login", "password") { + defined $params->{$param} + || ThrowCodeError('param_required', { param => $param }); + } + # Convert $remember from a boolean 0/1 value to a CGI-compatible one. if (defined($remember)) { $remember = $remember? 'on': ''; @@ -287,6 +293,10 @@ The username does not exist, or the password is wrong. The account has been disabled. A reason may be specified with the error. +=item 50 (Param Required) + +A login or password parameter was not provided. + =back =back |