summaryrefslogtreecommitdiffstats
path: root/Bugzilla
diff options
context:
space:
mode:
authorFrédéric Buclin <LpSolit@gmail.com>2011-09-27 13:10:50 +0200
committerFrédéric Buclin <LpSolit@gmail.com>2011-09-27 13:10:50 +0200
commit720408cbfcdf37cdc50c89f25976a023e27bb93c (patch)
tree8e1c1d731b1726e721894c54cff8d734cb03ad25 /Bugzilla
parent67346e9e26ed523829f1beaed65f07252ea83b61 (diff)
downloadbugzilla-720408cbfcdf37cdc50c89f25976a023e27bb93c.tar.gz
bugzilla-720408cbfcdf37cdc50c89f25976a023e27bb93c.tar.xz
Bug 655652: Remove "internals" field from Product.get
r=glob a=LpSolit
Diffstat (limited to 'Bugzilla')
-rw-r--r--Bugzilla/WebService/Product.pm44
1 files changed, 35 insertions, 9 deletions
diff --git a/Bugzilla/WebService/Product.pm b/Bugzilla/WebService/Product.pm
index 621486885..0f4c858d7 100644
--- a/Bugzilla/WebService/Product.pm
+++ b/Bugzilla/WebService/Product.pm
@@ -189,11 +189,13 @@ sub _product_to_hash {
my ($self, $params, $product) = @_;
my $field_data = {
- internals => $product,
id => $self->type('int', $product->id),
name => $self->type('string', $product->name),
description => $self->type('string', $product->description),
is_active => $self->type('boolean', $product->is_active),
+ default_milestone => $self->type('string', $product->default_milestone),
+ has_unconfirmed => $self->type('boolean', $product->allows_unconfirmed),
+ classification => $self->_classification_to_hash($product->classification),
};
if (filter_wants($params, 'components')) {
$field_data->{components} = [map {
@@ -213,6 +215,20 @@ sub _product_to_hash {
return filter($params, $field_data);
}
+sub _classification_to_hash {
+ my ($self, $classification) = @_;
+ return {
+ id =>
+ $self->type('int', $classification->id),
+ name =>
+ $self->type('string', $classification->name),
+ description =>
+ $self->type('string' , $classification->description),
+ sort_key =>
+ $self->type('int', $classification->sortkey),
+ };
+}
+
sub _component_to_hash {
my ($self, $component) = @_;
return {
@@ -400,6 +416,20 @@ C<string> A description of the product, which may contain HTML.
C<boolean> A boolean indicating if the product is active.
+=item C<default_milestone>
+
+C<string> The name of the default milestone for the product.
+
+=item C<has_unconfirmed>
+
+C<boolean> Indicates whether the UNCONFIRMED bug status is available
+for this product.
+
+=item C<classification>
+
+C<hash> Contains the classification C<id>, C<name>, C<description>
+and C<sort_key> as keys.
+
=item C<components>
C<array> An array of hashes, where each hash describes a component, and has the
@@ -453,12 +483,6 @@ following items: C<name>, C<sort_key> and C<is_active>.
C<array> An array of hashes, where each hash describes a milestone, and has the
following items: C<name>, C<sort_key> and C<is_active>.
-=item C<internals>
-
-B<UNSTABLE>
-
-An internal representation of the product.
-
=back
Note, that if the user tries to access a product that is not in the
@@ -474,8 +498,10 @@ is returned.
=item In Bugzilla B<4.2>, C<names> was added as an input parameter.
-=item In Bugzilla B<4.2> C<components>, C<versions>, and C<milestones>
-were added to the fields returned by C<get>.
+=item In Bugzilla B<4.2>, C<classification>, C<components>, C<versions>,
+C<milestones>, C<default_milestone> and C<has_unconfirmed> were added to
+the fields returned by C<get> as a replacement for C<internals>, which has
+been removed.
=back