summaryrefslogtreecommitdiffstats
path: root/Bugzilla
diff options
context:
space:
mode:
authorMax Kanat-Alexander <mkanat@bugzilla.org>2010-10-02 21:23:38 +0200
committerMax Kanat-Alexander <mkanat@bugzilla.org>2010-10-02 21:23:38 +0200
commita46cf131f0248614b048f55b30b1b92304292f01 (patch)
tree2de0aff1dda0a8703462055c8f5fbeae35bd3b1f /Bugzilla
parent9a93c62367cdc60890def5fef1afb4e62306781c (diff)
downloadbugzilla-a46cf131f0248614b048f55b30b1b92304292f01.tar.gz
bugzilla-a46cf131f0248614b048f55b30b1b92304292f01.tar.xz
Bug 600495: Make searching using "chfieldto" actually work again, for finding
bugs that were also updated after the particular change that's being looked for. r=mkanat, a=mkanat (module owner)
Diffstat (limited to 'Bugzilla')
-rw-r--r--Bugzilla/Search.pm9
1 files changed, 5 insertions, 4 deletions
diff --git a/Bugzilla/Search.pm b/Bugzilla/Search.pm
index fa162ed1d..fa1e40131 100644
--- a/Bugzilla/Search.pm
+++ b/Bugzilla/Search.pm
@@ -1289,16 +1289,17 @@ sub _special_parse_chfield {
my @charts;
# It is always safe and useful to push delta_ts into the charts
- # if there are any dates specified. It doesn't conflict with
+ # if there is a "from" date specified. It doesn't conflict with
# searching [Bug creation], because a bug's delta_ts is set to
# its creation_ts when it is created. So this just gives the
# database an additional index to possibly choose.
+ #
+ # It's not safe to do it for "to" dates, though--"chfieldto" means
+ # "a field that changed before this date", and delta_ts could be either
+ # later or earlier than that.
if ($date_from ne '') {
push(@charts, ['delta_ts', 'greaterthaneq', $date_from]);
}
- if ($date_to ne '') {
- push(@charts, ['delta_ts', 'lessthaneq', $date_to]);
- }
# Basically, we construct the chart like:
#