diff options
| author | Gervase Markham <gerv@gerv.net> | 2015-08-07 12:12:57 +0200 |
|---|---|---|
| committer | Gervase Markham <gerv@gerv.net> | 2015-08-07 12:12:57 +0200 |
| commit | aeb6689d5dcd2d1655236f9abda2ca0c5b794ce7 (patch) | |
| tree | 192a840dc65cb1ab5874678ef6393da0b136386e /Bugzilla | |
| parent | 553c7d968414eae0b118fa50f461c729ad75beb7 (diff) | |
| download | bugzilla-aeb6689d5dcd2d1655236f9abda2ca0c5b794ce7.tar.gz bugzilla-aeb6689d5dcd2d1655236f9abda2ca0c5b794ce7.tar.xz | |
Bug 1191255 - Remove requirement to specify SMTP server during installation on Windows. r=LpSolit, a=simon
Diffstat (limited to 'Bugzilla')
| -rw-r--r-- | Bugzilla/Config.pm | 21 | ||||
| -rw-r--r-- | Bugzilla/Config/Common.pm | 4 |
2 files changed, 3 insertions, 22 deletions
diff --git a/Bugzilla/Config.pm b/Bugzilla/Config.pm index 51d65397e..0d61abb7d 100644 --- a/Bugzilla/Config.pm +++ b/Bugzilla/Config.pm @@ -260,27 +260,6 @@ sub update_params { $op_file->close; } - if (ON_WINDOWS && !-e SENDMAIL_EXE - && $param->{'mail_delivery_method'} eq 'Sendmail') - { - my $smtp = $answer->{'SMTP_SERVER'}; - if (!$smtp) { - print "\nBugzilla requires an SMTP server to function on", - " Windows.\nPlease enter your SMTP server's hostname: "; - $smtp = <STDIN>; - chomp $smtp; - if ($smtp) { - $param->{'smtpserver'} = $smtp; - } - else { - print "\nWarning: No SMTP Server provided, defaulting to", - " localhost\n"; - } - } - - $param->{'mail_delivery_method'} = 'SMTP'; - } - write_params($param); if (-e $old_file) { diff --git a/Bugzilla/Config/Common.pm b/Bugzilla/Config/Common.pm index 95b1e3189..6f0c0d470 100644 --- a/Bugzilla/Config/Common.pm +++ b/Bugzilla/Config/Common.pm @@ -252,7 +252,7 @@ sub check_mail_delivery_method { my $check = check_multi(@_); return $check if $check; my $mailer = shift; - if ($mailer eq 'sendmail' and ON_WINDOWS) { + if ($mailer eq 'Sendmail' and ON_WINDOWS) { # look for sendmail.exe return "Failed to locate " . SENDMAIL_EXE unless -e SENDMAIL_EXE; @@ -299,6 +299,8 @@ sub check_smtp_server { my $host = shift; my $port; + return '' unless $host; + if ($host =~ /:/) { ($host, $port) = split(/:/, $host, 2); unless ($port && detaint_natural($port)) { |