summaryrefslogtreecommitdiffstats
path: root/Bugzilla
diff options
context:
space:
mode:
authorghendricks%novell.com <>2007-05-24 01:05:48 +0200
committerghendricks%novell.com <>2007-05-24 01:05:48 +0200
commitb712a735951ded7ea63804df48f3235d1786b49e (patch)
tree7585e1e6adeac991b45e8997aa9c9584adddfc9f /Bugzilla
parent550e990b5f6daa20d39faa911e989b7fc198d269 (diff)
downloadbugzilla-b712a735951ded7ea63804df48f3235d1786b49e.tar.gz
bugzilla-b712a735951ded7ea63804df48f3235d1786b49e.tar.xz
Bug 380928 – Bugzilla::Auth::Verify::create_or_update_user can return stale Bugzilla::User object
patch by vrb@novell.com r=mkanat a=mkanat
Diffstat (limited to 'Bugzilla')
-rw-r--r--Bugzilla/Auth/Verify.pm7
1 files changed, 3 insertions, 4 deletions
diff --git a/Bugzilla/Auth/Verify.pm b/Bugzilla/Auth/Verify.pm
index deb5f4e95..b293e2583 100644
--- a/Bugzilla/Auth/Verify.pm
+++ b/Bugzilla/Auth/Verify.pm
@@ -116,16 +116,15 @@ sub create_or_update_user {
validate_email_syntax($username)
|| return { failure => AUTH_ERROR, error => 'auth_invalid_email',
details => {addr => $username} };
- $dbh->do('UPDATE profiles SET login_name = ? WHERE userid = ?',
- undef, $username, $user->id);
+ $user->set_login($username);
}
if ($real_name && $user->name ne $real_name) {
# $real_name is more than likely tainted, but we only use it
# in a placeholder and we never use it after this.
trick_taint($real_name);
- $dbh->do('UPDATE profiles SET realname = ? WHERE userid = ?',
- undef, $real_name, $user->id);
+ $user->set_name($real_name);
}
+ $user->update();
return { user => $user };
}