Bug 347290: Move default product and classification creation into Bugzilla::Install

Patch By Max Kanat-Alexander <mkanat@bugzilla.org> (module owner) a=justdave

3 files changed, 104 insertions, 6 deletions

diff --git a/Bugzilla/DB/Schema.pm b/Bugzilla/DB/Schema.pm
index 9f4670845..088a70a78 100644
--- a/Bugzilla/DB/Schema.pm
+++ b/Bugzilla/DB/Schema.pm
@@ -874,12 +874,16 @@ use constant ABSTRACT_SCHEMA => {
             classification_id => {TYPE => 'INT2', NOTNULL => 1,
                                   DEFAULT => '1'},
             description       => {TYPE => 'MEDIUMTEXT'},
-            milestoneurl      => {TYPE => 'TINYTEXT', NOTNULL => 1},
-            disallownew       => {TYPE => 'BOOLEAN', NOTNULL => 1},
-            votesperuser      => {TYPE => 'INT2', NOTNULL => 1},
+            milestoneurl      => {TYPE => 'TINYTEXT', NOTNULL => 1,
+                                  DEFAULT => "''"},
+            disallownew       => {TYPE => 'BOOLEAN', NOTNULL => 1,
+                                  DEFAULT => 0},
+            votesperuser      => {TYPE => 'INT2', NOTNULL => 1,
+                                  DEFAULT => 0},
             maxvotesperbug    => {TYPE => 'INT2', NOTNULL => 1,
                                   DEFAULT => '10000'},
-            votestoconfirm    => {TYPE => 'INT2', NOTNULL => 1},
+            votestoconfirm    => {TYPE => 'INT2', NOTNULL => 1,
+                                  DEFAULT => 0},
             defaultmilestone  => {TYPE => 'varchar(20)',
                                   NOTNULL => 1, DEFAULT => "'---'"},
         ],
diff --git a/Bugzilla/Install.pm b/Bugzilla/Install.pm
index 4e94fa4a4..f35292ed9 100644
--- a/Bugzilla/Install.pm
+++ b/Bugzilla/Install.pm
@@ -26,7 +26,10 @@ package Bugzilla::Install;
 
 use strict;
 
+use Bugzilla::Group;
+use Bugzilla::Product;
 use Bugzilla::User::Setting;
+use Bugzilla::Version;
 
 use constant SETTINGS => {
     # 2005-03-03 travis@sedsystems.ca -- Bug 41972
@@ -50,6 +53,25 @@ use constant SETTINGS => {
 
 };
 
+use constant DEFAULT_CLASSIFICATION => {
+    name        => 'Unclassified',
+    description => 'Unassigned to any classification'
+};
+
+use constant DEFAULT_PRODUCT => {
+    name => 'TestProduct',
+    description => 'This is a test product.'
+        . ' This ought to be blown away and replaced with real stuff in a'
+        . ' finished installation of bugzilla.'
+};
+
+use constant DEFAULT_COMPONENT => {
+    name => 'TestComponent',
+    description => 'This is a test component in the test product database.'
+        . ' This ought to be blown away and replaced with real stuff in'
+        . ' a finished installation of Bugzilla.'
+};
+
 sub update_settings {
     my %settings = %{SETTINGS()};
     foreach my $setting (keys %settings) {
@@ -58,6 +80,58 @@ sub update_settings {
     }
 }
 
+# This function should be called only after creating the admin user.
+sub create_default_product {
+    my $dbh = Bugzilla->dbh;
+
+    # Make the default Classification if it doesn't already exist.
+    if (!$dbh->selectrow_array('SELECT 1 FROM classifications')) {
+        my $class = DEFAULT_CLASSIFICATION;
+        print "Creating default classification '$class->{name}'...\n";
+        $dbh->do('INSERT INTO classifications (name, description)
+                       VALUES (?, ?)',
+                 undef, $class->{name}, $class->{description});
+    }
+
+    # And same for the default product/component.
+    if (!$dbh->selectrow_array('SELECT 1 FROM products')) {
+        my $default_prod = DEFAULT_PRODUCT;
+        print "Creating initial dummy product '$default_prod->{name}'...\n";
+
+        $dbh->do(q{INSERT INTO products (name, description)
+                        VALUES (?,?)}, 
+                 undef, $default_prod->{name}, $default_prod->{description});
+
+        my $product = new Bugzilla::Product({name => $default_prod->{name}});
+
+        # The default version.
+        Bugzilla::Version::create(Bugzilla::Version::DEFAULT_VERSION, $product);
+
+        # And we automatically insert the default milestone.
+        $dbh->do(q{INSERT INTO milestones (product_id, value, sortkey)
+                        SELECT id, defaultmilestone, 0
+                          FROM products});
+
+        # Get the user who will be the owner of the Product.
+        # We pick the admin with the lowest id, or we insert
+        # an invalid "0" into the database, just so that we can
+        # create the component.
+        my $admin_group = new Bugzilla::Group({name => 'admin'});
+        my ($admin_id)  = $dbh->selectrow_array(
+            'SELECT user_id FROM user_group_map WHERE group_id = ?
+           ORDER BY user_id ' . $dbh->sql_limit(1),
+            undef, $admin_group->id) || 0;
+ 
+        my $default_comp = DEFAULT_COMPONENT;
+
+        $dbh->do("INSERT INTO components (name, product_id, description,
+                                          initialowner)
+                       VALUES (?, ?, ?, ?)", undef, $default_comp->{name},
+                 $product->id, $default_comp->{description}, $admin_id);
+    }
+
+}
+
 1;
 
 __END__
@@ -100,4 +174,13 @@ Params:      none
 
 Returns:     nothing.
 
+=item C<create_default_product()>
+
+Description: Creates the default product and classification if
+             they don't exist.
+
+Params:      none
+
+Returns:     nothing
+
 =back
diff --git a/Bugzilla/Install/DB.pm b/Bugzilla/Install/DB.pm
index 46e9b5c5a..9b29bbc76 100644
--- a/Bugzilla/Install/DB.pm
+++ b/Bugzilla/Install/DB.pm
@@ -449,6 +449,16 @@ sub update_table_definitions {
 
     _add_classifications_sortkey();
     _move_data_nomail_into_db();
+
+    # The products table lacked sensible defaults.
+    $dbh->bz_alter_column('products', 'milestoneurl',
+                          {TYPE => 'TINYTEXT', NOTNULL => 1, DEFAULT => "''"});
+    $dbh->bz_alter_column('products', 'disallownew',
+                          {TYPE => 'BOOLEAN', NOTNULL => 1,  DEFAULT => 0});
+    $dbh->bz_alter_column('products', 'votesperuser', 
+                          {TYPE => 'INT2', NOTNULL => 1, DEFAULT => 0});
+    $dbh->bz_alter_column('products', 'votestoconfirm',
+                          {TYPE => 'INT2', NOTNULL => 1, DEFAULT => 0});
     
     ################################################################
     # New --TABLE-- changes should go *** A B O V E *** this point #
@@ -1194,9 +1204,10 @@ sub _use_ids_for_products_and_components {
             $dbh->do("UPDATE attachstatusdefs SET product_id = $product_id " .
                      "WHERE product = " . $dbh->quote($product))
                 if $dbh->bz_table_info("attachstatusdefs");
-            }
+        }
+
+        print "Updating the database to use component IDs.\n";
 
-            print "Updating the database to use component IDs.\n";
         $dbh->bz_add_column("components", "id",
             {TYPE => 'SMALLSERIAL', NOTNULL => 1, PRIMARYKEY => 1});
         $dbh->bz_add_column("bugs", "component_id",