Fixed bug 4928 -- wasn't encoding multi-line value fields properly,

which busted modern browsers (like, Mozilla itself).

1 files changed, 2 insertions, 10 deletions

diff --git a/CGI.pl b/CGI.pl
index 890a8edf7..e580c1baa 100644
--- a/CGI.pl
+++ b/CGI.pl
@@ -186,19 +186,11 @@ sub value_quote {
     $var =~ s/</\&lt;/g;
     $var =~ s/>/\&gt;/g;
     $var =~ s/"/\&quot;/g;
+    $var =~ s/\n/\&#010;/g;
+    $var =~ s/\r/\&#013;/g;
     return $var;
 }
 
-sub value_unquote {
-    my ($var) = (@_);
-    $var =~ s/\&quot/\"/g;
-    $var =~ s/\&lt/</g;
-    $var =~ s/\&gt/>/g;
-    $var =~ s/\&amp/\&/g;
-    return $var;
-}
-
-
 sub navigation_header {
     if (defined $::COOKIE{"BUGLIST"} && $::COOKIE{"BUGLIST"} ne "") {
 	my @bugs = split(/:/, $::COOKIE{"BUGLIST"});