Bug 287483: Sanitycheck screams about "Bad value 0 found in components.initialqacontact"

Patch By Teemu Mannermaa <wicked@etlicon.fi> r=mkanat, a=myk

1 files changed, 8 insertions, 2 deletions

diff --git a/checksetup.pl b/checksetup.pl
index a0a7835ba..b4f9fb930 100755
--- a/checksetup.pl
+++ b/checksetup.pl
@@ -3838,8 +3838,14 @@ add_setting ("display_quips", {"on" => 1, "off" => 2 }, "on" );
 if (!$dbh->bz_get_field_def('bugs', 'qa_contact')->[2]) { # if it's NOT NULL
     $dbh->bz_change_field_type('bugs', 'qa_contact', 'mediumint');
     $dbh->do("UPDATE bugs SET qa_contact = NULL WHERE qa_contact = 0");
-    $dbh->do("UPDATE components SET initialqacontact = NULL
-               WHERE initialqacontact = 0");
+}
+
+# 2005-03-27 initialqacontact should be NULL instead of 0, bug 287483
+if (!$dbh->bz_get_field_def('components',
+                            'initialqacontact')->[2]) { # if it's NOT NULL
+    $dbh->bz_change_field_type('components', 'initialqacontact', 'mediumint');
+    $dbh->do("UPDATE components SET initialqacontact = NULL " .
+             "WHERE initialqacontact = 0");
 }
 
 # 2005-03-29 - gerv@gerv.net - bug 73665.