Bug 286235: Implicit joins should be replaced by explicit joins - installment A

Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=joel, a=myk

1 files changed, 5 insertions, 3 deletions

diff --git a/editclassifications.cgi b/editclassifications.cgi
index 9dad9ae37..5f31c50a8 100755
--- a/editclassifications.cgi
+++ b/editclassifications.cgi
@@ -374,9 +374,11 @@ if ($action eq 'reclassify') {
                                  products.name,
                                  classifications.name,
                                  classifications.id > 1 as unknown
-                           FROM products,classifications
-                           WHERE classifications.id=products.classification_id
-                           ORDER BY unknown, products.name, classifications.name");
+                           FROM products
+                           INNER JOIN classifications
+                           ON classifications.id = products.classification_id
+                           ORDER BY unknown, products.name,
+                                    classifications.name");
     $sth->execute();
     while ( my ($clid, $name, $clname) = $sth->fetchrow_array() ) {
         if ($clid == $classification_id) {