diff options
| author | Frédéric Buclin <LpSolit@gmail.com> | 2014-10-06 16:29:01 +0200 |
|---|---|---|
| committer | David Lawrence <dkl@mozilla.com> | 2014-10-06 16:29:01 +0200 |
| commit | 9e186bdd5da79077f162351d61fd1163d6cfd622 (patch) | |
| tree | 3ddcb53698d5f608dd9228b1632481f4a0fcc04f /editgroups.cgi | |
| parent | 553568ddf8d9c6282daf779bb83dec7111ed4ff0 (diff) | |
| download | bugzilla-9e186bdd5da79077f162351d61fd1163d6cfd622.tar.gz bugzilla-9e186bdd5da79077f162351d61fd1163d6cfd622.tar.xz | |
Bug 1075578: [SECURITY] Improper filtering of CGI arguments
r=dkl,a=sgreen
Diffstat (limited to 'editgroups.cgi')
| -rwxr-xr-x | editgroups.cgi | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/editgroups.cgi b/editgroups.cgi index 9c33a0ee3..287ac1114 100755 --- a/editgroups.cgi +++ b/editgroups.cgi @@ -224,7 +224,7 @@ if ($action eq 'new') { if ($action eq 'del') { # Check that an existing group ID is given - my $group = Bugzilla::Group->check({ id => $cgi->param('group') }); + my $group = Bugzilla::Group->check({ id => scalar $cgi->param('group') }); $group->check_remove({ test_only => 1 }); $vars->{'shared_queries'} = $dbh->selectrow_array('SELECT COUNT(*) @@ -248,7 +248,7 @@ if ($action eq 'del') { if ($action eq 'delete') { check_token_data($token, 'delete_group'); # Check that an existing group ID is given - my $group = Bugzilla::Group->check({ id => $cgi->param('group') }); + my $group = Bugzilla::Group->check({ id => scalar $cgi->param('group') }); $vars->{'name'} = $group->name; $group->remove_from_db({ remove_from_users => scalar $cgi->param('removeusers'), |