Bug 287136: Missing validations in editproducts.cgi - Patch by Frédéric Buclin <LpSolit@gmail.com> r=joel a=justdave

1 files changed, 6 insertions, 5 deletions

diff --git a/editproducts.cgi b/editproducts.cgi
index be0842912..3a63add6a 100755
--- a/editproducts.cgi
+++ b/editproducts.cgi
@@ -425,6 +425,12 @@ if ($action eq 'new') {
 
     # Cleanups and validity checks
 
+    my $classification_id = 1;
+    if (Param('useclassification')) {
+        CheckClassification($classification);
+        $classification_id = get_classification_id($classification);
+    }
+
     unless ($product) {
         print "You must enter a name for the new product. Please press\n";
         print "<b>Back</b> and try again.\n";
@@ -475,11 +481,6 @@ if ($action eq 'new') {
     $votestoconfirm ||= 0;
     my $defaultmilestone = $cgi->param('defaultmilestone') || "---";
 
-    my $classification_id = 1;
-    if (Param('useclassification')) {
-        $classification_id = get_classification_id($classification);
-    }
-
     # Add the new product.
     SendSQL("INSERT INTO products ( " .
             "name, description, milestoneurl, disallownew, votesperuser, " .