diff options
| author | mkanat%kerio.com <> | 2005-03-05 09:18:47 +0100 |
|---|---|---|
| committer | mkanat%kerio.com <> | 2005-03-05 09:18:47 +0100 |
| commit | ec610fd673feb6d6e18d121b5e67aa3f87e7f4ea (patch) | |
| tree | b1d6fe9b10b89a30e2b1932d050d5678362f638a /editusers.cgi | |
| parent | e4b8b770b0229a0761a3ef5116c7fcad4e5352d5 (diff) | |
| download | bugzilla-ec610fd673feb6d6e18d121b5e67aa3f87e7f4ea.tar.gz bugzilla-ec610fd673feb6d6e18d121b5e67aa3f87e7f4ea.tar.xz | |
Bug 277782: _throw_error should unlock tables when tables are locked, automatically
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=travis, r=LpSolit, a=justdave
Diffstat (limited to 'editusers.cgi')
| -rwxr-xr-x | editusers.cgi | 18 |
1 files changed, 7 insertions, 11 deletions
diff --git a/editusers.cgi b/editusers.cgi index 87a8b69bd..8169d0b93 100755 --- a/editusers.cgi +++ b/editusers.cgi @@ -212,8 +212,7 @@ if ($action eq 'search') { canSeeUser($otherUserID) || ThrowUserError('auth_failure', {reason => "not_visible", action => "modify", - object => "user"}, - 'abort'); + object => "user"}); # Cleanups my $login = trim($cgi->param('login') || ''); @@ -231,11 +230,10 @@ if ($action eq 'search') { if ($login ne $loginold) { # Validate, then trick_taint. - $login || ThrowUserError('user_login_required', undef, 'abort'); + $login || ThrowUserError('user_login_required'); CheckEmailSyntax($login); is_available_username($login) || ThrowUserError('account_exists', - {'email' => $login}, - 'abort'); + {'email' => $login}); trick_taint($login); push(@changedFields, 'login_name'); push(@values, $login); @@ -493,19 +491,17 @@ if ($action eq 'search') { 'whine_events WRITE'); Param('allowuserdeletion') - || ThrowUserError('users_deletion_disabled', undef, 'abort'); + || ThrowUserError('users_deletion_disabled'); $editusers || ThrowUserError('auth_failure', {group => "editusers", action => "delete", - object => "users"}, - 'abort'); + object => "users"}); canSeeUser($otherUserID) || ThrowUserError('auth_failure', {reason => "not_visible", action => "delete", - object => "user"}, - 'abort'); + object => "user"}); productResponsibilities($otherUserID) - && ThrowUserError('user_has_responsibility', undef, 'abort'); + && ThrowUserError('user_has_responsibility'); Bugzilla->logout_user_by_id($otherUserID); |