Patch by Holger Schurig <holger@holger.om.org> -- rewriting and enhancing the

ability to edit components, products, and versions.  Yay!

1 files changed, 542 insertions, 0 deletions

diff --git a/editversions.cgi b/editversions.cgi
new file mode 100755
index 000000000..7ac8032b2
--- /dev/null
+++ b/editversions.cgi
@@ -0,0 +1,542 @@
+#!/usr/bonsaitools/bin/perl -w
+# -*- Mode: perl; indent-tabs-mode: nil -*-
+#
+# The contents of this file are subject to the Mozilla Public License
+# Version 1.0 (the "License"); you may not use this file except in
+# compliance with the License. You may obtain a copy of the License at
+# http://www.mozilla.org/MPL/
+# 
+# Software distributed under the License is distributed on an "AS IS"
+# basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See the
+# License for the specific language governing rights and limitations
+# under the License.
+#
+#
+# Direct any questions on this source code to
+#
+# Holger Schurig <holgerschurig@nikocity.de>
+
+use diagnostics;
+use strict;
+
+require "CGI.pl";
+require "globals.pl";
+
+
+
+
+# TestProduct:  just returns if the specified product does exists
+# CheckProduct: same check, optionally  emit an error text
+# TestVersion:  just returns if the specified product/version combination exists
+# CheckVersion: same check, optionally emit an error text
+
+sub TestProduct ($)
+{
+    my $prod = shift;
+
+    # does the product exist?
+    SendSQL("SELECT product
+             FROM products
+             WHERE product=" . SqlQuote($prod));
+    return FetchOneColumn();
+}
+
+sub CheckProduct ($)
+{
+    my $prod = shift;
+
+    # do we have a product?
+    unless ($prod) {
+        print "Sorry, you haven't specified a product.";
+        PutTrailer();
+        exit;
+    }
+
+    unless (TestProduct $prod) {
+        print "Sorry, product '$prod' does not exist.";
+        PutTrailer();
+        exit;
+    }
+}
+
+sub TestVersion ($$)
+{
+    my ($prod,$ver) = @_;
+
+    # does the product exist?
+    SendSQL("SELECT program,value
+             FROM versions
+             WHERE program=" . SqlQuote($prod) . " and value=" . SqlQuote($ver));
+    return FetchOneColumn();
+}
+
+sub CheckVersion ($$)
+{
+    my ($prod,$ver) = @_;
+
+    # do we have the version?
+    unless ($ver) {
+        print "Sorry, you haven't specified a version.";
+        PutTrailer();
+        exit;
+    }
+
+    CheckProduct($prod);
+
+    unless (TestVersion $prod,$ver) {
+        print "Sorry, version '$ver' for product '$prod' does not exist.";
+        PutTrailer();
+        exit;
+    }
+}
+
+
+#
+# Displays the form to edit a version
+#
+
+sub EmitFormElements ($$)
+{
+    my ($product, $version) = @_;
+
+    print "  <TH ALIGN=\"right\">Version:</TH>\n";
+    print "  <TD><INPUT SIZE=64 MAXLENGTH=64 NAME=\"version\" VALUE=\"$version\">\n";
+    print "      <INPUT TYPE=HIDDEN NAME=\"product\" VALUE=\"$product\"></TD>\n";
+}
+
+
+#
+# Displays a text like "a.", "a or b.", "a, b or c.", "a, b, c or d."
+#
+
+sub PutTrailer (@)
+{
+    my (@links) = ("Back to the <A HREF=\"query.cgi\">query page</A>", @_);
+
+    my $count = $#links;
+    my $num = 0;
+    print "<P>\n";
+    foreach (@links) {
+        print $_;
+        if ($num == $count) {
+            print ".\n";
+        }
+        elsif ($num == $count-1) {
+            print " or ";
+        }
+        else {
+            print ", ";
+        }
+        $num++;
+    }
+    print "</BODY>\n</HTML>\n";
+}
+
+
+
+
+
+
+
+#
+# Preliminary checks:
+#
+
+confirm_login();
+
+print "Content-type: text/html\n\n";
+
+unless (UserInGroup("editcomponents")) {
+    PutHeader("Not allowed");
+    print "Sorry, you aren't a member of the 'editcomponents' group.\n";
+    print "And so, you aren't allowed to add, modify or delete versions.\n";
+    PutTrailer();
+    exit;
+}
+
+
+#
+# often used variables
+#
+my $product = trim($::FORM{product} || '');
+my $version = trim($::FORM{version} || '');
+my $action  = trim($::FORM{action}  || '');
+my $localtrailer;
+if ($version) {
+    $localtrailer = "<A HREF=\"editversions.cgi?product=" . url_quote($product) . "\">edit</A> more versions";
+} else {
+    $localtrailer = "<A HREF=\"editversions.cgi\">edit</A> more versions";
+}
+
+
+
+#
+# product = '' -> Show nice list of versions
+#
+
+unless ($product) {
+    PutHeader("Select product");
+
+    SendSQL("SELECT products.product,products.description,'xyzzy'
+             FROM products 
+             GROUP BY products.product
+             ORDER BY products.product");
+    print "<TABLE BORDER=1 CELLPADDING=4 CELLSPACING=0><TR BGCOLOR=\"#6666FF\">\n";
+    print "  <TH ALIGN=\"left\">Edit versions of ...</TH>\n";
+    print "  <TH ALIGN=\"left\">Description</TH>\n";
+    print "  <TH ALIGN=\"left\">Bugs</TH>\n";
+    #print "  <TH ALIGN=\"left\">Edit</TH>\n";
+    print "</TR>";
+    while ( MoreSQLData() ) {
+        my ($product, $description, $bugs) = FetchSQLData();
+        $description ||= "<FONT COLOR=\"red\">missing</FONT>";
+        $bugs ||= "none";
+        print "<TR>\n";
+        print "  <TD VALIGN=\"top\"><A HREF=\"editversions.cgi?product=", url_quote($product), "\"><B>$product</B></A></TD>\n";
+        print "  <TD VALIGN=\"top\">$description</TD>\n";
+        print "  <TD VALIGN=\"top\">$bugs</TD>\n";
+        #print "  <TD VALIGN=\"top\"><A HREF=\"editversions.cgi?action=edit&product=", url_quote($product), "\">Edit</A></TD>\n";
+    }
+    print "</TR></TABLE>\n";
+
+    PutTrailer();
+    exit;
+}
+
+
+
+#
+# action='' -> Show nice list of versions
+#
+
+unless ($action) {
+    PutHeader("Select version");
+    CheckProduct($product);
+
+=for me
+
+    # Das geht nicht wie vermutet. Ich bekomme nicht alle Versionen
+    # angezeigt!  Schade. Ich würde gerne sehen, wieviel Bugs pro
+    # Version angegeben sind ...
+
+    SendSQL("SELECT value,program,COUNT(bug_id)
+             FROM versions LEFT JOIN bugs
+               ON program=product AND value=version
+             WHERE program=" . SqlQuote($product) . "
+             GROUP BY value");
+
+=cut
+
+    SendSQL("SELECT value,program
+             FROM versions 
+             WHERE program=" . SqlQuote($product) . "
+             ORDER BY value");
+
+    print "<TABLE BORDER=1 CELLPADDING=4 CELLSPACING=0><TR BGCOLOR=\"#6666FF\">\n";
+    print "  <TH ALIGN=\"left\">Edit version ...</TH>\n";
+    #print "  <TH ALIGN=\"left\">Bugs</TH>\n";
+    print "  <TH ALIGN=\"left\">Action</TH>\n";
+    print "</TR>";
+    while ( MoreSQLData() ) {
+        my ($version,$dummy,$bugs) = FetchSQLData();
+        $bugs ||= 'none';
+        print "<TR>\n";
+        print "  <TD VALIGN=\"top\"><A HREF=\"editversions.cgi?product=", url_quote($product), "&version=", url_quote($version), "&action=edit\"><B>$version</B></A></TD>\n";
+        #print "  <TD VALIGN=\"top\">$bugs</TD>\n";
+        print "  <TD VALIGN=\"top\"><A HREF=\"editversions.cgi?product=", url_quote($product), "&version=", url_quote($version), "&action=del\"><B>Delete</B></A></TD>\n";
+        print "</TR>";
+    }
+    print "<TR>\n";
+    print "  <TD VALIGN=\"top\">Add a new version</TD>\n";
+    print "  <TD VALIGN=\"top\" ALIGN=\"middle\"><A HREF=\"editversions.cgi?product=", url_quote($product) . "&action=add\">Add</A></TD>\n";
+    print "</TR></TABLE>\n";
+
+    PutTrailer();
+    exit;
+}
+
+
+
+
+#
+# action='add' -> present form for parameters for new version
+#
+# (next action will be 'new')
+#
+
+if ($action eq 'add') {
+    PutHeader("Add version");
+    CheckProduct($product);
+
+    #print "This page lets you add a new version to a bugzilla-tracked product.\n";
+
+    print "<FORM METHOD=POST ACTION=editversions.cgi>\n";
+    print "<TABLE BORDER=0 CELLPADDING=4 CELLSPACING=0><TR>\n";
+
+    EmitFormElements($product, $version);
+
+    print "</TABLE>\n<HR>\n";
+    print "<INPUT TYPE=SUBMIT VALUE=\"Add\">\n";
+    print "<INPUT TYPE=HIDDEN NAME=\"action\" VALUE=\"new\">\n";
+    print "</FORM>";
+
+    my $other = $localtrailer;
+    $other =~ s/more/other/;
+    PutTrailer($other);
+    exit;
+}
+
+
+
+#
+# action='new' -> add version entered in the 'action=add' screen
+#
+
+if ($action eq 'new') {
+    PutHeader("Adding new version");
+    CheckProduct($product);
+
+    # Cleanups and valididy checks
+
+    unless ($version) {
+        print "You must enter a text for the new version. Please press\n";
+        print "<b>Back</b> and try again.\n";
+        PutTrailer($localtrailer);
+        exit;
+    }
+    if (TestVersion($product,$version)) {
+        print "The version '$version' already exists. Please press\n";
+        print "<b>Back</b> and try again.\n";
+        PutTrailer($localtrailer);
+        exit;
+    }
+
+    # Add the new version
+    SendSQL("INSERT INTO versions ( " .
+          "value, program" .
+          " ) VALUES ( " .
+          SqlQuote($version) . "," .
+          SqlQuote($product) . ")");
+
+    # Make versioncache flush
+    unlink "data/versioncache";
+
+    print "OK, done.<p>\n";
+    PutTrailer($localtrailer);
+    exit;
+}
+
+
+
+
+#
+# action='del' -> ask if user really wants to delete
+#
+# (next action would be 'delete')
+#
+
+if ($action eq 'del') {
+    PutHeader("Delete version");
+    CheckVersion($product, $version);
+
+    SendSQL("SELECT count(bug_id),product,version
+             FROM bugs
+             GROUP BY product,version
+             HAVING product=" . SqlQuote($product) . "
+                AND version=" . SqlQuote($version));
+    my $bugs = FetchOneColumn();
+
+    print "<TABLE BORDER=1 CELLPADDING=4 CELLSPACING=0>\n";
+    print "<TR BGCOLOR=\"#6666FF\">\n";
+    print "  <TH VALIGN=\"top\" ALIGN=\"left\">Part</TH>\n";
+    print "  <TH VALIGN=\"top\" ALIGN=\"left\">Value</TH>\n";
+
+    print "</TR><TR>\n";
+    print "  <TH ALIGN=\"left\" VALIGN=\"top\">Product:</TH>\n";
+    print "  <TD VALIGN=\"top\">$product</TD>\n";
+    print "</TR><TR>\n";
+    print "  <TH ALIGN=\"left\" VALIGN=\"top\">Version:</TH>\n";
+    print "  <TD VALIGN=\"top\">$version</TD>\n";
+    print "</TR><TR>\n";
+    print "  <TH ALIGN=\"left\" VALIGN=\"top\">Bugs:</TH>\n";
+    print "  <TD VALIGN=\"top\">", $bugs || 'none' , "</TD>\n";
+    print "</TR></TABLE>\n";
+
+    print "<H2>Confirmation</H2>\n";
+
+    if ($bugs) {
+        if (!Param("allowbugdeletion")) {
+            print "Sorry, there are $bugs bugs outstanding for this version.
+You must reassign those bugs to another version before you can delete this
+one.";
+            PutTrailer($localtrailer);
+            exit;
+        }
+        print "<TABLE BORDER=0 CELLPADDING=20 WIDTH=\"70%\" BGCOLOR=\"red\"><TR><TD>\n",
+              "There are bugs entered for this version!  When you delete this ",
+              "version, <B><BLINK>all</BLINK></B> stored bugs will be deleted, too. ",
+              "You could not even see the bug history for this version anymore!\n",
+              "</TD></TR></TABLE>\n";
+    }
+
+    print "<P>Do you really want to delete this version?<P>\n";
+    print "<FORM METHOD=POST ACTION=editversions.cgi>\n";
+    print "<INPUT TYPE=SUBMIT VALUE=\"Yes, delete\">\n";
+    print "<INPUT TYPE=HIDDEN NAME=\"action\" VALUE=\"delete\">\n";
+    print "<INPUT TYPE=HIDDEN NAME=\"product\" VALUE=\"$product\">\n";
+    print "<INPUT TYPE=HIDDEN NAME=\"version\" VALUE=\"$version\">\n";
+    print "</FORM>";
+
+    PutTrailer($localtrailer);
+    exit;
+}
+
+
+
+#
+# action='delete' -> really delete the version
+#
+
+if ($action eq 'delete') {
+    PutHeader("Deleting version");
+    CheckVersion($product,$version);
+
+    # lock the tables before we start to change everything:
+
+    SendSQL("LOCK TABLES attachments WRITE,
+                         bugs WRITE,
+                         bugs_activity WRITE,
+                         versions WRITE,
+                         dependencies WRITE");
+
+    # According to MySQL doc I cannot do a DELETE x.* FROM x JOIN Y,
+    # so I have to iterate over bugs and delete all the indivial entries
+    # in bugs_activies and attachments.
+
+    SendSQL("SELECT bug_id
+             FROM bugs
+             WHERE product=" . SqlQuote($product) . "
+               AND version=" . SqlQuote($version));
+    while (MoreSQLData()) {
+        my $bugid = FetchOneColumn();
+
+        my $query = $::db->query("DELETE FROM attachments WHERE bug_id=$bugid")
+                or die "$::db_errstr";
+        $query = $::db->query("DELETE FROM bugs_activity WHERE bug_id=$bugid")
+                or die "$::db_errstr";
+        $query = $::db->query("DELETE FROM dependencies WHERE blocked=$bugid")
+                or die "$::db_errstr";
+    }
+    print "Attachments, bug activity and dependencies deleted.<BR>\n";
+
+
+    # Deleting the rest is easier:
+
+    SendSQL("DELETE FROM bugs
+             WHERE product=" . SqlQuote($product) . "
+               AND version=" . SqlQuote($version));
+    print "Bugs deleted.<BR>\n";
+
+    SendSQL("DELETE FROM versions
+             WHERE program=" . SqlQuote($product) . "
+               AND value=" . SqlQuote($version));
+    print "Version deleted.<P>\n";
+    SendSQL("UNLOCK TABLES");
+
+    unlink "data/versioncache";
+    PutTrailer($localtrailer);
+    exit;
+}
+
+
+
+#
+# action='edit' -> present the edit version form
+#
+# (next action would be 'update')
+#
+
+if ($action eq 'edit') {
+    PutHeader("Edit version");
+    CheckVersion($product,$version);
+
+    print "<FORM METHOD=POST ACTION=editversions.cgi>\n";
+    print "<TABLE BORDER=0 CELLPADDING=4 CELLSPACING=0><TR>\n";
+
+    EmitFormElements($product, $version);
+
+    print "</TR></TABLE>\n";
+
+    print "<INPUT TYPE=HIDDEN NAME=\"versionold\" VALUE=\"$version\">\n";
+    print "<INPUT TYPE=HIDDEN NAME=\"action\" VALUE=\"update\">\n";
+    print "<INPUT TYPE=SUBMIT VALUE=\"Update\">\n";
+
+    print "</FORM>";
+
+    my $other = $localtrailer;
+    $other =~ s/more/other/;
+    PutTrailer($other);
+    exit;
+}
+
+
+
+#
+# action='update' -> update the version
+#
+
+if ($action eq 'update') {
+    PutHeader("Update version");
+
+    my $versionold = trim($::FORM{versionold} || '');
+
+    CheckVersion($product,$versionold);
+
+    # Note that the order of this tests is important. If you change
+    # them, be sure to test for WHERE='$version' or WHERE='$versionold'
+
+    SendSQL("LOCK TABLES bugs WRITE,
+                         versions WRITE");
+
+    if ($version ne $versionold) {
+        unless ($version) {
+            print "Sorry, I can't delete the version text.";
+            PutTrailer($localtrailer);
+	    SendSQL("UNLOCK TABLES");
+            exit;
+        }
+        if (TestVersion($product,$version)) {
+            print "Sorry, version '$version' is already in use.";
+            PutTrailer($localtrailer);
+	    SendSQL("UNLOCK TABLES");
+            exit;
+        }
+        SendSQL("UPDATE bugs
+                 SET version=" . SqlQuote($version) . "
+                 WHERE version=" . SqlQuote($versionold) . "
+                   AND product=" . SqlQuote($product));
+        SendSQL("UPDATE versions
+                 SET value=" . SqlQuote($version) . "
+                 WHERE program=" . SqlQuote($product) . "
+                   AND value=" . SqlQuote($versionold));
+        unlink "data/versioncache";
+        print "Updated version.<BR>\n";
+    }
+    SendSQL("UNLOCK TABLES");
+
+    PutTrailer($localtrailer);
+    exit;
+}
+
+
+
+#
+# No valid action found
+#
+
+PutHeader("Error");
+print "I don't have a clue what you want.<BR>\n";
+
+foreach ( sort keys %::FORM) {
+    print "$_: $::FORM{$_}<BR>\n";
+}