diff options
| author | Dave Lawrence <dlawrence@mozilla.com> | 2013-04-11 16:16:09 +0200 |
|---|---|---|
| committer | Dave Lawrence <dlawrence@mozilla.com> | 2013-04-11 16:16:09 +0200 |
| commit | d69ae9f2cc2d243a79dd0e4dee38dd44bccab8c3 (patch) | |
| tree | 9a4668739c8b581cdfb325568e83bd5007d92a6d /extensions/ProductDashboard/Extension.pm | |
| parent | d89e6ea5025094d0ee1561e9ba2ff739e59df26c (diff) | |
| download | bugzilla-d69ae9f2cc2d243a79dd0e4dee38dd44bccab8c3.tar.gz bugzilla-d69ae9f2cc2d243a79dd0e4dee38dd44bccab8c3.tar.xz | |
Bug 860657 - 'Illegal division by zero' on product dashboard when the product has zero bugs
Diffstat (limited to 'extensions/ProductDashboard/Extension.pm')
| -rw-r--r-- | extensions/ProductDashboard/Extension.pm | 22 |
1 files changed, 15 insertions, 7 deletions
diff --git a/extensions/ProductDashboard/Extension.pm b/extensions/ProductDashboard/Extension.pm index 57192f195..1e6ddffe9 100644 --- a/extensions/ProductDashboard/Extension.pm +++ b/extensions/ProductDashboard/Extension.pm @@ -108,8 +108,16 @@ sub _page_dashboard { $vars->{'total_closed_bugs'} = total_closed_bugs($product); $vars->{'severities'} = get_legal_field_values('bug_severity'); - $vars->{'open_bugs_percentage'} = int($vars->{'total_open_bugs'} / $vars->{'total_bugs'} * 100); - $vars->{'closed_bugs_percentage'} = int($vars->{'total_closed_bugs'} / $vars->{'total_bugs'} * 100); + if ($vars->{'total_bugs'}) { + $vars->{'open_bugs_percentage'} + = int($vars->{'total_open_bugs'} / $vars->{'total_bugs'} * 100); + $vars->{'closed_bugs_percentage'} + = int($vars->{'total_closed_bugs'} / $vars->{'total_bugs'} * 100); + } + else { + $vars->{'open_bugs_percentage'} = 0; + $vars->{'closed_bugs_percentage'} = 0; + } if ($current_tab_name eq 'summary') { $vars->{'by_priority'} = by_priority($product, $bug_status); @@ -142,14 +150,14 @@ sub _page_dashboard { $vars->{'summary'} = by_value_summary($product, 'component', $input->{'component'}, $bug_status); $vars->{'summary'}{'type'} = 'component'; $vars->{'summary'}{'value'} = $input->{'component'}; - } + } elsif ($input->{'version'}) { - $vars->{'summary'} = by_value_summary($product, 'version', $input->{'version'}, $bug_status); + $vars->{'summary'} = by_value_summary($product, 'version', $input->{'version'}, $bug_status); $vars->{'summary'}{'type'} = 'version'; $vars->{'summary'}{'value'} = $input->{'version'}; - } + } elsif ($input->{'target_milestone'} && Bugzilla->params->{'usetargetmilestone'}) { - $vars->{'summary'} = by_value_summary($product, 'target_milestone', $input->{'target_milestone'}, $bug_status); + $vars->{'summary'} = by_value_summary($product, 'target_milestone', $input->{'target_milestone'}, $bug_status); $vars->{'summary'}{'type'} = 'target_milestone'; $vars->{'summary'}{'value'} = $input->{'target_milestone'}; } @@ -180,7 +188,7 @@ sub _page_dashboard { $milestone_stats{'link_total'} = bug_milestone_link_total($product, $milestone); $milestone_stats{'link_open'} = bug_milestone_link_open($product, $milestone); $milestone_stats{'link_closed'} = bug_milestone_link_closed($product, $milestone); - $milestone_stats{'percentage'} = $milestone_stats{'total_bugs'} + $milestone_stats{'percentage'} = $milestone_stats{'total_bugs'} ? int(($milestone_stats{'closed_bugs'} / $milestone_stats{'total_bugs'}) * 100) : 0; push (@{$vars->{'by_roadmap'}}, \%milestone_stats); |