Bug 804708: Add a 'Review' extension to customise the review flag for Mozilla's workflow (make requestee/reviewer mandatory, provide review suggestions, etc)

9 files changed, 230 insertions, 0 deletions

diff --git a/extensions/Review/template/en/default/hook/admin/components/edit-common-rows.html.tmpl b/extensions/Review/template/en/default/hook/admin/components/edit-common-rows.html.tmpl
new file mode 100644
index 000000000..befb183b2
--- /dev/null
+++ b/extensions/Review/template/en/default/hook/admin/components/edit-common-rows.html.tmpl
@@ -0,0 +1,22 @@
+[%# This Source Code Form is subject to the terms of the Mozilla Public
+  # License, v. 2.0. If a copy of the MPL was not distributed with this
+  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
+  #
+  # This Source Code Form is "Incompatible With Secondary Licenses", as
+  # defined by the Mozilla Public License, v. 2.0.
+  #%]
+
+<tr>
+  <th align="right">Suggested Reviewers:</th>
+  <td>
+    [% INCLUDE global/userselect.html.tmpl
+       id => "reviewers"
+       name => "reviewers"
+       value => comp.reviewers
+       size => 64
+       emptyok => 1
+       title => "One or more email address (comma delimited)"
+       placeholder => product.reviewers
+    %]
+  </td>
+</tr>
diff --git a/extensions/Review/template/en/default/hook/admin/products/edit-common-rows.html.tmpl b/extensions/Review/template/en/default/hook/admin/products/edit-common-rows.html.tmpl
new file mode 100644
index 000000000..da41f7dde
--- /dev/null
+++ b/extensions/Review/template/en/default/hook/admin/products/edit-common-rows.html.tmpl
@@ -0,0 +1,28 @@
+[%# This Source Code Form is subject to the terms of the Mozilla Public
+  # License, v. 2.0. If a copy of the MPL was not distributed with this
+  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
+  #
+  # This Source Code Form is "Incompatible With Secondary Licenses", as
+  # defined by the Mozilla Public License, v. 2.0.
+  #%]
+
+<tr>
+  <th align="right">Reviewer required:</th>
+  <td>
+    <input type="checkbox" name="reviewer_required" value="1"
+      [% "checked" IF product.reviewer_required %]>
+  </td>
+</tr>
+<tr>
+  <th align="right">Suggested Reviewers:</th>
+  <td>
+    [% INCLUDE global/userselect.html.tmpl
+       id => "reviewers"
+       name => "reviewers"
+       value => product.reviewers
+       size => 64
+       emptyok => 1
+       title => "One or more email address (comma delimited)"
+    %]
+  </td>
+</tr>
diff --git a/extensions/Review/template/en/default/hook/admin/products/updated-changes.html.tmpl b/extensions/Review/template/en/default/hook/admin/products/updated-changes.html.tmpl
new file mode 100644
index 000000000..667848281
--- /dev/null
+++ b/extensions/Review/template/en/default/hook/admin/products/updated-changes.html.tmpl
@@ -0,0 +1,19 @@
+[%# This Source Code Form is subject to the terms of the Mozilla Public
+  # License, v. 2.0. If a copy of the MPL was not distributed with this
+  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
+  #
+  # This Source Code Form is "Incompatible With Secondary Licenses", as
+  # defined by the Mozilla Public License, v. 2.0.
+  #%]
+
+[% IF changes.reviewers.defined %]
+  <p>
+    Updated suggested reviewers from '[% changes.reviewers.0 FILTER html %]' to
+    '[% product.reviewers FILTER html %]'.
+  </p>
+[% END %]
+[% IF changes.reviewer_required.defined %]
+  <p>
+    [% changes.reviewer_required.1 ? "Enabled" : "Disabled" %] 'review required'.
+  </p>
+[% END %]
diff --git a/extensions/Review/template/en/default/hook/attachment/create-end.html.tmpl b/extensions/Review/template/en/default/hook/attachment/create-end.html.tmpl
new file mode 100644
index 000000000..c8e2a68a1
--- /dev/null
+++ b/extensions/Review/template/en/default/hook/attachment/create-end.html.tmpl
@@ -0,0 +1,20 @@
+[%# This Source Code Form is subject to the terms of the Mozilla Public
+  # License, v. 2.0. If a copy of the MPL was not distributed with this
+  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
+  #
+  # This Source Code Form is "Incompatible With Secondary Licenses", as
+  # defined by the Mozilla Public License, v. 2.0.
+  #%]
+
+[% UNLESS bug %]
+  [% bug = attachment.bug %]
+[% END %]
+
+[% IF bug.product_obj.reviewer_required %]
+<script>
+  YAHOO.util.Event.onDOMReady(function() {
+    REVIEW.init_mandatory();
+    REVIEW.init_create_attachment();
+  });
+</script>
+[% END %]
diff --git a/extensions/Review/template/en/default/hook/attachment/edit-end.html.tmpl b/extensions/Review/template/en/default/hook/attachment/edit-end.html.tmpl
new file mode 100644
index 000000000..bc6230d1c
--- /dev/null
+++ b/extensions/Review/template/en/default/hook/attachment/edit-end.html.tmpl
@@ -0,0 +1,15 @@
+[%# This Source Code Form is subject to the terms of the Mozilla Public
+  # License, v. 2.0. If a copy of the MPL was not distributed with this
+  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
+  #
+  # This Source Code Form is "Incompatible With Secondary Licenses", as
+  # defined by the Mozilla Public License, v. 2.0.
+  #%]
+
+[% IF attachment.bug.product_obj.reviewer_required %]
+<script>
+YAHOO.util.Event.onDOMReady(function() {
+  REVIEW.init_mandatory();
+});
+</script>
+[% END %]
diff --git a/extensions/Review/template/en/default/hook/bug/create/create-end.html.tmpl b/extensions/Review/template/en/default/hook/bug/create/create-end.html.tmpl
new file mode 100644
index 000000000..a59cef950
--- /dev/null
+++ b/extensions/Review/template/en/default/hook/bug/create/create-end.html.tmpl
@@ -0,0 +1,16 @@
+[%# This Source Code Form is subject to the terms of the Mozilla Public
+  # License, v. 2.0. If a copy of the MPL was not distributed with this
+  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
+  #
+  # This Source Code Form is "Incompatible With Secondary Licenses", as
+  # defined by the Mozilla Public License, v. 2.0.
+  #%]
+
+<script>
+  YAHOO.util.Event.onDOMReady(function() {
+    [% IF product.reviewer_required %]
+      REVIEW.init_mandatory();
+    [% END %]
+    REVIEW.init_enter_bug();
+  });
+</script>
diff --git a/extensions/Review/template/en/default/hook/flag/list-requestee.html.tmpl b/extensions/Review/template/en/default/hook/flag/list-requestee.html.tmpl
new file mode 100644
index 000000000..a3f0e8a44
--- /dev/null
+++ b/extensions/Review/template/en/default/hook/flag/list-requestee.html.tmpl
@@ -0,0 +1,17 @@
+[%# This Source Code Form is subject to the terms of the Mozilla Public
+  # License, v. 2.0. If a copy of the MPL was not distributed with this
+  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
+  #
+  # This Source Code Form is "Incompatible With Secondary Licenses", as
+  # defined by the Mozilla Public License, v. 2.0.
+  #%]
+
+[% RETURN UNLESS type.name == 'review' %]
+
+<span id="[% fid FILTER none %]_suggestions" class="bz_default_hidden">
+  &nbsp;&nbsp;(<a href="#" id="[% fid FILTER none %]_suggestions_link">suggested reviewers</a>)
+</span>
+
+<script>
+  REVIEW.init_review_flag('[% fid FILTER none %]', '[% flag_name FILTER none %]');
+</script>
diff --git a/extensions/Review/template/en/default/hook/global/header-start.html.tmpl b/extensions/Review/template/en/default/hook/global/header-start.html.tmpl
new file mode 100644
index 000000000..6063aa920
--- /dev/null
+++ b/extensions/Review/template/en/default/hook/global/header-start.html.tmpl
@@ -0,0 +1,81 @@
+[%# This Source Code Form is subject to the terms of the Mozilla Public
+  # License, v. 2.0. If a copy of the MPL was not distributed with this
+  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
+  #
+  # This Source Code Form is "Incompatible With Secondary Licenses", as
+  # defined by the Mozilla Public License, v. 2.0.
+  #%]
+
+[% RETURN UNLESS template.name == 'attachment/edit.html.tmpl'
+      || template.name == 'attachment/create.html.tmpl'
+      || template.name == 'attachment/diff-header.html.tmpl'
+      || template.name == 'bug/create/create.html.tmpl' %]
+
+[% style_urls.push('extensions/Review/web/style/review.css') %]
+[% javascript_urls.push('extensions/Review/web/js/review.js') %]
+
+[% IF bug %]
+  [%# create attachment %]
+  [% mentor = bug.mentor %]
+  [% product_obj = bug.product_obj %]
+  [% component_obj = bug.component_obj %]
+[% ELSIF attachment.bug %]
+  [%# edit attachment %]
+  [% mentor = attachment.bug.mentor %]
+  [% product_obj = attachment.bug.product_obj %]
+  [% component_obj = attachment.bug.component_obj %]
+[% ELSE %]
+  [%# create bug %]
+  [% mentor = '' %]
+  [% product_obj = product %]
+  [% component_obj = 0 %]
+[% END %]
+
+[% review_js = BLOCK %]
+  review_suggestions = {
+    [% IF mentor %]
+      _mentor: [% PROCESS reviewer u = mentor %],
+    [% END %]
+
+    [% IF product_obj.reviewers %]
+      _product: [
+        [% FOREACH u = product_obj.reviewers_objs %]
+          [% PROCESS reviewer %][% "," UNLESS loop.last %]
+        [% END %]
+      ],
+    [% END %]
+
+    [% IF component_obj %]
+      [%# single component (create/edit attachment) %]
+      '[% component_obj.name FILTER js %]': [
+        [% FOREACH u = component_obj.reviewers_objs %]
+          [% PROCESS reviewer %][% "," UNLESS loop.last %]
+        [% END %]
+      ],
+    [% ELSE %]
+      [%# all components (create bug) %]
+      [% FOREACH c = product_obj.components %]
+        [% NEXT UNLESS c.reviewers %]
+        '[% c.name FILTER js %]': [
+          [% FOREACH u = c.reviewers_objs %]
+            [% PROCESS reviewer %][% "," UNLESS loop.last %]
+          [% END %]
+        ],
+      [% END %]
+    [% END %]
+
+    [%# to keep IE happy, no trailing commas %]
+    _end: 1
+  };
+
+  [% IF component_obj %]
+    static_component = '[% component_obj.name FILTER js %]';
+  [% ELSE %]
+    static_component = false;
+  [% END %]
+[% END %]
+[% javascript = javascript _ review_js %]
+
+[% BLOCK reviewer %]
+  { login: '[% u.login FILTER js%]', identity: '[% u.identity FILTER js %]' }
+[% END %]
diff --git a/extensions/Review/template/en/default/hook/global/user-error-errors.html.tmpl b/extensions/Review/template/en/default/hook/global/user-error-errors.html.tmpl
new file mode 100644
index 000000000..4265f4b32
--- /dev/null
+++ b/extensions/Review/template/en/default/hook/global/user-error-errors.html.tmpl
@@ -0,0 +1,12 @@
+[%# This Source Code Form is subject to the terms of the Mozilla Public
+  # License, v. 2.0. If a copy of the MPL was not distributed with this
+  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
+  #
+  # This Source Code Form is "Incompatible With Secondary Licenses", as
+  # defined by the Mozilla Public License, v. 2.0.
+  #%]
+
+[% IF error == "reviewer_required" %]
+  [% title = "Reviewer Required" %]
+  You must provide a reviewer for review requests.
+[% END %]