diff options
| author | Byron Jones <bjones@mozilla.com> | 2013-04-04 07:44:35 +0200 |
|---|---|---|
| committer | Byron Jones <bjones@mozilla.com> | 2013-04-04 07:44:35 +0200 |
| commit | 026a32a69dabcef8cf337326fe70f39bdd7e45b2 (patch) | |
| tree | c6b774daf106aed1ac6360140a94eabd570f3818 /extensions | |
| parent | a99582f977670f776f3eaf587db0107407738722 (diff) | |
| download | bugzilla-026a32a69dabcef8cf337326fe70f39bdd7e45b2.tar.gz bugzilla-026a32a69dabcef8cf337326fe70f39bdd7e45b2.tar.xz | |
Bug 856110: fix broken review links
Diffstat (limited to 'extensions')
| -rw-r--r-- | extensions/MyDashboard/template/en/default/pages/mydashboard.html.tmpl | 2 | ||||
| -rw-r--r-- | extensions/MyDashboard/web/js/flags.js | 13 |
2 files changed, 5 insertions, 10 deletions
diff --git a/extensions/MyDashboard/template/en/default/pages/mydashboard.html.tmpl b/extensions/MyDashboard/template/en/default/pages/mydashboard.html.tmpl index 404a86a1a..55936f0bf 100644 --- a/extensions/MyDashboard/template/en/default/pages/mydashboard.html.tmpl +++ b/extensions/MyDashboard/template/en/default/pages/mydashboard.html.tmpl @@ -69,7 +69,7 @@ <script type="text/javascript"> [% IF Param('splinter_base') %] - MyDashboard.splinter_base = '[% Param('splinter_base') FILTER js %]'; + MyDashboard.splinter_base = '[% Bugzilla.splinter_review_base FILTER js %]'; [% END %] </script> diff --git a/extensions/MyDashboard/web/js/flags.js b/extensions/MyDashboard/web/js/flags.js index fa06a00d4..29afefabb 100644 --- a/extensions/MyDashboard/web/js/flags.js +++ b/extensions/MyDashboard/web/js/flags.js @@ -6,12 +6,6 @@ * defined by the Mozilla Public License, v. 2.0. */ -if (typeof(MyDashboard) == 'undefined') { - var MyDashboard = {}; -} - -MyDashboard.splinter_base = 'page.cgi?id=splinter.html'; - // Flag tables YUI({ base: 'js/yui3/', @@ -99,11 +93,12 @@ YUI({ }; var flagNameFormatter = function (o) { - if (o.data.attach_id && o.data.is_patch) { + if (o.data.attach_id && o.data.is_patch && MyDashboard.splinter_base) { return '<a href="' + MyDashboard.splinter_base + - '&bug=' + encodeURIComponent(o.data.bug_id) + + (MyDashboard.splinter_base.indexOf('?') == -1 ? '?' : '&') + + 'bug=' + encodeURIComponent(o.data.bug_id) + '&attachment=' + encodeURIComponent(o.data.attach_id) + - '" title="Click flag name to go to patch review page">' + + '" title="Review this patch">' + Y.Escape.html(o.value) + '</a>'; } else { |