diff options
author | Max Kanat-Alexander <mkanat@bugzilla.org> | 2010-12-12 19:55:17 +0100 |
---|---|---|
committer | Max Kanat-Alexander <mkanat@bugzilla.org> | 2010-12-12 19:55:17 +0100 |
commit | 9fe88ea66a28168e940bf02038d4055a5e00a4ee (patch) | |
tree | a18447396b5866da06fa51f6132a4707f8f8462d /extensions | |
parent | fae7f1233435d9d13413b41181bb41ee8b51e8c9 (diff) | |
download | bugzilla-9fe88ea66a28168e940bf02038d4055a5e00a4ee.tar.gz bugzilla-9fe88ea66a28168e940bf02038d4055a5e00a4ee.tar.xz |
Bug 618161: Make VERSION into a constant in two included extensions so that
calling $class->VERSION on them won't throw an error on Perl 5.12 when there
are non-numeric characters in BUGZILLA_VERSION.
r=LpSolit, a=LpSolit
Diffstat (limited to 'extensions')
-rw-r--r-- | extensions/OldBugMove/Extension.pm | 4 | ||||
-rw-r--r-- | extensions/Voting/Extension.pm | 3 |
2 files changed, 3 insertions, 4 deletions
diff --git a/extensions/OldBugMove/Extension.pm b/extensions/OldBugMove/Extension.pm index 3aca16a57..b12d36a9a 100644 --- a/extensions/OldBugMove/Extension.pm +++ b/extensions/OldBugMove/Extension.pm @@ -32,12 +32,12 @@ use Bugzilla::Util qw(trim); use Scalar::Util qw(blessed); use Storable qw(dclone); +use constant VERSION => BUGZILLA_VERSION; + # This is 4 because that's what it originally was when this code was # a part of Bugzilla. use constant CMT_MOVED_TO => 4; -our $VERSION = BUGZILLA_VERSION; - sub install_update_db { my $reso_type = Bugzilla::Field::Choice->type('resolution'); my $moved_reso = $reso_type->new({ name => 'MOVED' }); diff --git a/extensions/Voting/Extension.pm b/extensions/Voting/Extension.pm index 74e327098..d94ff8430 100644 --- a/extensions/Voting/Extension.pm +++ b/extensions/Voting/Extension.pm @@ -40,6 +40,7 @@ use Bugzilla::Util qw(detaint_natural); use List::Util qw(min); use constant NAME => 'Voting'; +use constant VERSION => BUGZILLA_VERSION; use constant DEFAULT_VOTES_PER_BUG => 1; # These came from Bugzilla itself, so they maintain the old numbers # they had before. @@ -50,8 +51,6 @@ use constant REL_VOTER => 4; # Installation # ################ -our $VERSION = BUGZILLA_VERSION; - sub db_schema_abstract_schema { my ($self, $args) = @_; $args->{'schema'}->{'votes'} = { |