diff options
| author | bugreport%peshkin.net <> | 2004-07-31 11:27:23 +0200 |
|---|---|---|
| committer | bugreport%peshkin.net <> | 2004-07-31 11:27:23 +0200 |
| commit | 4c1db37570469aef2c7cc9f2ad9f859560ca8851 (patch) | |
| tree | 17a519e7f08a85993b710ecd6d809bd9e4b40211 /globals.pl | |
| parent | 1ffd632931b05caea45f9c48079b455d156086be (diff) | |
| download | bugzilla-4c1db37570469aef2c7cc9f2ad9f859560ca8851.tar.gz bugzilla-4c1db37570469aef2c7cc9f2ad9f859560ca8851.tar.xz | |
Bug 253588: Change Bugzilla->user to be usable even for a logged-out user
patch by erik,joel
r=kiko
a=justdave
Diffstat (limited to 'globals.pl')
| -rw-r--r-- | globals.pl | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/globals.pl b/globals.pl index 07eb573f5..d1680959e 100644 --- a/globals.pl +++ b/globals.pl @@ -482,7 +482,7 @@ sub CanEditProductId { my $query = "SELECT group_id FROM group_control_map " . "WHERE product_id = $productid " . "AND canedit != 0 "; - if (defined Bugzilla->user && %{Bugzilla->user->groups}) { + if (%{Bugzilla->user->groups}) { $query .= "AND group_id NOT IN(" . join(',', values(%{Bugzilla->user->groups})) . ") "; } @@ -504,7 +504,7 @@ sub CanEnterProduct { "LEFT JOIN group_control_map " . "ON group_control_map.product_id = products.id " . "AND group_control_map.entry != 0 "; - if (defined Bugzilla->user && %{Bugzilla->user->groups}) { + if (%{Bugzilla->user->groups}) { $query .= "AND group_id NOT IN(" . join(',', values(%{Bugzilla->user->groups})) . ") "; } @@ -547,7 +547,7 @@ sub GetSelectableProducts { $query .= "AND group_control_map.membercontrol = " . CONTROLMAPMANDATORY . " "; } - if (defined Bugzilla->user && %{Bugzilla->user->groups}) { + if (%{Bugzilla->user->groups}) { $query .= "AND group_id NOT IN(" . join(',', values(%{Bugzilla->user->groups})) . ") "; } @@ -1192,7 +1192,7 @@ sub UserInGroup { die "UserInGroup no longer takes a second parameter."; } - return defined Bugzilla->user && defined Bugzilla->user->groups->{$_[0]}; + return defined Bugzilla->user->groups->{$_[0]}; } sub UserCanBlessGroup { |