diff options
author | justdave%syndicomm.com <> | 2002-11-22 03:46:16 +0100 |
---|---|---|
committer | justdave%syndicomm.com <> | 2002-11-22 03:46:16 +0100 |
commit | 0615f228a0fec557e754c00935e8319cadf220a5 (patch) | |
tree | eaea259f4293f2385dffcffcae941e8d47b1a8c4 /process_bug.cgi | |
parent | 0d804e66f40ee8d9de11f7075428ebc1ef162c31 (diff) | |
download | bugzilla-0615f228a0fec557e754c00935e8319cadf220a5.tar.gz bugzilla-0615f228a0fec557e754c00935e8319cadf220a5.tar.xz |
Backing out the checkin for bug 180966 (fix warnings in web server error log). This checkin caused commenting on bugs to fail
if timetracking is not enabled.
Diffstat (limited to 'process_bug.cgi')
-rwxr-xr-x | process_bug.cgi | 33 |
1 files changed, 15 insertions, 18 deletions
diff --git a/process_bug.cgi b/process_bug.cgi index 40c9c2a08..531706582 100755 --- a/process_bug.cgi +++ b/process_bug.cgi @@ -109,8 +109,6 @@ if (defined $::FORM{'dup_id'} && $::FORM{'knob'} eq "duplicate") { ValidateComment($::FORM{'comment'}); -$::FORM{'dontchange'} = '' unless exists $::FORM{'dontchange'}; - # If the bug(s) being modified have dependencies, validate them # and rebuild the list with the validated values. This is important # because there are situations where validation changes the value @@ -1204,22 +1202,21 @@ foreach my $id (@idlist) { SendSQL("select now()"); $timestamp = FetchOneColumn(); - if (UserInGroup(Param('timetrackinggroup'))) { - if ($::FORM{'work_time'} > 99999.99) { - ThrowUserError("value_out_of_range", {field => 'work_time'}); - } - if (defined $::FORM{'comment'} || defined $::FORM{'work_time'}) { - if ($::FORM{'work_time'} != 0 && - (!defined $::FORM{'comment'} || $::FORM{'comment'} =~ /^\s*$/)) { - ThrowUserError('comment_required'); - } else { - AppendComment($id, $::COOKIE{'Bugzilla_login'}, $::FORM{'comment'}, - $::FORM{'commentprivacy'}, $timestamp, $::FORM{'work_time'}); - if ($::FORM{'work_time'} != 0) { - LogActivityEntry($id, "work_time", "", $::FORM{'work_time'}, - $whoid, $timestamp); - $bug_changed = 1; - } + if ($::FORM{'work_time'} > 99999.99) { + ThrowUserError("value_out_of_range", {field => 'work_time'}); + } + if (defined $::FORM{'comment'} || defined $::FORM{'work_time'}) { + if ($::FORM{'work_time'} != 0 && + (!defined $::FORM{'comment'} || $::FORM{'comment'} =~ /^\s*$/)) { + + ThrowUserError('comment_required'); + } else { + AppendComment($id, $::COOKIE{'Bugzilla_login'}, $::FORM{'comment'}, + $::FORM{'commentprivacy'}, $timestamp, $::FORM{'work_time'}); + if ($::FORM{'work_time'} != 0) { + LogActivityEntry($id, "work_time", "", $::FORM{'work_time'}, + $whoid, $timestamp); + $bug_changed = 1; } } } |