diff options
author | bbaetz%student.usyd.edu.au <> | 2002-11-20 09:53:10 +0100 |
---|---|---|
committer | bbaetz%student.usyd.edu.au <> | 2002-11-20 09:53:10 +0100 |
commit | 1554eaf8592e53ccea48adc1f96938f60d27ab9e (patch) | |
tree | 5da17d986626cd41bd7a45e48517b3e41c8b66b6 /process_bug.cgi | |
parent | c42a344256b6f57a156a63be6de31d47a6a23c49 (diff) | |
download | bugzilla-1554eaf8592e53ccea48adc1f96938f60d27ab9e.tar.gz bugzilla-1554eaf8592e53ccea48adc1f96938f60d27ab9e.tar.xz |
Bug 180966 - fix misc warnings
r,a=myk
Diffstat (limited to 'process_bug.cgi')
-rwxr-xr-x | process_bug.cgi | 33 |
1 files changed, 18 insertions, 15 deletions
diff --git a/process_bug.cgi b/process_bug.cgi index 531706582..40c9c2a08 100755 --- a/process_bug.cgi +++ b/process_bug.cgi @@ -109,6 +109,8 @@ if (defined $::FORM{'dup_id'} && $::FORM{'knob'} eq "duplicate") { ValidateComment($::FORM{'comment'}); +$::FORM{'dontchange'} = '' unless exists $::FORM{'dontchange'}; + # If the bug(s) being modified have dependencies, validate them # and rebuild the list with the validated values. This is important # because there are situations where validation changes the value @@ -1202,21 +1204,22 @@ foreach my $id (@idlist) { SendSQL("select now()"); $timestamp = FetchOneColumn(); - if ($::FORM{'work_time'} > 99999.99) { - ThrowUserError("value_out_of_range", {field => 'work_time'}); - } - if (defined $::FORM{'comment'} || defined $::FORM{'work_time'}) { - if ($::FORM{'work_time'} != 0 && - (!defined $::FORM{'comment'} || $::FORM{'comment'} =~ /^\s*$/)) { - - ThrowUserError('comment_required'); - } else { - AppendComment($id, $::COOKIE{'Bugzilla_login'}, $::FORM{'comment'}, - $::FORM{'commentprivacy'}, $timestamp, $::FORM{'work_time'}); - if ($::FORM{'work_time'} != 0) { - LogActivityEntry($id, "work_time", "", $::FORM{'work_time'}, - $whoid, $timestamp); - $bug_changed = 1; + if (UserInGroup(Param('timetrackinggroup'))) { + if ($::FORM{'work_time'} > 99999.99) { + ThrowUserError("value_out_of_range", {field => 'work_time'}); + } + if (defined $::FORM{'comment'} || defined $::FORM{'work_time'}) { + if ($::FORM{'work_time'} != 0 && + (!defined $::FORM{'comment'} || $::FORM{'comment'} =~ /^\s*$/)) { + ThrowUserError('comment_required'); + } else { + AppendComment($id, $::COOKIE{'Bugzilla_login'}, $::FORM{'comment'}, + $::FORM{'commentprivacy'}, $timestamp, $::FORM{'work_time'}); + if ($::FORM{'work_time'} != 0) { + LogActivityEntry($id, "work_time", "", $::FORM{'work_time'}, + $whoid, $timestamp); + $bug_changed = 1; + } } } } |