Added a new table fielddefs that records information about the

different fields we keep an activity log on.  The bugs_activity table
now has a pointer into that table instead of recording the name directly.

Set up a new, highly experimental email-notification scheme.  To turn
it on, the maintainer has to turn on the "New email tech" param, and
then individual users have to turn on the "New email tech" preference.

1 files changed, 14 insertions, 2 deletions

diff --git a/sanitycheck.cgi b/sanitycheck.cgi
index 08fbbfb8f..b67dad69e 100755
--- a/sanitycheck.cgi
+++ b/sanitycheck.cgi
@@ -336,18 +336,30 @@ while (@row = FetchSQLData()) {
 
 Status("Checking activity table");
 
-SendSQL("select bug_id,who from bugs_activity");
+SendSQL("select bug_id,who,fieldid from bugs_activity");
+
+my @fieldids;
 
 while (@row = FetchSQLData()) {
-    my ($id, $who) = (@row);
+    my ($id, $who, $f) = (@row);
     if (!defined $bugid{$id}) {
         Alert("Bad bugid " . BugLink($id));
     }
     if (!defined $profid{$who}) {
         Alert("Bad who $who in " . BugLink($id));
     }
+    $fieldids[$f] = 1;
 }
 
+for (my $f = 0 ; $f < @fieldids ; $f++) {
+    if ($fieldids[$f]) {
+        SendSQL("SELECT name FROM fielddefs WHERE fieldid = $f");
+        my $name = FetchOneColumn();
+        if (!$name) {
+            Alert("Bad fieldid $f in bugs_activity");
+        }
+    }
+}
 
 Status("Checking dependency table");