diff options
author | Perl Tidy <perltidy@bugzilla.org> | 2018-12-05 21:38:52 +0100 |
---|---|---|
committer | Dylan William Hardison <dylan@hardison.net> | 2018-12-05 23:49:08 +0100 |
commit | 8ec8da0491ad89604700b3e29a227966f6d84ba1 (patch) | |
tree | 9d270f173330ca19700e0ba9f2ee931300646de1 /scripts/fix_all_open_status_queries.pl | |
parent | a7bb5a65b71644d9efce5fed783ed545b9336548 (diff) | |
download | bugzilla-8ec8da0491ad89604700b3e29a227966f6d84ba1.tar.gz bugzilla-8ec8da0491ad89604700b3e29a227966f6d84ba1.tar.xz |
no bug - reformat all the code using the new perltidy rules
Diffstat (limited to 'scripts/fix_all_open_status_queries.pl')
-rwxr-xr-x | scripts/fix_all_open_status_queries.pl | 121 |
1 files changed, 61 insertions, 60 deletions
diff --git a/scripts/fix_all_open_status_queries.pl b/scripts/fix_all_open_status_queries.pl index 1ba7c66c6..51f453fc4 100755 --- a/scripts/fix_all_open_status_queries.pl +++ b/scripts/fix_all_open_status_queries.pl @@ -30,87 +30,88 @@ USAGE } sub do_namedqueries { - my ($new_status) = @_; - my $dbh = Bugzilla->dbh; - my $replace_count = 0; + my ($new_status) = @_; + my $dbh = Bugzilla->dbh; + my $replace_count = 0; - my $query = $dbh->selectall_arrayref("SELECT id, query FROM namedqueries"); + my $query = $dbh->selectall_arrayref("SELECT id, query FROM namedqueries"); - if ($query) { - $dbh->bz_start_transaction(); + if ($query) { + $dbh->bz_start_transaction(); - my $sth = $dbh->prepare("UPDATE namedqueries SET query = ? WHERE id = ?"); + my $sth = $dbh->prepare("UPDATE namedqueries SET query = ? WHERE id = ?"); - foreach my $row (@$query) { - my ($id, $old_query) = @$row; - my $new_query = all_open_states($new_status, $old_query); - if ($new_query) { - trick_taint($new_query); - $sth->execute($new_query, $id); - $replace_count++; - } - } - - $dbh->bz_commit_transaction(); + foreach my $row (@$query) { + my ($id, $old_query) = @$row; + my $new_query = all_open_states($new_status, $old_query); + if ($new_query) { + trick_taint($new_query); + $sth->execute($new_query, $id); + $replace_count++; + } } - print "namedqueries: $replace_count replacements made.\n"; + $dbh->bz_commit_transaction(); + } + + print "namedqueries: $replace_count replacements made.\n"; } # series sub do_series { - my ($new_status) = @_; - my $dbh = Bugzilla->dbh; - my $replace_count = 0; - - my $query = $dbh->selectall_arrayref("SELECT series_id, query FROM series"); + my ($new_status) = @_; + my $dbh = Bugzilla->dbh; + my $replace_count = 0; - if ($query) { - $dbh->bz_start_transaction(); + my $query = $dbh->selectall_arrayref("SELECT series_id, query FROM series"); - my $sth = $dbh->prepare("UPDATE series SET query = ? WHERE series_id = ?"); + if ($query) { + $dbh->bz_start_transaction(); - foreach my $row (@$query) { - my ($series_id, $old_query) = @$row; - my $new_query = all_open_states($new_status, $old_query); - if ($new_query) { - trick_taint($new_query); - $sth->execute($new_query, $series_id); - $replace_count++; - } - } + my $sth = $dbh->prepare("UPDATE series SET query = ? WHERE series_id = ?"); - $dbh->bz_commit_transaction(); + foreach my $row (@$query) { + my ($series_id, $old_query) = @$row; + my $new_query = all_open_states($new_status, $old_query); + if ($new_query) { + trick_taint($new_query); + $sth->execute($new_query, $series_id); + $replace_count++; + } } - print "series: $replace_count replacements made.\n"; + $dbh->bz_commit_transaction(); + } + + print "series: $replace_count replacements made.\n"; } sub all_open_states { - my ($new_status, $query) = @_; + my ($new_status, $query) = @_; - my @open_states = Bugzilla::Status::BUG_STATE_OPEN(); - my $cgi = Bugzilla::CGI->new($query); - my @query_states = $cgi->param('bug_status'); + my @open_states = Bugzilla::Status::BUG_STATE_OPEN(); + my $cgi = Bugzilla::CGI->new($query); + my @query_states = $cgi->param('bug_status'); - my ($removed, $added) = diff_arrays(\@query_states, \@open_states); + my ($removed, $added) = diff_arrays(\@query_states, \@open_states); - if (scalar @$added == 1 && $added->[0] eq $new_status) { - push(@query_states, $new_status); - $cgi->param('bug_status', @query_states); - return $cgi->canonicalise_query(); - } + if (scalar @$added == 1 && $added->[0] eq $new_status) { + push(@query_states, $new_status); + $cgi->param('bug_status', @query_states); + return $cgi->canonicalise_query(); + } - return ''; + return ''; } sub validate_status { - my ($status) = @_; - my $dbh = Bugzilla->dbh; - my $exists = $dbh->selectrow_array("SELECT 1 FROM bug_status - WHERE value = ?", - undef, $status); - return $exists ? 1 : 0; + my ($status) = @_; + my $dbh = Bugzilla->dbh; + my $exists = $dbh->selectrow_array( + "SELECT 1 FROM bug_status + WHERE value = ?", undef, $status + ); + return $exists ? 1 : 0; } ############################################################################# @@ -120,8 +121,8 @@ sub validate_status { Bugzilla->usage_mode(USAGE_MODE_CMDLINE); if (scalar @ARGV < 1) { - usage(); - exit(1); + usage(); + exit(1); } my ($new_status) = @ARGV; @@ -129,9 +130,9 @@ my ($new_status) = @ARGV; $new_status = uc($new_status); if (!validate_status($new_status)) { - print "Invalid status: $new_status\n\n"; - usage(); - exit(1); + print "Invalid status: $new_status\n\n"; + usage(); + exit(1); } print "Adding new status '$new_status'.\n\n"; |