diff options
author | Byron Jones <bjones@mozilla.com> | 2013-03-28 07:10:24 +0100 |
---|---|---|
committer | Byron Jones <bjones@mozilla.com> | 2013-03-28 07:10:24 +0100 |
commit | e4a5c4996044c0de0f889aa3687ddfc89fa00be7 (patch) | |
tree | c538eb805a4987b3217122f14550a87d2736abe6 /showdependencygraph.cgi | |
parent | f558420feebedfcead5abdcd2ecc9e37ce4be748 (diff) | |
download | bugzilla-e4a5c4996044c0de0f889aa3687ddfc89fa00be7.tar.gz bugzilla-e4a5c4996044c0de0f889aa3687ddfc89fa00be7.tar.xz |
Bug 850639: the dependency graph should have an upper limit on the number of nodes it attempts to graph
Diffstat (limited to 'showdependencygraph.cgi')
-rwxr-xr-x | showdependencygraph.cgi | 12 |
1 files changed, 9 insertions, 3 deletions
diff --git a/showdependencygraph.cgi b/showdependencygraph.cgi index 842b4c092..0b9825b91 100755 --- a/showdependencygraph.cgi +++ b/showdependencygraph.cgi @@ -44,7 +44,7 @@ my $vars = {}; # performance. my $dbh = Bugzilla->switch_to_shadow_db(); -local our (%seen, %edgesdone, %bugtitles); +our (%seen, %edgesdone, %bugtitles, $bug_count); # CreateImagemap: This sub grabs a local filename as a parameter, reads the # dot-generated image map datafile residing in that file and turns it into @@ -91,6 +91,7 @@ sub AddLink { if (!exists $edgesdone{$key}) { $edgesdone{$key} = 1; print $fh "$dependson -> $blocked\n"; + $bug_count++; $seen{$blocked} = 1; $seen{$dependson} = 1; } @@ -123,10 +124,10 @@ chmod Bugzilla::Install::Filesystem::CGI_WRITE, $filename my $urlbase = Bugzilla->params->{'urlbase'}; print $fh "digraph G {"; -print $fh qq{ +print $fh qq( graph [URL="${urlbase}query.cgi", rankdir=$rankdir] node [URL="${urlbase}show_bug.cgi?id=\\N", style=filled, color=lightgrey] -}; +); my %baselist; @@ -236,6 +237,11 @@ foreach my $k (keys(%seen)) { print $fh "}\n"; close $fh; +if ($bug_count > MAX_WEBDOT_BUGS) { + unlink($filename); + ThrowUserError("webdot_too_large"); +} + my $webdotbase = Bugzilla->params->{'webdotbase'}; if ($webdotbase =~ /^https?:/) { |