Bug 920681: Remove the cellspacing and cellpadding attributes from tables

r/a=justdave

8 files changed, 232 insertions, 86 deletions

diff --git a/skins/standard/admin.css b/skins/standard/admin.css
index d0aaf368f..b5f36b654 100644
--- a/skins/standard/admin.css
+++ b/skins/standard/admin.css
@@ -6,14 +6,9 @@
  * defined by the Mozilla Public License, v. 2.0.
  */
 
-.column_header {
-    background-color: #66f;
-}
-
 .warningmessages, .criticalmessages {
     background-color: white;
-    border-style: solid;
-    border-width: 1px;
+    border: 1px solid;
     padding: 1ex 1ex 1ex 4ex;
     margin: 1ex;
 }
@@ -43,20 +38,30 @@ p.areyoureallyreallysure {
     font-weight: bold;
 }
 
-#admin_table {
+#admin_table, #flag_types_bugs, #flag_types_attachments {
     border-collapse: collapse;
     border: 1px solid black;
 }
 
-#admin_table th {
+#admin_table th, #flag_types_bugs th, #flag_types_attachments th {
     white-space: normal !important;
 }
 
-#admin_table th, #admin_table td {
+#admin_table th, #admin_table td,
+#flag_types_bugs th , #flag_types_bugs td,
+#flag_types_attachments th, #flag_types_attachments td {
     border: 1px solid black;
     padding: 0.3em;
 }
 
+table.no-border th, table.no-border td {
+    border: 0 !important;
+}
+
+table.no-border th {
+    text-align: left;
+}
+
 tr.disabled {
     background-color: lightgrey;
 }
@@ -131,20 +136,8 @@ th.title {
     vertical-align: middle;
 }
 
-#edit_custom_field tr {
-    vertical-align: top;
-}
-
-#edit_custom_field th {
-    text-align: right;
-}
-
-#edit_custom_field th.narrow_label {
-    white-space: normal;
-}
-
-#flag_types_bugs tr th, #flag_types_attachments tr th {
-    text-align: left;
+td.max-width {
+    width: 100%;
 }
 
 #flag_types_bugs .inactive, #flag_types_attachments .inactive {
@@ -155,13 +148,27 @@ th.title {
     display: block;
 }
 
-table.whining_list {
+#flagtype_form div.inline {
+    white-space: nowrap;
+}
+
+#flagtype_form label, #grant_table label {
+    font-weight:bold;
+}
+
+table.whining_list, #group_settings_desc {
     border: 1px solid black;
     border-collapse: collapse;
     width: 100%;
 }
 
-table.whining_list th, table.whining_list td {
+#group_settings_desc th, #group_settings_desc td {
+    border: 1px solid black;
+    padding: 0.3em;
+}
+
+table.whining_list th, table.whining_list td,
+#admin_table_edit th, #admin_table_edit td {
     padding: 0.3em;
 }
 
@@ -180,3 +187,28 @@ table.schedule_list th, table.search_list th {
     text-align: center;
     font-weight: bold !important;
 }
+
+#settings #update {
+    margin-top: 2em;
+}
+
+#grant_table td, #grant_table th {
+    text-align: center;
+    padding: 0.5em;
+}
+
+#grant_table th {
+    padding: 2em 3em 0.5em 3em;
+}
+
+#grant_table tr:first-child th {
+    padding-top: 0.5em;
+}
+
+#mass-remove {
+    max-width: 50%;
+}
+
+#mass-remove legend {
+    white-space: nowrap;
+}
diff --git a/skins/standard/attachment.css b/skins/standard/attachment.css
index 3c596623c..c765aa5a9 100644
--- a/skins/standard/attachment.css
+++ b/skins/standard/attachment.css
@@ -108,10 +108,7 @@ table.attachment_info td {
     padding-bottom: 0.4em;
 }
 
-#attachment_attributes label,
-#attachment_attributes span.label,
-#attachment_actions span.label
-{
+#attachment_attributes label {
     font-weight: bold;
 }
 
diff --git a/skins/standard/buglist.css b/skins/standard/buglist.css
index 6d23fc8bb..75dafb9cf 100644
--- a/skins/standard/buglist.css
+++ b/skins/standard/buglist.css
@@ -63,7 +63,13 @@
 /* Align columns in the "change multiple bugs" form to the right. */
 table#form tr th { text-align: right; }
 
-table.bz_buglist td, table.bz_buglist th { 
+table.bz_buglist {
+  border-collapse: collapse;
+  width: 100%;
+}
+
+table.bz_buglist td, table.bz_buglist th {
+  padding: 0.4em;
 }
 
 /* we use a first-child class and not the pseudo-class because IE
@@ -76,7 +82,7 @@ tr.bz_secure td.first-child, a.bz_secure {
 }
 
 th.first-child, td.first-child, a.bz_secure {
-  padding-left: 20px;
+  padding-left: 20px !important;
 }
 
 tr.bz_secure_mode_implied td.first-child {
@@ -115,6 +121,26 @@ td.bz_total {
     color: inherit;
 }
 
+#groups_edit_multiple, #quips {
+    border: 1px solid black;
+    border-collapse: collapse;
+}
+
+#groups_edit_multiple th, #groups_edit_multiple td,
+#quips th, #quips td {
+    border: 1px solid;
+    padding: 0.3em;
+}
+
+#groups_edit_multiple th, #quips th {
+    text-align: center;
+    white-space: normal !important;
+}
+
+#groups_edit_multiple th.narrow_column {
+    width: 8em;
+}
+
 /* The "filtering" table is specific to request.cgi.
  * Same for the "requests" class used for tables. */
 
@@ -126,6 +152,17 @@ td.bz_total {
     text-align: right;
 }
 
+table.requests {
+    border: 1px solid black;
+    border-collapse: collapse;
+    width: 100%;
+}
+
+table.requests th, table.requests td {
+    border: 1px solid;
+    padding: 0.5em;
+}
+
 table.requests th {
     text-align: left;
 }
diff --git a/skins/standard/enter_bug.css b/skins/standard/enter_bug.css
index 2aa094626..983ec6f66 100644
--- a/skins/standard/enter_bug.css
+++ b/skins/standard/enter_bug.css
@@ -71,6 +71,10 @@ form#Create #possible_duplicates td { vertical-align: middle; }
     height: 500px;
 }
 
+#guided_form #description {
+    display: inline;
+}
+
 .good {
     color: #090;
 }
diff --git a/skins/standard/global.css b/skins/standard/global.css
index ecf39c6a8..d10fac026 100644
--- a/skins/standard/global.css
+++ b/skins/standard/global.css
@@ -12,7 +12,7 @@
         color: #000;
         background: #fff url("global/body-back.gif") repeat-x;
     }
-    body, td, th, input {
+    body, td, th, input, dt, #titles {
         font-family: Verdana, sans-serif;
         font-size: small;
     }
@@ -20,6 +20,11 @@
     pre, code, kbd {
         font-size: medium;
     }
+
+    #bugzilla-body {
+        clear: both;
+    }
+
 /* global (end) */
 
 /* header (begin) */
@@ -43,9 +48,14 @@
         padding: 0.5em;
     }
 
+    #common_links {
+        clear: both;
+    }
+
     #lang_links_container {
         float: right;
     }
+
     #lang_links_container .links {
         border: none;
         padding: .5em;
@@ -90,10 +100,9 @@
         color: #fff;
         border-top-left-radius: 5px;
         border-top-right-radius: 5px;
-        font-size: 110%;
         margin: 0;
-        padding: 0.5em;
         vertical-align: bottom;
+        display: table;
     }
 
     #titles a {
@@ -107,20 +116,25 @@
 
     #titles #title {
         font-weight: bold;
+        padding: 0.5em;
         white-space: nowrap;
+        display: table-cell;
     }
 
     #titles #subtitle {
         font-weight: normal;
-        width: 100%;
         text-align: center;
-    }
+        padding: 0.5em;
+        display: table-cell;
+   }
 
     #titles #information {
         font-weight: normal;
         text-align: right;
         font-size: 90%;
+        padding: 0.5em;
         white-space: nowrap;
+        display: table-cell;
     }
 
 /* titles (end) */
@@ -177,6 +191,14 @@
 /* link lists (end) */
 
 /* tabs (begin) */
+    table.tabs {
+        width: 100%;
+    }
+
+    .tabs th, .tabs td {
+        padding: 1em;
+    }
+
     .tabs td {
         background: #eee;
         text-align: center;
@@ -289,6 +311,12 @@ div#docslinks {
      width: 50em;
 }
 
+.bz_comment_text span.quote {
+    color: #65379c;
+    /* Make quoted text not wrap. */
+    white-space: pre;
+}
+
 .bz_comment_user, .bz_comment_time, .bz_comment_number, 
 .bz_private_checkbox, .bz_comment_actions
 {
@@ -342,23 +370,48 @@ div#docslinks {
     display: none !important;
 }
 
-.bz_comment_text span.quote {
-    color: #65379c;
-    /* Make quoted text not wrap. */
-    white-space: pre;
-}
-
 table#flags th,
 table#flags td {
     vertical-align: middle;
     text-align: left;
 }
 
-table#email_prefs th,
-table#shared_search_prefs th,
-table#saved_search_prefs th {
+#email_prefs, #saved_search_prefs, #shared_search_prefs,
+#bug_activity {
+    border: 1px solid black;
+    border-collapse: collapse;
+}
+
+#email_prefs th,
+#shared_search_prefs th,
+#saved_search_prefs th {
     text-align: center;
 }
+
+#email_prefs th, #email_prefs td,
+#shared_search_prefs th, #shared_search_prefs td,
+#saved_search_prefs th, #saved_search_prefs td,
+#bug_activity td {
+    border: 1px solid;
+    padding: 0.3em;
+}
+
+#bug_activity td {
+    vertical-align: top;
+}
+
+#user_prefs th, #user_prefs td {
+    padding: 0.5em;
+}
+
+.column_header {
+    background-color: #66f;
+}
+
+.column_header th {
+    text-align: center;
+}
+
 .flag_select {
     min-width: 3em;
 }
@@ -371,16 +424,25 @@ input.requestee {
     font-size: x-large;
 }
 
+#post_err_msg {
+    clear: both;
+}
+
 .warning {
   color: red;
 }
 
 .throw_error {
-    background-color: #ff0000;
+    background-color: red;
     color: black;
     font-size: 120%;
-    margin: 1em;
+    margin-bottom: 2em;
     padding: 0.5em 1em;
+    float: left;
+}
+
+.label {
+    font-weight: bold;
 }
 
 .throw_error a:visited {
@@ -419,6 +481,10 @@ dl dl > dt {
     border: 1px solid #333333;
 }
 
+#attachment_table th, #attachment_table td {
+    padding: 0.3em;
+}
+
 .bz_attach_extra_info, .bz_info {
     font-size: smaller;
 }
@@ -432,6 +498,16 @@ dl dl > dt {
     padding-left: 1em;
 }
 
+#user_match_table {
+    border-collapse: collapse;
+}
+
+#user_match_table td {
+    vertical-align: top;
+    border-bottom: 1px solid black;
+    padding: 1em 0.5em;
+}
+
 div.user_match {
     margin-bottom: 1em;
 }
@@ -610,3 +686,9 @@ tr.shared_search {
     background-color: #fff7cd;
     color: #000;
 }
+
+.multi-columns {
+    columns: 3;
+    -moz-columns: 3;
+    -webkit-columns: 3;
+}
diff --git a/skins/standard/params.css b/skins/standard/params.css
index 92bd6d0e1..428ace5ad 100644
--- a/skins/standard/params.css
+++ b/skins/standard/params.css
@@ -8,7 +8,6 @@
 
 #menu {
   width: 10em;
-  margin-top: 1em;
   margin-right: 0.5em;
   border: solid thin;
   border-spacing: 0px;
@@ -34,8 +33,13 @@
   padding: 0.2em 0.5em;
 }
 
-table td {
-  vertical-align: top;
+div.table {
+    display: inline-table;
+}
+
+div.cell {
+    display: table-cell;
+    vertical-align: top;
 }
 
 td.selected_section {
diff --git a/skins/standard/reports.css b/skins/standard/reports.css
index 4db7d2dac..7679e32fc 100644
--- a/skins/standard/reports.css
+++ b/skins/standard/reports.css
@@ -8,49 +8,17 @@
 
 /* describecomponents.cgi */
 
-#components_header_table {
-  margin-bottom: 1em;
-}
-
-.product_container {
-  width: 65%;
-}
-
-.product_name {
-  font-weight: bold;
-  font-size: 150%;
-  margin: 0;
-}
-
 .product_desc {
   /* This is padding instead of margin because it looks better 
    * with the scrollbar. */
   padding: 0 2em;
   font-style: italic;
-  max-height: 5em;
+  max-height: 8em;
   overflow: auto;
 }
 
-.instructions {
-  font-weight: bold;
-  font-size: 105%;
+.component_table th {
   padding-right: 1em;
-}
-
-.components_header {
-  margin: 0;
-  font-size: 140%;
-  font-weight: bold;
-}
-
-.component_table {
-  margin-top: -1em;
-  margin-left: 2em;
-}
-
-.component_table thead th {
-  padding-right: 1em;
-  vertical-align: bottom;
   text-align: left;
 }
 
@@ -62,7 +30,7 @@
 .component_table td.component_qa_contact
 {
   border: none;
-  padding-top: .5em;
+  padding-top: 0.5em;
 }
 
 .component_name {
@@ -74,7 +42,7 @@
 }
 
 .component_description {
-  padding-bottom: .5em;
+  padding-bottom: 0.5em;
   color: #333;
 }
 
@@ -98,6 +66,17 @@
   background-color: #cfffdf; /* light green */
 }
 
+#tabular_report {
+  border: 1px dotted black;
+  border-collapse: collapse;
+  text-align: center;
+}
+
+#tabular_report th, #tabular_report td {
+  border: 1px dotted;
+  padding: 0.2em;
+}
+
 #graphical_report {
   max-width: 100%;
   height: auto;
@@ -133,3 +112,4 @@
 #edit_charts input#action-sum, #edit_charts input#action-remove {
     width: 7em;
 }
+
diff --git a/skins/standard/summarize-time.css b/skins/standard/summarize-time.css
index c7ed96827..37b135b45 100644
--- a/skins/standard/summarize-time.css
+++ b/skins/standard/summarize-time.css
@@ -36,6 +36,16 @@ td.subtotal {
 .number .owner_header, .owner .bug_header { background: #ffffff }
 .number .owner_header2, .owner .bug_header2 { background: #EFEFEF }
 
+table.owner, table.number, table.zeroitems {
+  width: 90%;
+  border-collapse: collapse;
+}
+
+.owner th, .owner td, .number th, .number td,
+.zeroitems th, .zeroitems td {
+    padding: 0.2em;
+}
+
 .warning_swapped_data {
     border: 1px solid red;
     margin: 1em;