Bug 1402878 - Add some more sanity-type tests, including perl critic

1 files changed, 147 insertions, 0 deletions

diff --git a/t/.perlcritic-history b/t/.perlcritic-history
new file mode 100644
index 000000000..8d21a03b6
--- /dev/null
+++ b/t/.perlcritic-history
@@ -0,0 +1,147 @@
+$VAR1 = [
+          {
+            'Perl::Critic::Policy::ValuesAndExpressions::ProhibitNoisyQuotes' => 29,
+            'Perl::Critic::Policy::Modules::RequireFilenameMatchesPackage' => 0,
+            'Perl::Critic::Policy::ValuesAndExpressions::ProhibitLongChainsOfMethodCalls' => 0,
+            'Perl::Critic::Policy::BuiltinFunctions::ProhibitComplexMappings' => 0,
+            'Perl::Critic::Policy::ControlStructures::ProhibitLabelsWithSpecialBlockNames' => 0,
+            'Perl::Critic::Policy::CodeLayout::ProhibitTrailingWhitespace' => 0,
+            'Perl::Critic::Policy::Variables::ProhibitUnusedVariables' => 0,
+            'Perl::Critic::Policy::Documentation::RequirePackageMatchesPodName' => 0,
+            'Perl::Critic::Policy::BuiltinFunctions::ProhibitUniversalCan' => 0,
+            'Perl::Critic::Policy::InputOutput::ProhibitJoinedReadline' => 0,
+            'Perl::Critic::Policy::Variables::ProhibitReusedNames' => 7,
+            'Perl::Critic::Policy::BuiltinFunctions::ProhibitStringySplit' => 1,
+            'Perl::Critic::Policy::Subroutines::ProhibitNestedSubs' => 0,
+            'Perl::Critic::Policy::ControlStructures::ProhibitMutatingListFunctions' => 0,
+            'Perl::Critic::Policy::Variables::ProhibitPerl4PackageNames' => 0,
+            'Perl::Critic::Policy::ControlStructures::ProhibitYadaOperator' => 0,
+            'Perl::Critic::Policy::Freenode::Each' => 0,
+            'Perl::Critic::Policy::Modules::ProhibitConditionalUseStatements' => 0,
+            'Perl::Critic::Policy::Freenode::OpenArgs' => 2,
+            'Perl::Critic::Policy::TestingAndDebugging::RequireUseWarnings' => 0,
+            'Perl::Critic::Policy::Miscellanea::ProhibitTies' => 0,
+            'Perl::Critic::Policy::Modules::ProhibitEvilModules' => 0,
+            'Perl::Critic::Policy::Subroutines::ProhibitManyArgs' => 0,
+            'Perl::Critic::Policy::ValuesAndExpressions::ProhibitMixedBooleanOperators' => 0,
+            'Perl::Critic::Policy::Freenode::POSIXImports' => 0,
+            'Perl::Critic::Policy::Freenode::DollarAB' => 0,
+            'Perl::Critic::Policy::ValuesAndExpressions::RequireQuotedHeredocTerminator' => 29,
+            'Perl::Critic::Policy::InputOutput::ProhibitOneArgSelect' => 0,
+            'Perl::Critic::Policy::RegularExpressions::ProhibitSingleCharAlternation' => 16,
+            'Perl::Critic::Policy::Freenode::ModPerl' => 0,
+            'Perl::Critic::Policy::TestingAndDebugging::ProhibitNoWarnings' => 1,
+            'Perl::Critic::Policy::Freenode::IndirectObjectNotation' => 0,
+            'Perl::Critic::Policy::Subroutines::ProhibitAmpersandSigils' => 0,
+            'Perl::Critic::Policy::ControlStructures::ProhibitUnreachableCode' => 0,
+            'Perl::Critic::Policy::Subroutines::ProhibitSubroutinePrototypes' => 5,
+            'Perl::Critic::Policy::BuiltinFunctions::RequireBlockMap' => 0,
+            'Perl::Critic::Policy::ControlStructures::ProhibitNegativeExpressionsInUnlessAndUntilConditions' => 1,
+            'Perl::Critic::Policy::ErrorHandling::RequireCheckingReturnValueOfEval' => 3,
+            'Perl::Critic::Policy::InputOutput::ProhibitBacktickOperators' => 0,
+            'Perl::Critic::Policy::Variables::RequireLocalizedPunctuationVars' => 7,
+            'Perl::Critic::Policy::CodeLayout::RequireConsistentNewlines' => 0,
+            'Perl::Critic::Policy::Miscellanea::ProhibitUselessNoCritic' => 0,
+            'Perl::Critic::Policy::TestingAndDebugging::ProhibitNoStrict' => 1,
+            'Perl::Critic::Policy::BuiltinFunctions::ProhibitStringyEval' => 1,
+            'Perl::Critic::Policy::BuiltinFunctions::ProhibitUniversalIsa' => 0,
+            'Perl::Critic::Policy::CodeLayout::ProhibitQuotedWordLists' => 0,
+            'Perl::Critic::Policy::NamingConventions::ProhibitAmbiguousNames' => 0,
+            'Perl::Critic::Policy::Variables::ProhibitConditionalDeclarations' => 0,
+            'Perl::Critic::Policy::InputOutput::ProhibitExplicitStdin' => 1,
+            'Perl::Critic::Policy::ValuesAndExpressions::ProhibitInterpolationOfLiterals' => 272,
+            'Perl::Critic::Policy::Freenode::Wantarray' => 0,
+            'Perl::Critic::Policy::ValuesAndExpressions::ProhibitMismatchedOperators' => 0,
+            'Perl::Critic::Policy::InputOutput::RequireBracedFileHandleWithPrint' => 15,
+            'Perl::Critic::Policy::CodeLayout::RequireTidyCode' => 50,
+            'Perl::Critic::Policy::Subroutines::ProhibitBuiltinHomonyms' => 0,
+            'Perl::Critic::Policy::Modules::RequireExplicitPackage' => 0,
+            'Perl::Critic::Policy::CodeLayout::ProhibitHardTabs' => 0,
+            'Perl::Critic::Policy::BuiltinFunctions::ProhibitLvalueSubstr' => 0,
+            'Perl::Critic::Policy::Freenode::OverloadOptions' => 0,
+            'Perl::Critic::Policy::TestingAndDebugging::ProhibitProlongedStrictureOverride' => 0,
+            'Perl::Critic::Policy::ValuesAndExpressions::ProhibitLeadingZeros' => 0,
+            'Perl::Critic::Policy::CodeLayout::RequireTrailingCommas' => 3,
+            'Perl::Critic::Policy::Miscellanea::ProhibitUnrestrictedNoCritic' => 0,
+            'Perl::Critic::Policy::BuiltinFunctions::ProhibitSleepViaSelect' => 0,
+            'Perl::Critic::Policy::RegularExpressions::ProhibitEscapedMetacharacters' => 3,
+            'Perl::Critic::Policy::NamingConventions::Capitalization' => 0,
+            'Perl::Critic::Policy::Modules::RequireNoMatchVarsWithUseEnglish' => 1,
+            'Perl::Critic::Policy::RegularExpressions::RequireLineBoundaryMatching' => 37,
+            'Perl::Critic::Policy::InputOutput::RequireEncodingWithUTF8Layer' => 1,
+            'Perl::Critic::Policy::BuiltinFunctions::ProhibitVoidGrep' => 0,
+            'Perl::Critic::Policy::ValuesAndExpressions::RequireUpperCaseHeredocTerminator' => 0,
+            'Perl::Critic::Policy::Miscellanea::ProhibitFormats' => 0,
+            'Perl::Critic::Policy::Variables::RequireInitializationForLocalVars' => 0,
+            'Perl::Critic::Policy::CodeLayout::ProhibitParensWithBuiltins' => 83,
+            'Perl::Critic::Policy::RegularExpressions::ProhibitEnumeratedClasses' => 0,
+            'Perl::Critic::Policy::ValuesAndExpressions::ProhibitCommaSeparatedStatements' => 0,
+            'Perl::Critic::Policy::BuiltinFunctions::RequireBlockGrep' => 4,
+            'Perl::Critic::Policy::Freenode::AmpersandSubCalls' => 0,
+            'Perl::Critic::Policy::Modules::RequireEndWithOne' => 0,
+            'Perl::Critic::Policy::InputOutput::ProhibitTwoArgOpen' => 2,
+            'Perl::Critic::Policy::ValuesAndExpressions::RequireConstantVersion' => 0,
+            'Perl::Critic::Policy::InputOutput::RequireCheckedSyscalls' => 168,
+            'Perl::Critic::Policy::ValuesAndExpressions::RequireInterpolationOfMetachars' => 0,
+            'Perl::Critic::Policy::TestingAndDebugging::RequireUseStrict' => 0,
+            'Perl::Critic::Policy::ControlStructures::ProhibitUntilBlocks' => 0,
+            'Perl::Critic::Policy::Freenode::ArrayAssignAref' => 0,
+            'Perl::Critic::Policy::Freenode::ConditionalDeclarations' => 0,
+            'Perl::Critic::Policy::Objects::ProhibitIndirectSyntax' => 22,
+            'Perl::Critic::Policy::BuiltinFunctions::RequireGlobFunction' => 0,
+            'Perl::Critic::Policy::TestingAndDebugging::RequireTestLabels' => 0,
+            'Perl::Critic::Policy::ClassHierarchies::ProhibitExplicitISA' => 0,
+            'Perl::Critic::Policy::Modules::ProhibitExcessMainComplexity' => 6,
+            'Perl::Critic::Policy::ValuesAndExpressions::ProhibitEscapedCharacters' => 1,
+            'Perl::Critic::Policy::Freenode::WarningsSwitch' => 19,
+            'Perl::Critic::Policy::RegularExpressions::ProhibitCaptureWithoutTest' => 0,
+            'Perl::Critic::Policy::Variables::ProhibitPunctuationVars' => 14,
+            'Perl::Critic::Policy::RegularExpressions::ProhibitFixedStringMatches' => 2,
+            'Perl::Critic::Policy::ClassHierarchies::ProhibitOneArgBless' => 0,
+            'Perl::Critic::Policy::BuiltinFunctions::RequireSimpleSortBlock' => 0,
+            'Perl::Critic::Policy::InputOutput::RequireCheckedOpen' => 0,
+            'Perl::Critic::Policy::RegularExpressions::ProhibitUnusualDelimiters' => 1,
+            'Perl::Critic::Policy::RegularExpressions::ProhibitUselessTopic' => 0,
+            'Perl::Critic::Policy::Variables::ProhibitAugmentedAssignmentInDeclaration' => 1,
+            'Perl::Critic::Policy::ValuesAndExpressions::RequireNumberSeparators' => 1,
+            'Perl::Critic::Policy::Freenode::DiscouragedModules' => 5,
+            'Perl::Critic::Policy::Subroutines::ProtectPrivateSubs' => 1,
+            'Perl::Critic::Policy::ValuesAndExpressions::ProhibitComplexVersion' => 0,
+            'Perl::Critic::Policy::ValuesAndExpressions::ProhibitSpecialLiteralHeredocTerminator' => 0,
+            'Perl::Critic::Policy::Modules::ProhibitMultiplePackages' => 0,
+            'Perl::Critic::Policy::Variables::ProhibitMatchVars' => 0,
+            'Perl::Critic::Policy::Variables::RequireLexicalLoopIterators' => 0,
+            'Perl::Critic::Policy::BuiltinFunctions::ProhibitVoidMap' => 0,
+            'Perl::Critic::Policy::ValuesAndExpressions::ProhibitImplicitNewlines' => 55,
+            'Perl::Critic::Policy::Modules::RequireBarewordIncludes' => 0,
+            'Perl::Critic::Policy::InputOutput::ProhibitBarewordFileHandles' => 2,
+            'Perl::Critic::Policy::InputOutput::RequireCheckedClose' => 1,
+            'Perl::Critic::Policy::ControlStructures::ProhibitDeepNests' => 0,
+            'Perl::Critic::Policy::ControlStructures::ProhibitCStyleForLoops' => 2,
+            'Perl::Critic::Policy::InputOutput::ProhibitReadlineInForLoop' => 0,
+            'Perl::Critic::Policy::Freenode::WhileDiamondDefaultAssignment' => 0,
+            'Perl::Critic::Policy::RegularExpressions::ProhibitUnusedCapture' => 0,
+            'Perl::Critic::Policy::InputOutput::ProhibitInteractiveTest' => 1,
+            'Perl::Critic::Policy::Modules::ProhibitAutomaticExportation' => 0,
+            'Perl::Critic::Policy::RegularExpressions::RequireDotMatchAnything' => 38,
+            'Perl::Critic::Policy::Subroutines::RequireArgUnpacking' => 2,
+            'Perl::Critic::Policy::RegularExpressions::RequireBracesForMultiline' => 0,
+            'Perl::Critic::Policy::Subroutines::ProhibitUnusedPrivateSubroutines' => 0,
+            'Perl::Critic::Policy::Documentation::RequirePodAtEnd' => 4,
+            'Perl::Critic::Policy::Freenode::StrictWarnings' => 0,
+            'Perl::Critic::Policy::Variables::ProtectPrivateVars' => 0,
+            'Perl::Critic::Policy::Freenode::DeprecatedFeatures' => 0,
+            'Perl::Critic::Policy::BuiltinFunctions::ProhibitBooleanGrep' => 6,
+            'Perl::Critic::Policy::Freenode::Prototypes' => 5,
+            'Perl::Critic::Policy::Freenode::ConditionalImplicitReturn' => 0,
+            'Perl::Critic::Policy::BuiltinFunctions::ProhibitReverseSortBlock' => 0,
+            'Perl::Critic::Policy::Freenode::EmptyReturn' => 0,
+            'Perl::Critic::Policy::ClassHierarchies::ProhibitAutoloading' => 0,
+            'Perl::Critic::Policy::Freenode::Threads' => 0,
+            'Perl::Critic::Policy::Freenode::BarewordFilehandles' => 2,
+            'Perl::Critic::Policy::Subroutines::ProhibitReturnSort' => 0,
+            'Perl::Critic::Policy::ValuesAndExpressions::ProhibitQuotesAsQuotelikeOperatorDelimiters' => 0,
+            'Perl::Critic::Policy::Variables::RequireNegativeIndices' => 0,
+            'Perl::Critic::Policy::InputOutput::RequireBriefOpen' => 4
+          }
+        ];