Bug 920681: Remove the cellspacing and cellpadding attributes from tables

r/a=justdave

3 files changed, 28 insertions, 59 deletions

diff --git a/template/en/default/account/prefs/email.html.tmpl b/template/en/default/account/prefs/email.html.tmpl
index 9a5f22a8c..a085058c7 100644
--- a/template/en/default/account/prefs/email.html.tmpl
+++ b/template/en/default/account/prefs/email.html.tmpl
@@ -172,7 +172,7 @@ document.write('<input type="button" value="Disable All Mail" onclick="SetCheckb
 
 [% num_columns = relationships.size %]
 
-<table class="bz_emailprefs" id="email_prefs" border="1">
+<table id="email_prefs">
   <tr>
     <td colspan="[% num_columns FILTER html %]" align="center" width="50%">
       <b>When my relationship to this [% terms.bug %] is:</b>
diff --git a/template/en/default/account/prefs/saved-searches.html.tmpl b/template/en/default/account/prefs/saved-searches.html.tmpl
index 86df1e277..33df92255 100644
--- a/template/en/default/account/prefs/saved-searches.html.tmpl
+++ b/template/en/default/account/prefs/saved-searches.html.tmpl
@@ -31,57 +31,38 @@
 <p>Your saved searches are as follows:</p>
 
 <blockquote>
-  <table id="saved_search_prefs" border="1" cellpadding="3">
-    <tr>
-      <th>
-        Search
-      </th>
-      <th>
-        Run
-      </th>
-      <th>
-        Edit
-      </th>
-      <th>
-        Forget
-      </th>
-      <th>
-        Show in
-        Footer
-      </th>
+  <table id="saved_search_prefs">
+    <tr class="column_header">
+      <th>Search</th>
+      <th>Run</th>
+      <th>Edit</th>
+      <th>Forget</th>
+      <th>Show in Footer</th>
       [% may_share = user.in_group(Param('querysharegroup')) && queryshare_groups.size %]
       [% IF may_share %]
-        <th>
-          Share With a Group
-        </th>
+        <th>Share With a Group</th>
       [% END %]
       [% Hook.process('saved-header') %]
     </tr>
+
     <tr>
       <td>My [% terms.Bugs %]</td>
       <td>
         [% filtered_username = user.login FILTER uri %]
         <a href="[% Param('mybugstemplate').replace('%userid%', filtered_username) %]">Run</a>
       </td>
-      <td>
-        &nbsp;
-      </td>
-      <td>
-        &nbsp;
-      </td>
+      <td></td>
+      <td></td>
       <td align="center">
-        <input type="checkbox" 
-               name="showmybugslink"
-               value="1"
-               [% " checked" IF user.showmybugslink %]>
+        <input type="checkbox" name="showmybugslink" value="1"
+               [%+ 'checked="checked"' IF user.showmybugslink %]>
       </td>
       [% IF may_share %]
-        <td>
-          &mdash;
-        </td>
+        <td>&mdash;</td>
       [% END %]
       [% Hook.process('saved-row') %]
     </tr>
+
     [% FOREACH q = user.queries %]
       <tr [% 'class="shared_search"' IF q.shared_with_group.id %]>
         <td>[% q.name FILTER html %]</td>
@@ -102,7 +83,7 @@
                      [% issue_hash_token([q.id, q.name]) FILTER uri %]">Forget</a>
           [% END %]
         </td>
-        <td align="center">
+        <td class="center">
           <input type="checkbox" 
                  name="link_in_footer_[% q.id FILTER html %]"
                  value="1"
@@ -149,28 +130,16 @@
 [% IF user.queries_available.size %]
   <p>You may use these searches saved and shared by others:</p>
 
-  <table id="shared_search_prefs" border="1" cellpadding="3">
-    <tr>
-      <th>
-        Search
-      </th>
-      <th>
-        Shared By
-      </th>
-      <th>
-        Shared To
-      </th>
-      <th>
-        Run
-      </th>
-      <th>
-        Edit
-      </th>
-      <th>
-        Show in
-        Footer
-      </th>
+  <table id="shared_search_prefs">
+    <tr class="column_header">
+      <th>Search</th>
+      <th>Shared By</th>
+      <th>Shared To</th>
+      <th>Run</th>
+      <th>Edit</th>
+      <th>Show in Footer</th>
     </tr>
+
     [% FOREACH q = user.queries_available %]
       <tr>
         <td>[% q.name FILTER html %]</td>
@@ -185,7 +154,7 @@
           <a href="query.cgi?[% q.edit_link FILTER html %]&amp;known_name=
                    [% q.name FILTER uri %]">Edit</a>
         </td>
-        <td align="center">
+        <td class="center">
           <input type="checkbox" 
                  name="link_in_footer_[% q.id FILTER html %]"
                  value="1"
diff --git a/template/en/default/account/prefs/settings.html.tmpl b/template/en/default/account/prefs/settings.html.tmpl
index 580795835..d54441ddb 100644
--- a/template/en/default/account/prefs/settings.html.tmpl
+++ b/template/en/default/account/prefs/settings.html.tmpl
@@ -29,7 +29,7 @@
     </p>
   [% END %]
 
-  <table border="0" cellpadding="8">
+  <table id="user_prefs">
     [% FOREACH name = setting_names %]
       [% default_name = name _ '-isdefault' %]
       [% default_val = settings.${name}.default_value %]