Bug 920681: Remove the cellspacing and cellpadding attributes from tables

r/a=justdave

5 files changed, 71 insertions, 58 deletions

diff --git a/template/en/default/admin/classifications/add.html.tmpl b/template/en/default/admin/classifications/add.html.tmpl
index d818d3166..d56275aa2 100644
--- a/template/en/default/admin/classifications/add.html.tmpl
+++ b/template/en/default/admin/classifications/add.html.tmpl
@@ -8,10 +8,11 @@
 
 [% PROCESS global/header.html.tmpl
   title = "Add new classification"
+  style_urls = ['skins/standard/admin.css']
 %]
 
 <form method=post action="editclassifications.cgi">
-  <table border=0 cellpadding=4 cellspacing=0>
+  <table id="admin_table_edit">
 
     [% PROCESS "admin/classifications/edit-common.html.tmpl" %]
 
diff --git a/template/en/default/admin/classifications/del.html.tmpl b/template/en/default/admin/classifications/del.html.tmpl
index f99d29632..24a39b4b6 100644
--- a/template/en/default/admin/classifications/del.html.tmpl
+++ b/template/en/default/admin/classifications/del.html.tmpl
@@ -11,30 +11,29 @@
   style_urls = ['skins/standard/admin.css']
 %]
 
-<table border=1 cellpadding=4 cellspacing=0>
-<tr class="column_header">
-  <th valign="top" class="left">Part</th>
-  <th valign="top" class="left">Value</th>
-
-</tr><tr>
-  <td valign="top">Classification:</td>
-  <td valign="top">[% classification.name FILTER html %]</td>
-
-</tr><tr>
-  <td valign="top">Description:</td>
-  <td valign="top">
-    [% IF classification.description %]
-      [% classification.description FILTER html_light %]
-    [% ELSE %]
-      <span class="warning">description missing</span>
-    [% END %]
-  </td>
-
-</tr><tr>
-  <td valign="top">Sortkey:</td>
-  <td valign="top">[% classification.sortkey FILTER html %]</td>
-
-</tr>
+<table id="admin_table">
+  <tr class="column_header">
+    <th>Field</th>
+    <th>Value</th>
+  </tr>
+  <tr>
+    <td>Classification</td>
+    <td>[% classification.name FILTER html %]</td>
+  </tr>
+  <tr>
+    <td>Description</td>
+    <td>
+      [% IF classification.description %]
+        [% classification.description FILTER html_light %]
+      [% ELSE %]
+        <span class="warning">description missing</span>
+      [% END %]
+    </td>
+  </tr>
+  <tr>
+    <td>Sortkey</td>
+    <td>[% classification.sortkey FILTER html %]</td>
+  </tr>
 </table>
 
 <h2>Confirmation</h2>
diff --git a/template/en/default/admin/classifications/edit.html.tmpl b/template/en/default/admin/classifications/edit.html.tmpl
index 68fd046f2..b1f6ce225 100644
--- a/template/en/default/admin/classifications/edit.html.tmpl
+++ b/template/en/default/admin/classifications/edit.html.tmpl
@@ -8,14 +8,15 @@
 
 [% PROCESS global/header.html.tmpl
   title = "Edit classification"
+  style_urls = ['skins/standard/admin.css']
 %]
 
 <form method=post action="editclassifications.cgi">
-  <table  border=0 cellpadding=4 cellspacing=0>
+  <table id="admin_table_edit">
 
     [% PROCESS "admin/classifications/edit-common.html.tmpl" %]
 
-    <tr valign=top>
+    <tr>
       <th>
         <a href="editproducts.cgi?classification=[% classification.name FILTER uri %]">
         Edit Products</a>:
@@ -25,8 +26,8 @@
           <table>
             [% FOREACH product = classification.products %]
               <tr>
-                <th valign=top>[% product.name FILTER html %]</th>
-                <td valign=top>[% product.description FILTER html_light %]</td>
+                <th>[% product.name FILTER html %]</th>
+                <td>[% product.description FILTER html_light %]</td>
               </tr>
             [% END %]
           </table>
diff --git a/template/en/default/admin/classifications/reclassify.html.tmpl b/template/en/default/admin/classifications/reclassify.html.tmpl
index ac4a09b14..b230d670c 100644
--- a/template/en/default/admin/classifications/reclassify.html.tmpl
+++ b/template/en/default/admin/classifications/reclassify.html.tmpl
@@ -8,38 +8,39 @@
 
 [% PROCESS global/header.html.tmpl
   title = "Reclassify products"
+  style_urls = ['skins/standard/admin.css']
 %]
 
 <form method=post action="editclassifications.cgi">
-  <table border=0 cellpadding=4 cellspacing=0>
+  <table id="admin_table_edit">
     <tr>
       <th>Classification:</th>
-      <td valign="top" colspan=3>[% classification.name FILTER html %]</td>
-
-    </tr><tr>
+      <td colspan=3>[% classification.name FILTER html %]</td>
+    </tr>
+    <tr>
       <th>Description:</th>
-      <td valign="top" colspan=3>
+      <td colspan=3>
         [% IF classification.description %]
           [% classification.description FILTER html_light %]
         [% ELSE %]
           <span class="warning">description missing</span>
         [% END %]
       </td>
-
-    </tr><tr>
+    </tr>
+    <tr>
       <th>Sortkey:</th>
-      <td valign="top" colspan=3>[% classification.sortkey FILTER html %]</td>
-
-    </tr><tr>
+      <td colspan=3>[% classification.sortkey FILTER html %]</td>
+    </tr>
+    <tr>
       <th>Products:</th>
-      <td valign="top">Other Classifications</td>
+      <td>Other Classifications</td>
       <td></td>
-      <td valign="top">This Classification</td>
-
-    </tr><tr>
+      <td>This Classification</td>
+    </tr>
+    <tr>
       <td></td>
-      <td valign="top">
-      <select name="prodlist" id="prodlist" multiple="multiple" size="20">
+      <td>
+        <select name="prodlist" id="prodlist" multiple="multiple" size="20">
         [% FOREACH class = classifications %]
           [% IF class.id != classification.id %]
             [% FOREACH product = class.products %]
@@ -49,21 +50,23 @@
             [% END %]
           [% END %]
         [% END %]
-      </select></td>
+        </select>
+      </td>
 
-      <td align="center">
+      <td>
         <input type=submit value="     Add &gt;&gt;  " name="add_products"><br><br>
         <input type=submit value="&lt;&lt; Remove" name="remove_products">
       </td>
 
-      <td valign="middle" rowspan=2>
+      <td rowspan=2 class="max-width">
         <select name="myprodlist" id="myprodlist" multiple="multiple" size="20">
           [% FOREACH product = classification.products %]
             <option value="[% product.name FILTER html %]">
               [% product.name FILTER html %]
             </option>
           [% END %]
-      </select></td>
+        </select>
+      </td>
     </tr>
   </table>
 
diff --git a/template/en/default/admin/classifications/select.html.tmpl b/template/en/default/admin/classifications/select.html.tmpl
index 02a3cd413..ffe183cfa 100644
--- a/template/en/default/admin/classifications/select.html.tmpl
+++ b/template/en/default/admin/classifications/select.html.tmpl
@@ -11,9 +11,9 @@
   style_urls = ['skins/standard/admin.css']
 %]
 
-<table border=1 cellpadding=4 cellspacing=0>
+<table id="admin_table">
   <tr class="column_header">
-    <th>Edit Classification ...</th>
+    <th>Edit Classification...</th>
     <th>Description</th>
     <th>Sortkey</th>
     <th>Products</th>
@@ -22,26 +22,35 @@
 
   [% FOREACH cl = classifications %]
     <tr>
-      <td valign="top"><a href="editclassifications.cgi?action=edit&amp;classification=[% cl.name FILTER uri %]"><b>[% cl.name FILTER html %]</b></a></td>
-      <td valign="top"> 
+      <td>
+        <a href="editclassifications.cgi?action=edit&amp;classification=[% cl.name FILTER uri %]">
+          <b>[% cl.name FILTER html %]</b>
+        </a>
+      </td>
+      <td>
       [% IF cl.description %]
         [% cl.description FILTER html_light %]
       [% ELSE %]
         <span class="warning">none</span>
       [% END %]
       </td>
-      <td valign="top">[% cl.sortkey FILTER html %]</td>
+      <td>[% cl.sortkey FILTER html %]</td>
       [% IF (cl.id == 1) %]
-        <td valign="top">[% cl.product_count FILTER html %]</td>
+        <td>[% cl.product_count FILTER html %]</td>
       [% ELSE %]
-        <td valign="top"><a href="editclassifications.cgi?action=reclassify&amp;classification=[% cl.name FILTER uri %]">reclassify ([% cl.product_count FILTER html %])</a></td>
+        <td>
+          <a href="editclassifications.cgi?action=reclassify&amp;classification=[% cl.name FILTER uri %]">
+            reclassify&nbsp;([% cl.product_count FILTER html %])</a>
+        </td>
       [% END %]
 
       [%# don't allow user to delete the default id. %]
       [% IF (cl.id == 1) %]
-        <td valign="top">&nbsp;</td>
+        <td></td>
       [% ELSE %]
-        <td valign="top"><a href="editclassifications.cgi?action=del&amp;classification=[% cl.name FILTER uri %]">delete</a></td>
+        <td>
+          <a href="editclassifications.cgi?action=del&amp;classification=[% cl.name FILTER uri %]">delete</a>
+        </td>
       [% END %]
     </tr>
   [% END %]