summaryrefslogtreecommitdiffstats
path: root/template/en/default/attachment
diff options
context:
space:
mode:
authorFrédéric Buclin <LpSolit@gmail.com>2012-01-10 00:53:33 +0100
committerFrédéric Buclin <LpSolit@gmail.com>2012-01-10 00:53:33 +0100
commit74f713457a1d50b39a564cb0a647b2d937473e24 (patch)
tree0b74455a85edf0dcd2c6a8148371813f9a5d9c8c /template/en/default/attachment
parented87a68c9fa5c099c79f45bb6f3ab95e42f14002 (diff)
downloadbugzilla-74f713457a1d50b39a564cb0a647b2d937473e24.tar.gz
bugzilla-74f713457a1d50b39a564cb0a647b2d937473e24.tar.xz
Bug 716283: Clickjacking in the attachment "Details" page allows to bypass token checks
r=dkl a=LpSolit
Diffstat (limited to 'template/en/default/attachment')
-rw-r--r--template/en/default/attachment/edit.html.tmpl10
1 files changed, 10 insertions, 0 deletions
diff --git a/template/en/default/attachment/edit.html.tmpl b/template/en/default/attachment/edit.html.tmpl
index fbe3a9c79..95ad4d335 100644
--- a/template/en/default/attachment/edit.html.tmpl
+++ b/template/en/default/attachment/edit.html.tmpl
@@ -197,6 +197,16 @@
[% END %]
</a>
</p>
+ [% ELSIF attachment.contenttype == "text/html" %]
+ [%# For security reasons (clickjacking, embedded scripts), we never
+ # render HTML pages from here. The source code is displayed instead. %]
+ [% INCLUDE global/textarea.html.tmpl
+ id = 'viewFrame'
+ minrows = 10
+ cols = 80
+ defaultcontent = attachment.data
+ readonly = 'readonly'
+ %]
[% ELSE %]
<iframe id="viewFrame" src="attachment.cgi?id=[% attachment.id %]">
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.