Bug 251669: add an option to show users in a drop down menu instead of a text edit field

patch by glob <bugzilla@glob.com.au>
r=joel
a=justdave

3 files changed, 35 insertions, 12 deletions

diff --git a/template/en/default/bug/create/create.html.tmpl b/template/en/default/bug/create/create.html.tmpl
index 3364649e8..ecb3dd8c9 100644
--- a/template/en/default/bug/create/create.html.tmpl
+++ b/template/en/default/bug/create/create.html.tmpl
@@ -185,8 +185,12 @@ function set_assign_to() {
       </strong>
     </td>
     <td colspan="3">
-      <input name="assigned_to" size="32" 
-             value="[% assigned_to FILTER html %]">
+      [% INCLUDE global/userselect.html.tmpl
+         name => "assigned_to"
+         value => assigned_to
+         size => 32
+         emptyok => 1
+       %]
       <noscript>(Leave blank to assign to default component owner)</noscript>
     </td>
   </tr>
@@ -194,7 +198,12 @@ function set_assign_to() {
   <tr>
     <td align="right"><strong>Cc:</strong></td>
     <td colspan="3">
-      <input name="cc" size="45" value="[% cc FILTER html %]">
+      [% INCLUDE global/userselect.html.tmpl
+         name => "cc"
+         value => cc
+         size => 45
+         emptyok => 1
+       %]
     </td>
   </tr>
   
diff --git a/template/en/default/bug/edit.html.tmpl b/template/en/default/bug/edit.html.tmpl
index ef6b551fa..f4c68bb4d 100644
--- a/template/en/default/bug/edit.html.tmpl
+++ b/template/en/default/bug/edit.html.tmpl
@@ -163,7 +163,13 @@
         <b><u>A</u>dd&nbsp;CC:</b>
       </td>
       <td>
-        <input name="newcc" size="30" value="" accesskey="a">
+         [% INCLUDE global/userselect.html.tmpl
+            name => "newcc"
+            value => ""
+            accesskey => "a"
+            size => 30
+            emptyok => 1
+          %]
       </td>
     </tr>
 
@@ -270,8 +276,13 @@
        <b><u>Q</u>A Contact:</b>
        </td>
        <td colspan="7">
-         <input name="qa_contact" accesskey="q"
-                value="[% bug.qa_contact.email FILTER html %]" size="60">
+         [% INCLUDE global/userselect.html.tmpl
+            name => "qa_contact"
+            value => bug.qa_contact.email
+            accesskey => "q"
+            size => 60
+            emptyok => 1
+          %]
        </td>
      </tr>
    [% END %]
diff --git a/template/en/default/bug/knob.html.tmpl b/template/en/default/bug/knob.html.tmpl
index b93f8099d..8ab0ce0ad 100644
--- a/template/en/default/bug/knob.html.tmpl
+++ b/template/en/default/bug/knob.html.tmpl
@@ -96,12 +96,15 @@
         <a href="page.cgi?id=fields.html#assigned_to">Reassign</a> 
         [% terms.bug %] to
       </label>
-      <input name="assigned_to" size="32"
-             onchange="if ((this.value != '[% bug.assigned_to.email FILTER js FILTER html %]') &&
-                            (this.value != '')) {
-                         document.changeform.knob[[% knum %]].checked=true;
-                       }"
-             value="[% bug.assigned_to.email FILTER html %]">
+      [% safe_assigned_to = FILTER js; bug.assigned_to.email; END %]
+      [% INCLUDE global/userselect.html.tmpl
+           name => "assigned_to"
+           value => bug.assigned_to.email
+           size => 32
+           onchange => "if ((this.value != '$safe_assigned_to') && (this.value != '')) {
+                          document.changeform.knob[$knum].checked=true;
+                        }"
+      %]
       <br>
       [% IF bug.isunconfirmed && bug.user.canconfirm %]
         &nbsp;&nbsp;&nbsp;&nbsp;<input type="checkbox" id="andconfirm" name="andconfirm">