Bug 952795: Remove all style="..." attributes from HTML elements

r/a=justdave

1 files changed, 32 insertions, 52 deletions

diff --git a/template/en/default/whine/schedule.html.tmpl b/template/en/default/whine/schedule.html.tmpl
index a29d358d3..6f1ff4991 100644
--- a/template/en/default/whine/schedule.html.tmpl
+++ b/template/en/default/whine/schedule.html.tmpl
@@ -63,29 +63,25 @@
 <form method="post" action="editwhines.cgi">
 [%# This hidden submit button must be here to set default behavior when
     the user presses return on a form input field #%]
-<input type="submit" value="Update / Commit" name="commit"
-       style="display: none;" id="commit">
+<input type="submit" value="Update / Commit" id="commit" name="commit"
+       class="bz_default_hidden">
 <input type="hidden" name="update" value="1">
 <input type="hidden" name="token" value="[% token FILTER html %]">
 
 [% FOREACH event = events %]
 
-<table cellspacing="2" cellpadding="2" style="border: 1px solid;">
+<table class="whining_list">
   <tr>
-    <th>
-      Event:
-    </th>
-    <td align="right" colspan="2">
+    <th class="subtitle">Event:</th>
+    <th colspan="2">
       <input type="submit" value="Remove Event"
              name="remove_event_[% event.key %]"
              id="remove_event_[% event.key %]">
-    </td>
+    </th>
   </tr>
 
   <tr>
-    <td valign="top" align="right">
-      Email subject line:
-    </td>
+    <th>Email subject line:</th>
     <td colspan="2">
       <input type="text" name="event_[% event.key %]_subject"
              size="60" maxlength="128" value="
@@ -94,9 +90,7 @@
   </tr>
 
   <tr>
-    <td valign="top" align="right">
-      Descriptive text sent within whine message:
-    </td>
+    <th>Descriptive text sent within whine message:</th>
     <td colspan="2">
       [% INCLUDE global/textarea.html.tmpl
          name           = "event_${event.key}_body"
@@ -110,9 +104,7 @@
   </tr>
 
   <tr>
-    <td valign="top" align="right">
-      Send a message even if there are no [% terms.bugs %] in the search result:
-    </td>
+    <th>Send a message even if there are no [% terms.bugs %] in the search result:</th>
     <td colspan="2">
       <input type="checkbox" name="event_[% event.key %]_mailifnobugs"
         [%- IF event.value.mailifnobugs == 1 %] checked [% END %]>
@@ -122,9 +114,7 @@
   [% IF event.value.schedule.size == 0 %]
 
     <tr>
-      <td valign="top" align="right">
-        Schedule:
-      </td>
+      <th>Schedule:</th>
       <td class="unset" colspan="2">
         Not scheduled to run<br>
         <input type="submit" value="Add a new schedule"
@@ -136,28 +126,23 @@
   [% ELSE %]
 
     <tr>
-      <td valign="top" align="right">
-        Schedule:
-      </td>
+      <th>Schedule:</th>
       <td class="set" colspan="2">
 
-        <table>
+        <table class="schedule_list">
           <tr>
-            <th>
-              Interval
-            </th>
+            <th>Interval</th>
             <th>
               [% IF mail_others %]
                 Mail to
               [% END %]
             </th>
-            <th>
-            </th>
+            <th></th>
           </tr>
+
           [% FOREACH schedule = event.value.schedule %]
             <tr>
-              <td align="left">
-
+              <td>
                 [%# these hidden fields allow us to compare old values instead
                     of reading the database to tell if a field has changed %]
 
@@ -168,7 +153,7 @@
                 [% PROCESS day_field val=schedule.day %]
                 [% PROCESS time_field val=schedule.time %]
               </td>
-              <td align="left">
+              <td>
                 [% IF mail_others %]
                   <input type="hidden" name="orig_mailto_type_[% schedule.id %]"
                          value="[% schedule.mailto_type FILTER html %]">
@@ -186,7 +171,7 @@
                          value="[% schedule.mailto FILTER html %]" size="30">
                 [% END %]
               </td>
-              <td align="left">
+              <td>
                 <input type="submit" value="Remove"
                        name="remove_schedule_[% schedule.id %]"
                        id="remove_schedule_[% schedule.id %]">
@@ -211,16 +196,14 @@
   [% IF event.value.queries.size == 0 %]
 
     <tr>
-      <td valign="top" align="right">
-        Searches:
-      </td>
-      <td align="left">
+      <th>Searches:</th>
+      <td>
         No searches <br>
         <input type="submit" value="Add a search"
                name="add_query_[% event.key %]"
                id="add_query_[% event.key %]">
       </td>
-      <td align="right" valign="bottom">
+      <td class="right">
         <input type="submit" value="Update / Commit" name="commit" id="update">
       </td>
     </tr>
@@ -228,42 +211,39 @@
   [% ELSE %]
 
     <tr>
-      <td valign="top" align="right">
-        Searches:
-      </td>
-      <td align="left" colspan="2">
+      <th>Searches:</th>
+      <td colspan="2">
 
-        <table>
+        <table class="search_list">
           <tr>
             <th>Sort</th>
             <th>Search</th>
             <th>Title</th>
-            <th></th>
-            <th></th>
+            <th colspan="2"></th>
           </tr>
 
           [% FOREACH query = event.value.queries %]
 
             <tr>
-              <td align="left">
+              <td>
                 <input type="text" name="query_sort_[% query.id %]"
                        size="3" value="[% query.sort %]">
                 <input type="hidden" value="[% query.sort %]"
                        name="orig_query_sort_[% query.id %]">
               </td>
-              <td align="left">
+              <td>
                 <input type="hidden" value="[% query.name FILTER html %]"
                        name="orig_query_name_[% query.id %]">
                 [% PROCESS query_field thisquery=query.name %]
               </td>
-              <td align="left">
+              <td>
                 <input type="hidden" value="[% query.title FILTER html %]"
                        name="orig_query_title_[% query.id %]">
                 <input type="text" name="query_title_[% query.id %]"
                        size="50" value="[% query.title FILTER html %]"
                        maxlength="64">
               </td>
-              <td align="left">
+              <td>
                 <input type="hidden" value="[% query.onemailperbug FILTER html %]"
                        name="orig_query_onemailperbug_[% query.id %]">
                 <input type="checkbox" [% IF query.onemailperbug == 1 %] checked [% END %]
@@ -271,7 +251,7 @@
                        name="query_onemailperbug_[% query.id %]">
                 <label for="query_onemailperbug_[% query.id %]">One message per [% terms.bug %]</label>
               </td>
-              <td align="right">
+              <td>
                 <input type="submit" value="Remove"
                        name="remove_query_[% query.id %]"
                        id="remove_query_[% query.id %]">
@@ -286,7 +266,7 @@
                      name="add_query_[% event.key %]"
                      id="add_query_[% event.key %]">
             </td>
-            <td align="right" colspan="2">
+            <td colspan="2" class="right">
               <input type="submit" value="Update / Commit" name="commit" id="update">
             </td>
           </tr>
@@ -301,7 +281,7 @@
 
 [% END %]
 
-<p align="left">
+<p>
   <input type="submit" value="Add a new event" name="add_event" id="add_event">
 </p>