summaryrefslogtreecommitdiffstats
path: root/template/en/default
diff options
context:
space:
mode:
authorKohei Yoshino <kohei.yoshino@gmail.com>2018-01-08 15:55:43 +0100
committerDylan William Hardison <dylan@hardison.net>2018-01-08 15:55:43 +0100
commit9b3834764b26d0a806b72fdc3657075b7ab9c7c0 (patch)
tree2ed56c99d842b9ec52951723b0515af83edadbbf /template/en/default
parentf86567c1f22f5d4dfa9bcc097efaef3ecb8b44bc (diff)
downloadbugzilla-9b3834764b26d0a806b72fdc3657075b7ab9c7c0.tar.gz
bugzilla-9b3834764b26d0a806b72fdc3657075b7ab9c7c0.tar.xz
Bug 1428642 - Fix minor bugs on new global header
* The magnifier icon on the search bar should not trigger search as reported in https://twitter.com/colinjoy/status/949035254949523457 * The search dropdown should show Saved Searches Edit link as suggested in my UX analysis * Remove the CSS transition on the More Tools button for consistency. I didn't add the transition; it's default style for buttons * Fix the position of the arrow/triangle on dropdown lists. An error of 1px. * Add `user-select: none;` to `#header` https://developer.mozilla.org/en-US/docs/Web/CSS/user select
Diffstat (limited to 'template/en/default')
-rw-r--r--template/en/default/global/header-search-dropdown.html.tmpl5
-rw-r--r--template/en/default/global/header.html.tmpl4
2 files changed, 5 insertions, 4 deletions
diff --git a/template/en/default/global/header-search-dropdown.html.tmpl b/template/en/default/global/header-search-dropdown.html.tmpl
index 590c95d31..8e79978ba 100644
--- a/template/en/default/global/header-search-dropdown.html.tmpl
+++ b/template/en/default/global/header-search-dropdown.html.tmpl
@@ -26,7 +26,10 @@
<div id="header-search-dropdown-wrapper">
[% IF user.showmybugslink OR user.queries.size OR user.queries_subscribed.size %]
<section id="header-search-dropdown-saved">
- <h3>Saved Searches</h3>
+ <header>
+ <h3>Saved Searches</h3>
+ <a href="userprefs.cgi?tab=saved-searches">Edit</a>
+ </header>
<ul role="none">
[% IF user.showmybugslink %][% filtered_username = user.login FILTER uri %]
<li role="none"><a role="option" href="[% Param('mybugstemplate').replace('%userid%', filtered_username) %]">
diff --git a/template/en/default/global/header.html.tmpl b/template/en/default/global/header.html.tmpl
index 0f9646ba1..04b996e16 100644
--- a/template/en/default/global/header.html.tmpl
+++ b/template/en/default/global/header.html.tmpl
@@ -242,13 +242,11 @@
<section class="searchbox-outer dropdown" role="combobox" aria-expanded="false" aria-haspopup="listbox"
aria-owns="header-search-dropdown">
<h2>Quick Search</h2>
+ <span class="icon" aria-hidden="true"></span>
<input role="searchbox" id="quicksearch_top" class="dropdown-button" name="quicksearch" autocomplete="off"
value="[% quicksearch FILTER html %]" placeholder="Search [% terms.Bugs %]"
title="Enter a [% terms.bug %] number or some search terms" aria-controls="header-search-dropdown"
aria-label="Quick Search">
- <button type="submit" id="find_top" aria-label="Submit">
- <span class="icon" aria-hidden="true"></span>
- </button>
[% PROCESS "global/header-search-dropdown.html.tmpl" %]
</section>
</form>