Bug 962812: Use the "required" attribute where appropriate

r=LpSolit a=justdave

26 files changed, 48 insertions, 39 deletions

diff --git a/template/en/default/account/auth/login.html.tmpl b/template/en/default/account/auth/login.html.tmpl
index 27c0690af..bf20edb8b 100644
--- a/template/en/default/account/auth/login.html.tmpl
+++ b/template/en/default/account/auth/login.html.tmpl
@@ -39,14 +39,14 @@
       </th>
       <td>
         <input size="35" id="Bugzilla_login" name="Bugzilla_login"
-               [%- ' type="email"' UNLESS Param('emailsuffix') %] autofocus>
+               [%- ' type="email"' UNLESS Param('emailsuffix') %] autofocus required>
         [% Param('emailsuffix') FILTER html %]
       </td>
     </tr>
     <tr>
       <th><label for="Bugzilla_password">Password:</label></th>
       <td>
-        <input type="password" size="35" id="Bugzilla_password" name="Bugzilla_password">
+        <input type="password" size="35" id="Bugzilla_password" name="Bugzilla_password" required>
       </td>
     </tr>
 
@@ -115,7 +115,7 @@
       If you have an account, but have forgotten your password,
       enter your login name below and submit a request
       to change your password.<br>
-      <input size="35" name="loginname">
+      <input size="35" name="loginname" required>
       <input type="hidden" id="token" name="token" value="[% issue_hash_token(['reqpw']) FILTER html %]">
       <input type="submit" id="request" value="Reset Password">
     </form>
diff --git a/template/en/default/account/create.html.tmpl b/template/en/default/account/create.html.tmpl
index 1b5a4daa8..5711a726f 100644
--- a/template/en/default/account/create.html.tmpl
+++ b/template/en/default/account/create.html.tmpl
@@ -72,7 +72,7 @@
     [% END %]
   </span>
   <input size="35" id="login" name="login" autofocus
-         [%- ' type="email"' UNLESS Param('emailsuffix') %]>
+         [%- ' type="email"' UNLESS Param('emailsuffix') %] required>
   [% Param('emailsuffix') FILTER html %]
   <input type="hidden" id="token" name="token" value="[% issue_hash_token(['create_account']) FILTER html %]">
   <input type="submit" id="send" value="Send">
diff --git a/template/en/default/account/email/confirm-new.html.tmpl b/template/en/default/account/email/confirm-new.html.tmpl
index ec8d5a474..095097698 100644
--- a/template/en/default/account/email/confirm-new.html.tmpl
+++ b/template/en/default/account/email/confirm-new.html.tmpl
@@ -38,13 +38,13 @@
     <tr>
       <th><label for="passwd1">Type your password</label>:</th>
       <td>
-        <input type="password" id="passwd1" name="passwd1" value="">
+        <input type="password" id="passwd1" name="passwd1" value="" required>
         (minimum [% constants.USER_PASSWORD_MIN_LENGTH FILTER none %] characters)
       </td>
     </tr>
     <tr>
       <th><label for="passwd2">Confirm your password</label>:</th>
-      <td><input type="password" id="passwd2" name="passwd2" value=""></td>
+      <td><input type="password" id="passwd2" name="passwd2" value="" required></td>
     </tr>
     <tr>
       <th>&nbsp;</th>
diff --git a/template/en/default/account/email/confirm.html.tmpl b/template/en/default/account/email/confirm.html.tmpl
index 6fc171878..8edc7a9ba 100644
--- a/template/en/default/account/email/confirm.html.tmpl
+++ b/template/en/default/account/email/confirm.html.tmpl
@@ -23,7 +23,7 @@
   <table>
     <tr>
       <th>Password:</th>
-      <td><input type="password" name="password" size="36"></td>
+      <td><input type="password" name="password" size="36" required></td>
     </tr>
     <tr>
       <th>&nbsp;</th>
diff --git a/template/en/default/account/password/set-forgotten-password.html.tmpl b/template/en/default/account/password/set-forgotten-password.html.tmpl
index b203e66e9..eca11174f 100644
--- a/template/en/default/account/password/set-forgotten-password.html.tmpl
+++ b/template/en/default/account/password/set-forgotten-password.html.tmpl
@@ -30,17 +30,17 @@
     <tr>
       <th>New password:</th>
       <td>
-        <input type="password" name="password">
+        <input type="password" name="password" required>
       </td>
     </tr>
     
     <tr>
       <th>Confirm new password:</th>
       <td>
-        <input type="password" name="matchpassword">
+        <input type="password" name="matchpassword" required>
       </td>
     </tr>
-    
+     
     <tr>
       <th>&nbsp;</th>
       <td>
diff --git a/template/en/default/admin/classifications/edit-common.html.tmpl b/template/en/default/admin/classifications/edit-common.html.tmpl
index 9dd6c1676..c2bae5c42 100644
--- a/template/en/default/admin/classifications/edit-common.html.tmpl
+++ b/template/en/default/admin/classifications/edit-common.html.tmpl
@@ -13,7 +13,7 @@
 <tr>
   <th>Classification:</th>
   <td><input size=64 maxlength=64 name="classification" 
-             value="[% classification.name FILTER html %]"></td>
+             value="[% classification.name FILTER html %]" required></td>
 </tr>
 <tr>
   <th>Description:</th>
diff --git a/template/en/default/admin/components/edit-common.html.tmpl b/template/en/default/admin/components/edit-common.html.tmpl
index 00b80baa8..72300af79 100644
--- a/template/en/default/admin/components/edit-common.html.tmpl
+++ b/template/en/default/admin/components/edit-common.html.tmpl
@@ -17,7 +17,7 @@
 <tr>
   <th><label for="component">Component:</label></th>
   <td><input size="64" maxlength="64" name="component" id="component"
-             value="[%- comp.name FILTER html %]"></td>
+             value="[%- comp.name FILTER html %]" required></td>
 </tr>
 <tr>
   <th><label for="[% desc_name FILTER html %]">Component Description:</label></th>
@@ -29,6 +29,7 @@
       cols           = 64
       wrap           = 'virtual'
       defaultcontent = comp.description
+      mandatory      = 1
     %]
   </td>
 </tr>
@@ -40,6 +41,7 @@
        id => "initialowner"
        value => comp.default_assignee.login
        size => 64
+       mandatory => 1
      %]
   </td>
 </tr>
diff --git a/template/en/default/admin/custom_fields/edit-common.html.tmpl b/template/en/default/admin/custom_fields/edit-common.html.tmpl
index f54073cfe..6c22bb81f 100644
--- a/template/en/default/admin/custom_fields/edit-common.html.tmpl
+++ b/template/en/default/admin/custom_fields/edit-common.html.tmpl
@@ -19,7 +19,7 @@
       [% IF field %]
         [% field.name FILTER html %]
       [% ELSE %]
-        <input type="text" id="name" name="name" value="cf_" size="40" maxlength="64">
+        <input type="text" id="name" name="name" value="cf_" size="40" maxlength="64" required>
       [% END %]
     </td>
 
@@ -37,7 +37,7 @@
     <th><label for="desc">Description:</label></th>
     <td>
       <input type="text" id="desc" name="desc" size="40"
-             value="[% field.description FILTER html %]">
+             value="[% field.description FILTER html %]" required>
     </td>
 
     <th>
diff --git a/template/en/default/admin/fieldvalues/create.html.tmpl b/template/en/default/admin/fieldvalues/create.html.tmpl
index 4d07d5b0e..8d1dbc8b9 100644
--- a/template/en/default/admin/fieldvalues/create.html.tmpl
+++ b/template/en/default/admin/fieldvalues/create.html.tmpl
@@ -29,7 +29,7 @@
       <th><label for="value">Value:</label></th>
       <td>
         <input id="value" name="value" size="30"
-               maxlength="[% constants.MAX_FIELD_VALUE_SIZE FILTER none %]">
+               maxlength="[% constants.MAX_FIELD_VALUE_SIZE FILTER none %]" required>
       </td>
     </tr>
     <tr>
diff --git a/template/en/default/admin/fieldvalues/edit.html.tmpl b/template/en/default/admin/fieldvalues/edit.html.tmpl
index dbe222590..2630fee92 100644
--- a/template/en/default/admin/fieldvalues/edit.html.tmpl
+++ b/template/en/default/admin/fieldvalues/edit.html.tmpl
@@ -32,7 +32,7 @@
         [% ELSE %]
           <input id="value_new" name="value_new" size="20"
                  maxlength="[% constants.MAX_FIELD_VALUE_SIZE FILTER none %]"
-                 value="[% value.name FILTER html %]">
+                 value="[% value.name FILTER html %]" required>
         [% END %]
       </td>
     </tr>
diff --git a/template/en/default/admin/flag-type/edit.html.tmpl b/template/en/default/admin/flag-type/edit.html.tmpl
index e52d58a9a..4ee4a999c 100644
--- a/template/en/default/admin/flag-type/edit.html.tmpl
+++ b/template/en/default/admin/flag-type/edit.html.tmpl
@@ -52,7 +52,7 @@
       <td>
         a short name identifying this type.<br>
         <input type="text" name="name" value="[% type.name FILTER html %]" size="50"
-               maxlength="50" [%- ' disabled="disabled"' UNLESS can_fully_edit %]>
+               maxlength="50" [%- ' disabled="disabled"' UNLESS can_fully_edit %] required>
       </td>
     </tr>
 
@@ -66,6 +66,7 @@
           cols           = 80
           defaultcontent = type.description
           disabled       = !can_fully_edit
+          mandatory      = 1
         %]
       </td>
     </tr>
@@ -129,7 +130,7 @@
         don't care what order the types appear in or if you want them to appear
         in alphabetical order.<br>
         <input type="text" name="sortkey" value="[% type.sortkey || 0 FILTER html %]" size="5"
-               maxlength="5" [% ' disabled="disabled"' UNLESS can_fully_edit %]>
+               maxlength="5" [% ' disabled="disabled"' UNLESS can_fully_edit %] required>
       </td>
     </tr>
 
diff --git a/template/en/default/admin/groups/create.html.tmpl b/template/en/default/admin/groups/create.html.tmpl
index 06396926c..8f9be1c7a 100644
--- a/template/en/default/admin/groups/create.html.tmpl
+++ b/template/en/default/admin/groups/create.html.tmpl
@@ -21,11 +21,11 @@
   <table id="admin_table_edit">
     <tr>
       <th>Group Name:</th>
-      <td><input size="60" maxlength="255" name="name"></td>
+      <td><input size="60" maxlength="255" name="name" required></td>
     </tr>
     <tr>
       <th>Description:</th>
-      <td><input size="60" name="desc"></td>
+      <td><input size="60" name="desc" required></td>
     </tr>
     <tr>
       <th>User Regexp:</th>
diff --git a/template/en/default/admin/groups/edit.html.tmpl b/template/en/default/admin/groups/edit.html.tmpl
index c9883ce42..1cc948ea2 100644
--- a/template/en/default/admin/groups/edit.html.tmpl
+++ b/template/en/default/admin/groups/edit.html.tmpl
@@ -32,7 +32,7 @@
       <td>
         [% IF group.is_bug_group %]
           <input type="text" name="name" size="60" maxlength="255"
-                 value="[% group.name FILTER html %]">
+                 value="[% group.name FILTER html %]" required>
         [% ELSE %]
           [% group.name FILTER html %]
         [% END %]
@@ -44,7 +44,7 @@
       <td>
         [% IF group.is_bug_group %]
           <input type="text" name="desc" size="60"
-                 value="[% group.description FILTER html %]">
+                 value="[% group.description FILTER html %]" required>
         [% ELSE %]
           [% group.description FILTER html %]
         [% END %]
diff --git a/template/en/default/admin/keywords/create.html.tmpl b/template/en/default/admin/keywords/create.html.tmpl
index 3c310cce0..21ecaf920 100644
--- a/template/en/default/admin/keywords/create.html.tmpl
+++ b/template/en/default/admin/keywords/create.html.tmpl
@@ -20,7 +20,7 @@
   <table id="admin_table_edit">
     <tr>
       <th>Name:</th>
-      <td><input size="64" maxlength="64" name="name" value=""></td>
+      <td><input size="64" maxlength="64" name="name" value="" required></td>
     </tr>
     <tr>
       <th>Description:</th>
@@ -30,6 +30,7 @@
           minrows = 4
           cols    = 64
           wrap    = 'virtual'
+          mandatory = 1
         %]
       </td>
     </tr>
diff --git a/template/en/default/admin/keywords/edit.html.tmpl b/template/en/default/admin/keywords/edit.html.tmpl
index 1c3d1c3c5..23158d36f 100644
--- a/template/en/default/admin/keywords/edit.html.tmpl
+++ b/template/en/default/admin/keywords/edit.html.tmpl
@@ -20,7 +20,7 @@
     <tr>
       <th>Name:</th>
       <td><input size="64" maxlength="64" name="name" 
-                 value="[% keyword.name FILTER html %]"></td>
+                 value="[% keyword.name FILTER html %]" required></td>
     </tr>
     <tr>
       <th>Description:</th>
@@ -31,6 +31,7 @@
           cols           = 64
           wrap           = 'virtual'
           defaultcontent = keyword.description
+          mandatory      = 1
         %]
       </td>
     </tr>
diff --git a/template/en/default/admin/milestones/create.html.tmpl b/template/en/default/admin/milestones/create.html.tmpl
index d15e43d55..4f1a24144 100644
--- a/template/en/default/admin/milestones/create.html.tmpl
+++ b/template/en/default/admin/milestones/create.html.tmpl
@@ -25,7 +25,7 @@
     <tr>
       <th><label for="milestone">Milestone:</label></th>
       <td><input id="milestone" size="64" maxlength="64" name="milestone"
-                 autofocus></td>
+                 autofocus required></td>
     </tr>
     <tr>
       <th><label for="sortkey">Sortkey:</label></th>
diff --git a/template/en/default/admin/milestones/edit.html.tmpl b/template/en/default/admin/milestones/edit.html.tmpl
index 86d0ebc1e..cbc7330fe 100644
--- a/template/en/default/admin/milestones/edit.html.tmpl
+++ b/template/en/default/admin/milestones/edit.html.tmpl
@@ -26,7 +26,7 @@
     <tr>
       <th><label for="milestone">Milestone:</label></th>
       <td><input id="milestone" size="64" maxlength="64" name="milestone" value="
-      [%- milestone.name FILTER html %]"></td>
+      [%- milestone.name FILTER html %]" required></td>
     </tr>
     <tr>
       <th><label for="sortkey">Sortkey:</label></th>
diff --git a/template/en/default/admin/products/create.html.tmpl b/template/en/default/admin/products/create.html.tmpl
index da63a2ff5..b34f67b62 100644
--- a/template/en/default/admin/products/create.html.tmpl
+++ b/template/en/default/admin/products/create.html.tmpl
@@ -37,7 +37,7 @@
     <tr>
       <th>Version:</th>
       <td><input size="20" maxlength="64" name="version" 
-                value="[% version FILTER html %]">
+                value="[% version FILTER html %]" required>
       </td>
     </tr>
     <tr>
diff --git a/template/en/default/admin/products/edit-common.html.tmpl b/template/en/default/admin/products/edit-common.html.tmpl
index 6faa07469..baf5015ae 100644
--- a/template/en/default/admin/products/edit-common.html.tmpl
+++ b/template/en/default/admin/products/edit-common.html.tmpl
@@ -22,12 +22,12 @@
 <tr>
   <th>Product:</th>
   <td><input size="64" maxlength="64" name="product" 
-             value="[% product.name FILTER html %]">
+             value="[% product.name FILTER html %]" required>
   </td>
 </tr>
 <tr>
   <th>Description:</th>
-  <td><textarea rows="4" cols="64" wrap="virtual" name="description">
+  <td><textarea rows="4" cols="64" wrap="virtual" name="description" required>
         [% product.description FILTER html %]</textarea>
   </td>
 </tr>
diff --git a/template/en/default/admin/sudo.html.tmpl b/template/en/default/admin/sudo.html.tmpl
index a5f13a015..d4faf4ea7 100644
--- a/template/en/default/admin/sudo.html.tmpl
+++ b/template/en/default/admin/sudo.html.tmpl
@@ -41,6 +41,7 @@
        value => target_login_default
        accesskey => "u"
        size => 30
+       mandatory => 1
     %]
   </p>
   
@@ -69,7 +70,7 @@
       password</label>:
       <input type="hidden" name="Bugzilla_login" value="
       [%- user.login FILTER html %]">
-      <input type="password" id="Bugzilla_password" name="Bugzilla_password" size="20">
+      <input type="password" id="Bugzilla_password" name="Bugzilla_password" size="20" required>
       <br>
       This is done for two reasons.  First of all, it is done to reduce 
       the chances of someone doing large amounts of damage using your 
diff --git a/template/en/default/admin/users/userdata.html.tmpl b/template/en/default/admin/users/userdata.html.tmpl
index 8cdc767e4..c08cd0018 100644
--- a/template/en/default/admin/users/userdata.html.tmpl
+++ b/template/en/default/admin/users/userdata.html.tmpl
@@ -23,7 +23,7 @@
     [% IF editusers %]
       <input size="64" maxlength="255" id="login" name="login"
              value="[% otheruser.login FILTER html %]"
-             [%- " autofocus" UNLESS editform %]>
+             [%- " autofocus" UNLESS editform %] required>
       [% IF editform %]
         [% IF !otheruser.in_group('bz_sudo_protect') %]
           <br>
@@ -72,7 +72,7 @@
     <th><label for="password">Password:</label></th>
     <td>
       <input type="password" size="16" name="password" id="password"
-             value="" autocomplete="off">
+             value="" autocomplete="off" [% 'required' IF !editform %]>
       [% IF password_complexity == "mixed_letters" %] 
         (Password must contain at least one UPPER and one lowercase letter.)
       [% ELSIF password_complexity == "letters_numbers" %] 
diff --git a/template/en/default/admin/versions/create.html.tmpl b/template/en/default/admin/versions/create.html.tmpl
index 46bd38c17..648adcebd 100644
--- a/template/en/default/admin/versions/create.html.tmpl
+++ b/template/en/default/admin/versions/create.html.tmpl
@@ -25,7 +25,7 @@
     <tr>
       <th><label for="version">Version:</label></th>
       <td><input id="version" size="64" maxlength="64" name="version"
-                 value=""></td>
+                 value="" required></td>
     </tr>
   </table>
   <input type="submit" id="create" value="Add">
diff --git a/template/en/default/admin/versions/edit.html.tmpl b/template/en/default/admin/versions/edit.html.tmpl
index 4ea202c04..1ef0b2f66 100644
--- a/template/en/default/admin/versions/edit.html.tmpl
+++ b/template/en/default/admin/versions/edit.html.tmpl
@@ -26,7 +26,7 @@
       <th><label for="version">Version:</label></th>
       <td>
         <input id="version" size="64" maxlength="64" name="version"
-               value="[% version.name FILTER html %]">
+               value="[% version.name FILTER html %]" required>
       </td>
     </tr>
     <tr>
diff --git a/template/en/default/bug/field.html.tmpl b/template/en/default/bug/field.html.tmpl
index b3b92e198..88200fdfa 100644
--- a/template/en/default/bug/field.html.tmpl
+++ b/template/en/default/bug/field.html.tmpl
@@ -42,13 +42,13 @@
                value="[% value FILTER html %]" size="40"
                maxlength="[% constants.MAX_FREETEXT_LENGTH FILTER none %]"
                [% ' pattern="\d+"' IF field.type == constants.FIELD_TYPE_INTEGER %]
-               [% ' aria-required="true"' IF field.is_mandatory %]>
+               [% ' aria-required="true" required' IF field.is_mandatory %]>
     [% CASE [constants.FIELD_TYPE_DATETIME, constants.FIELD_TYPE_DATE] %]
       [% size = (field.type == constants.FIELD_TYPE_DATE) ? 10 : 20 %]
       <input name="[% field.name FILTER html %]" size="[% size FILTER none %]"
              id="[% field.name FILTER html %]"
              value="[% value FILTER html %]"
-             [% ' aria-required="true"' IF field.is_mandatory %]
+             [% ' aria-required="true" required' IF field.is_mandatory %]
              onchange="updateCalendarFromField(this)">
       <button type="button" class="calendar_button"
               id="button_calendar_[% field.name FILTER html %]"
@@ -66,7 +66,7 @@
         <span id="[% field.name FILTER html %]_input_area">
           <input name="[% field.name FILTER html %]" id="[% field.name FILTER html %]"
                  value="[% value FILTER html %]" size="7"
-                 [% ' aria-required="true"' IF field.is_mandatory %]>
+                 [% ' aria-required="true" required' IF field.is_mandatory %]>
 
         </span>
 
@@ -94,7 +94,7 @@
                         [% SET field_size = field.legal_values.size %]
                     [% END %]
                     size="[% field_size FILTER html %]" multiple="multiple"
-                    [% ' aria-required="true"' IF field.is_mandatory %]
+                    [% ' aria-required="true" required' IF field.is_mandatory %]
                 [% END %]
                 >
           [% IF allow_dont_change %]
diff --git a/template/en/default/global/userselect.html.tmpl b/template/en/default/global/userselect.html.tmpl
index 828c4bb58..e2210c6f2 100644
--- a/template/en/default/global/userselect.html.tmpl
+++ b/template/en/default/global/userselect.html.tmpl
@@ -20,6 +20,7 @@
   # multiple: optional, do multiselect box, value is size (height) of box
   # custom_userlist: optional, specify a limited list of users to use
   # field_title: optional, extra information to display as a tooltip
+  # mandatory: optional; if true, the field cannot be empty.
   #%]
 
 [% IF Param("usemenuforusers") %]
@@ -31,6 +32,7 @@
   [% IF accesskey %] accesskey="[% accesskey FILTER html %]" [% END %]
   [% IF multiple %] multiple="multiple" size="[% multiple FILTER html %]" [% END %]
   [% IF field_title %] title="[% field_title FILTER html %]" [% END %]
+  [% IF mandatory %] required [% END %]
 >
   [% IF emptyok %]
     <option value=""></option>
@@ -83,6 +85,7 @@
     [% IF field_title %] title="[% field_title FILTER html %]" [% END %]
     [% IF size %] size="[% size FILTER html %]" [% END %]
     [% IF id %] id="[% id FILTER html %]" [% END %]
+    [% IF mandatory %] required [% END %]
   >
   [% IF feature_enabled('jsonrpc') && Param('ajax_user_autocompletion') && id %]
     <div id="[% id FILTER html %]_autocomplete_container"></div>
diff --git a/template/en/default/list/quips.html.tmpl b/template/en/default/list/quips.html.tmpl
index 4bb761dc1..8fb89af7c 100644
--- a/template/en/default/list/quips.html.tmpl
+++ b/template/en/default/list/quips.html.tmpl
@@ -38,7 +38,7 @@
     <input type="hidden" name="action" value="add">
     <input type="hidden" name="token"
            value="[% issue_hash_token(['create-quips']) FILTER html %]">
-    <input size="80" name="quip" maxlength="512">
+    <input size="80" name="quip" maxlength="512" required>
     <p>
       <input type="submit" id="add" value="Add This Quip">
     </p>