diff options
author | Perl Tidy <perltidy@bugzilla.org> | 2018-12-05 21:38:52 +0100 |
---|---|---|
committer | Dylan William Hardison <dylan@hardison.net> | 2018-12-05 23:49:08 +0100 |
commit | 8ec8da0491ad89604700b3e29a227966f6d84ba1 (patch) | |
tree | 9d270f173330ca19700e0ba9f2ee931300646de1 /xt/lib/Bugzilla/Test/Search/FieldTestNormal.pm | |
parent | a7bb5a65b71644d9efce5fed783ed545b9336548 (diff) | |
download | bugzilla-8ec8da0491ad89604700b3e29a227966f6d84ba1.tar.gz bugzilla-8ec8da0491ad89604700b3e29a227966f6d84ba1.tar.xz |
no bug - reformat all the code using the new perltidy rules
Diffstat (limited to 'xt/lib/Bugzilla/Test/Search/FieldTestNormal.pm')
-rw-r--r-- | xt/lib/Bugzilla/Test/Search/FieldTestNormal.pm | 121 |
1 files changed, 61 insertions, 60 deletions
diff --git a/xt/lib/Bugzilla/Test/Search/FieldTestNormal.pm b/xt/lib/Bugzilla/Test/Search/FieldTestNormal.pm index 8c3ff19ab..1be251fe9 100644 --- a/xt/lib/Bugzilla/Test/Search/FieldTestNormal.pm +++ b/xt/lib/Bugzilla/Test/Search/FieldTestNormal.pm @@ -29,9 +29,9 @@ use base qw(Bugzilla::Test::Search::FieldTest); use Scalar::Util qw(blessed); use constant CH_OPERATOR => { - changedafter => 'chfieldfrom', - changedbefore => 'chfieldto', - changedto => 'chfieldvalue', + changedafter => 'chfieldfrom', + changedbefore => 'chfieldto', + changedto => 'chfieldvalue', }; use constant EMAIL_FIELDS => qw(assigned_to qa_contact cc reporter commenter); @@ -41,78 +41,79 @@ use constant EMAIL_FIELDS => qw(assigned_to qa_contact cc reporter commenter); # sometimes (like in Bugzilla::Test::Search's direct code) we just want # to create a FieldTestNormal. sub new { - my $class = shift; - my ($first_arg) = @_; - if (blessed $first_arg - and $first_arg->isa('Bugzilla::Test::Search::FieldTest')) - { - my $self = { %$first_arg }; - return bless $self, $class; - } - return $class->SUPER::new(@_); + my $class = shift; + my ($first_arg) = @_; + if (blessed $first_arg and $first_arg->isa('Bugzilla::Test::Search::FieldTest')) + { + my $self = {%$first_arg}; + return bless $self, $class; + } + return $class->SUPER::new(@_); } sub name { - my $self = shift; - my $name = $self->SUPER::name(@_); - return "$name (Normal Params)"; + my $self = shift; + my $name = $self->SUPER::name(@_); + return "$name (Normal Params)"; } sub search_columns { - my $self = shift; - my $field = $self->field; - # For the assigned_to, qa_contact, and reporter fields, have the - # "Normal Params" test check that the _realname columns work - # all by themselves. - if (grep($_ eq $field, EMAIL_FIELDS) && $self->field_object->buglist) { - return ['bug_id', "${field}_realname"] - } - return $self->SUPER::search_columns(@_); + my $self = shift; + my $field = $self->field; + + # For the assigned_to, qa_contact, and reporter fields, have the + # "Normal Params" test check that the _realname columns work + # all by themselves. + if (grep($_ eq $field, EMAIL_FIELDS) && $self->field_object->buglist) { + return ['bug_id', "${field}_realname"]; + } + return $self->SUPER::search_columns(@_); } sub search_params { - my ($self) = @_; - my $field = $self->field; - my $operator = $self->operator; - my $value = $self->translated_value; - if ($operator eq 'anyexact') { - $value = [split ',', $value]; - } + my ($self) = @_; + my $field = $self->field; + my $operator = $self->operator; + my $value = $self->translated_value; + if ($operator eq 'anyexact') { + $value = [split ',', $value]; + } - if (my $ch_param = CH_OPERATOR->{$operator}) { - if ($field eq 'creation_ts') { - $field = '[Bug creation]'; - } - return { chfield => $field, $ch_param => $value }; + if (my $ch_param = CH_OPERATOR->{$operator}) { + if ($field eq 'creation_ts') { + $field = '[Bug creation]'; } + return {chfield => $field, $ch_param => $value}; + } - if ($field eq 'delta_ts' and $operator eq 'greaterthaneq') { - return { chfieldfrom => $value }; - } - if ($field eq 'delta_ts' and $operator eq 'lessthaneq') { - return { chfieldto => $value }; - } + if ($field eq 'delta_ts' and $operator eq 'greaterthaneq') { + return {chfieldfrom => $value}; + } + if ($field eq 'delta_ts' and $operator eq 'lessthaneq') { + return {chfieldto => $value}; + } - if ($field eq 'deadline' and $operator eq 'greaterthaneq') { - return { deadlinefrom => $value }; - } - if ($field eq 'deadline' and $operator eq 'lessthaneq') { - return { deadlineto => $value }; - } + if ($field eq 'deadline' and $operator eq 'greaterthaneq') { + return {deadlinefrom => $value}; + } + if ($field eq 'deadline' and $operator eq 'lessthaneq') { + return {deadlineto => $value}; + } - if (grep { $_ eq $field } EMAIL_FIELDS) { - $field = 'longdesc' if $field eq 'commenter'; - return { - email1 => $value, - "email${field}1" => 1, - emailtype1 => $operator, - # Used to do extra tests on special sorts of email* combinations. - %{ $self->test->{extra_params} || {} }, - }; - } + if (grep { $_ eq $field } EMAIL_FIELDS) { + $field = 'longdesc' if $field eq 'commenter'; + return { + email1 => $value, + "email${field}1" => 1, + emailtype1 => $operator, + + # Used to do extra tests on special sorts of email* combinations. + %{$self->test->{extra_params} || {}}, + }; + } - $field =~ s/\./_/g; - return { $field => $value, "${field}_type" => $operator }; + $field =~ s/\./_/g; + return {$field => $value, "${field}_type" => $operator}; } 1; |