diff options
| -rw-r--r-- | Bugzilla/Bug.pm | 2 | ||||
| -rw-r--r-- | Bugzilla/CGI.pm | 4 | ||||
| -rw-r--r-- | Bugzilla/Search.pm | 2 | ||||
| -rw-r--r-- | Bugzilla/WebService/Bug.pm | 2 | ||||
| -rwxr-xr-x | chart.cgi | 2 | ||||
| -rwxr-xr-x | editflagtypes.cgi | 2 | ||||
| -rw-r--r-- | xt/lib/Bugzilla/Test/Search.pm | 8 |
7 files changed, 10 insertions, 12 deletions
diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm index abc00c298..d3f0023b8 100644 --- a/Bugzilla/Bug.pm +++ b/Bugzilla/Bug.pm @@ -1481,7 +1481,7 @@ sub _check_dependencies { my %deps_in = (dependson => $depends_on || '', blocked => $blocks || ''); - foreach my $type qw(dependson blocked) { + foreach my $type (qw(dependson blocked)) { my @bug_ids = ref($deps_in{$type}) ? @{$deps_in{$type}} : split(/[\s,]+/, $deps_in{$type}); diff --git a/Bugzilla/CGI.pm b/Bugzilla/CGI.pm index 054ba96a0..a9b938c6d 100644 --- a/Bugzilla/CGI.pm +++ b/Bugzilla/CGI.pm @@ -159,9 +159,7 @@ sub clean_search_url { foreach my $num (1,2,3) { # If there's no value in the email field, delete the related fields. if (!$self->param("email$num")) { - foreach my $field qw(type assigned_to reporter qa_contact - cc longdesc) - { + foreach my $field (qw(type assigned_to reporter qa_contact cc longdesc)) { $self->delete("email$field$num"); } } diff --git a/Bugzilla/Search.pm b/Bugzilla/Search.pm index bcbe3a2a5..d81e26c16 100644 --- a/Bugzilla/Search.pm +++ b/Bugzilla/Search.pm @@ -1393,7 +1393,7 @@ sub _special_parse_email { $type = "anyexact" if $type eq "exact"; my @or_charts; - foreach my $field qw(assigned_to reporter cc qa_contact) { + foreach my $field (qw(assigned_to reporter cc qa_contact)) { if ($params->{"email$field$id"}) { push(@or_charts, $field, $type, $email); } diff --git a/Bugzilla/WebService/Bug.pm b/Bugzilla/WebService/Bug.pm index a36eed957..afd235404 100644 --- a/Bugzilla/WebService/Bug.pm +++ b/Bugzilla/WebService/Bug.pm @@ -931,7 +931,7 @@ sub _attachment_to_hash { # creator/attacher require an extra lookup, so we only send them if # the filter wants them. - foreach my $field qw(creator attacher) { + foreach my $field (qw(creator attacher)) { if (filter_wants $filters, $field) { $item->{$field} = $self->type('string', $attach->attacher->login); } @@ -200,7 +200,7 @@ elsif ($action eq "delete") { $series->remove_from_db(); # Remove (sub)categories which no longer have any series. - foreach my $cat qw(category subcategory) { + foreach my $cat (qw(category subcategory)) { my $is_used = $dbh->selectrow_array("SELECT COUNT(*) FROM series WHERE $cat = ?", undef, $series->{"${cat}_id"}); if (!$is_used) { diff --git a/editflagtypes.cgi b/editflagtypes.cgi index 3e3f94f2e..ecfa32ca8 100755 --- a/editflagtypes.cgi +++ b/editflagtypes.cgi @@ -112,7 +112,7 @@ if (my ($category_action) = grep { $_ =~ /^categoryAction-(?:\w+)$/ } $cgi->para my $type = {}; $type->{$_} = $cgi->param($_) foreach $cgi->param(); # Make sure boolean fields are defined, else they fall back to 1. - foreach my $boolean qw(is_active is_requestable is_requesteeble is_multiplicable) { + foreach my $boolean (qw(is_active is_requestable is_requesteeble is_multiplicable)) { $type->{$boolean} ||= 0; } diff --git a/xt/lib/Bugzilla/Test/Search.pm b/xt/lib/Bugzilla/Test/Search.pm index 73bb86dfd..42882bea9 100644 --- a/xt/lib/Bugzilla/Test/Search.pm +++ b/xt/lib/Bugzilla/Test/Search.pm @@ -380,7 +380,7 @@ sub _create_field_values { $values{'keywords'} = create_keyword($number)->name; - foreach my $field qw(assigned_to qa_contact reporter cc) { + foreach my $field (qw(assigned_to qa_contact reporter cc)) { $values{$field} = create_user("$number-$field")->login; } @@ -504,7 +504,7 @@ sub _create_flags { my $flagtypes = _create_flagtypes($number); my %flags; - foreach my $type qw(a b) { + foreach my $type (qw(a b)) { $flags{$type} = _get_flag_values(@_, $flagtypes->{$type}); } return \%flags; @@ -615,9 +615,9 @@ sub _create_one_bug { # These are necessary for the changedfrom tests. my $extra_values = $self->_extra_bug_create_values->{$number}; - foreach my $field qw(comments remaining_time percentage_complete + foreach my $field (qw(comments remaining_time percentage_complete keyword_objects everconfirmed dependson blocked - groups_in classification) + groups_in classification)) { $extra_values->{$field} = $bug->$field; } |