diff options
353 files changed, 430 insertions, 427 deletions
diff --git a/Bugzilla.pm b/Bugzilla.pm index 851b76ebb..bff8dc788 100644 --- a/Bugzilla.pm +++ b/Bugzilla.pm @@ -7,7 +7,7 @@ package Bugzilla; -use 5.10.1; +use 5.14.0; use strict; use warnings; @@ -502,7 +502,6 @@ sub error_mode { $class->request_cache->{error_mode} = $newval; } - # XXX - Once we require Perl 5.10.1, this test can be replaced by //. if (exists $class->request_cache->{error_mode}) { return $class->request_cache->{error_mode}; } @@ -551,7 +550,6 @@ sub usage_mode { $class->request_cache->{usage_mode} = $newval; } - # XXX - Once we require Perl 5.10.1, this test can be replaced by //. if (exists $class->request_cache->{usage_mode}) { return $class->request_cache->{usage_mode}; } diff --git a/Bugzilla/API/1_0/Constants.pm b/Bugzilla/API/1_0/Constants.pm index 44e20124a..d372d410d 100644 --- a/Bugzilla/API/1_0/Constants.pm +++ b/Bugzilla/API/1_0/Constants.pm @@ -7,7 +7,7 @@ package Bugzilla::API::1_0::Constants; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/API/1_0/Resource.pm b/Bugzilla/API/1_0/Resource.pm index 9881d3713..5a26851a5 100644 --- a/Bugzilla/API/1_0/Resource.pm +++ b/Bugzilla/API/1_0/Resource.pm @@ -10,7 +10,7 @@ package Bugzilla::API::1_0::Resource; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/API/1_0/Resource/Bug.pm b/Bugzilla/API/1_0/Resource/Bug.pm index a8565b7a0..dcc73086f 100644 --- a/Bugzilla/API/1_0/Resource/Bug.pm +++ b/Bugzilla/API/1_0/Resource/Bug.pm @@ -7,7 +7,7 @@ package Bugzilla::API::1_0::Resource::Bug; -use 5.10.1; +use 5.14.0; use strict; use warnings; @@ -670,7 +670,7 @@ sub search { my %options = ( fields => ['bug_id'] ); # Find the highest custom field id - my @field_ids = grep(/^f(\d+)$/, keys %$match_params); + my @field_ids = grep(/^f(\d+)$/a, keys %$match_params); my $last_field_id = @field_ids ? max @field_ids + 1 : 1; # Do special search types for certain fields. diff --git a/Bugzilla/API/1_0/Resource/BugUserLastVisit.pm b/Bugzilla/API/1_0/Resource/BugUserLastVisit.pm index aeb52bbb6..20fdb158f 100644 --- a/Bugzilla/API/1_0/Resource/BugUserLastVisit.pm +++ b/Bugzilla/API/1_0/Resource/BugUserLastVisit.pm @@ -7,7 +7,7 @@ package Bugzilla::API::1_0::Resource::BugUserLastVisit; -use 5.10.1; +use 5.14.0; use strict; use warnings; @@ -35,6 +35,7 @@ use constant PUBLIC_METHODS => qw( ); sub REST_RESOURCES { + use re '/a'; return [ # bug-id qr{^/bug_user_last_visit/(\d+)$}, { diff --git a/Bugzilla/API/1_0/Resource/Bugzilla.pm b/Bugzilla/API/1_0/Resource/Bugzilla.pm index fce840c47..f5bb2f417 100644 --- a/Bugzilla/API/1_0/Resource/Bugzilla.pm +++ b/Bugzilla/API/1_0/Resource/Bugzilla.pm @@ -7,7 +7,7 @@ package Bugzilla::API::1_0::Resource::Bugzilla; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/API/1_0/Resource/Classification.pm b/Bugzilla/API/1_0/Resource/Classification.pm index 7a59e381d..28ed2aa95 100644 --- a/Bugzilla/API/1_0/Resource/Classification.pm +++ b/Bugzilla/API/1_0/Resource/Classification.pm @@ -7,7 +7,7 @@ package Bugzilla::API::1_0::Resource::Classification; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/API/1_0/Resource/Component.pm b/Bugzilla/API/1_0/Resource/Component.pm index 13a5f24b5..ba9b27d62 100644 --- a/Bugzilla/API/1_0/Resource/Component.pm +++ b/Bugzilla/API/1_0/Resource/Component.pm @@ -7,7 +7,7 @@ package Bugzilla::API::1_0::Resource::Component; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/API/1_0/Resource/FlagType.pm b/Bugzilla/API/1_0/Resource/FlagType.pm index 969a59532..febce6f71 100644 --- a/Bugzilla/API/1_0/Resource/FlagType.pm +++ b/Bugzilla/API/1_0/Resource/FlagType.pm @@ -7,7 +7,7 @@ package Bugzilla::API::1_0::Resource::FlagType; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/API/1_0/Resource/Group.pm b/Bugzilla/API/1_0/Resource/Group.pm index 4efd7b476..43a2521fb 100644 --- a/Bugzilla/API/1_0/Resource/Group.pm +++ b/Bugzilla/API/1_0/Resource/Group.pm @@ -7,7 +7,7 @@ package Bugzilla::API::1_0::Resource::Group; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/API/1_0/Resource/Product.pm b/Bugzilla/API/1_0/Resource/Product.pm index 6a5168608..d3576a734 100644 --- a/Bugzilla/API/1_0/Resource/Product.pm +++ b/Bugzilla/API/1_0/Resource/Product.pm @@ -7,7 +7,7 @@ package Bugzilla::API::1_0::Resource::Product; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/API/1_0/Resource/User.pm b/Bugzilla/API/1_0/Resource/User.pm index ec81cf66d..a214bd81f 100644 --- a/Bugzilla/API/1_0/Resource/User.pm +++ b/Bugzilla/API/1_0/Resource/User.pm @@ -7,7 +7,7 @@ package Bugzilla::API::1_0::Resource::User; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/API/1_0/Server.pm b/Bugzilla/API/1_0/Server.pm index af66a4f66..a443cd514 100644 --- a/Bugzilla/API/1_0/Server.pm +++ b/Bugzilla/API/1_0/Server.pm @@ -7,7 +7,7 @@ package Bugzilla::API::1_0::Server; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/API/1_0/Util.pm b/Bugzilla/API/1_0/Util.pm index afdde314e..e2c7b1f1f 100644 --- a/Bugzilla/API/1_0/Util.pm +++ b/Bugzilla/API/1_0/Util.pm @@ -7,7 +7,7 @@ package Bugzilla::API::1_0::Util; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/API/Server.pm b/Bugzilla/API/Server.pm index 2d680db28..e3bf1ea71 100644 --- a/Bugzilla/API/Server.pm +++ b/Bugzilla/API/Server.pm @@ -7,7 +7,7 @@ package Bugzilla::API::Server; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Attachment.pm b/Bugzilla/Attachment.pm index 1f2bddda5..78334ec18 100644 --- a/Bugzilla/Attachment.pm +++ b/Bugzilla/Attachment.pm @@ -7,7 +7,7 @@ package Bugzilla::Attachment; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Attachment/PatchReader.pm b/Bugzilla/Attachment/PatchReader.pm index 202f4b4fd..1cc3f0bca 100644 --- a/Bugzilla/Attachment/PatchReader.pm +++ b/Bugzilla/Attachment/PatchReader.pm @@ -7,7 +7,7 @@ package Bugzilla::Attachment::PatchReader; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Auth.pm b/Bugzilla/Auth.pm index c830f0506..399f68d24 100644 --- a/Bugzilla/Auth.pm +++ b/Bugzilla/Auth.pm @@ -7,7 +7,7 @@ package Bugzilla::Auth; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Auth/Login.pm b/Bugzilla/Auth/Login.pm index a5f089777..cd075a3cf 100644 --- a/Bugzilla/Auth/Login.pm +++ b/Bugzilla/Auth/Login.pm @@ -7,7 +7,7 @@ package Bugzilla::Auth::Login; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Auth/Login/APIKey.pm b/Bugzilla/Auth/Login/APIKey.pm index 63e35578a..c7829f1ce 100644 --- a/Bugzilla/Auth/Login/APIKey.pm +++ b/Bugzilla/Auth/Login/APIKey.pm @@ -7,7 +7,7 @@ package Bugzilla::Auth::Login::APIKey; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Auth/Login/CGI.pm b/Bugzilla/Auth/Login/CGI.pm index 6003d62a5..d2934e6d0 100644 --- a/Bugzilla/Auth/Login/CGI.pm +++ b/Bugzilla/Auth/Login/CGI.pm @@ -7,7 +7,7 @@ package Bugzilla::Auth::Login::CGI; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Auth/Login/Cookie.pm b/Bugzilla/Auth/Login/Cookie.pm index 3139e127b..b67fb73db 100644 --- a/Bugzilla/Auth/Login/Cookie.pm +++ b/Bugzilla/Auth/Login/Cookie.pm @@ -7,7 +7,7 @@ package Bugzilla::Auth::Login::Cookie; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Auth/Login/Env.pm b/Bugzilla/Auth/Login/Env.pm index 653df2bb3..2ff81e82e 100644 --- a/Bugzilla/Auth/Login/Env.pm +++ b/Bugzilla/Auth/Login/Env.pm @@ -7,7 +7,7 @@ package Bugzilla::Auth::Login::Env; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Auth/Login/Stack.pm b/Bugzilla/Auth/Login/Stack.pm index dc35998e4..a7c24a3fb 100644 --- a/Bugzilla/Auth/Login/Stack.pm +++ b/Bugzilla/Auth/Login/Stack.pm @@ -7,7 +7,7 @@ package Bugzilla::Auth::Login::Stack; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Auth/Persist/Cookie.pm b/Bugzilla/Auth/Persist/Cookie.pm index 904de3699..69f6e9c60 100644 --- a/Bugzilla/Auth/Persist/Cookie.pm +++ b/Bugzilla/Auth/Persist/Cookie.pm @@ -7,7 +7,7 @@ package Bugzilla::Auth::Persist::Cookie; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Auth/Verify.pm b/Bugzilla/Auth/Verify.pm index 9dc83273b..ef5b749b1 100644 --- a/Bugzilla/Auth/Verify.pm +++ b/Bugzilla/Auth/Verify.pm @@ -7,7 +7,7 @@ package Bugzilla::Auth::Verify; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Auth/Verify/DB.pm b/Bugzilla/Auth/Verify/DB.pm index 28a9310c9..fd11d1960 100644 --- a/Bugzilla/Auth/Verify/DB.pm +++ b/Bugzilla/Auth/Verify/DB.pm @@ -7,7 +7,7 @@ package Bugzilla::Auth::Verify::DB; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Auth/Verify/LDAP.pm b/Bugzilla/Auth/Verify/LDAP.pm index e37f55793..cd2e64370 100644 --- a/Bugzilla/Auth/Verify/LDAP.pm +++ b/Bugzilla/Auth/Verify/LDAP.pm @@ -7,7 +7,7 @@ package Bugzilla::Auth::Verify::LDAP; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Auth/Verify/RADIUS.pm b/Bugzilla/Auth/Verify/RADIUS.pm index 283d9b466..60be52a07 100644 --- a/Bugzilla/Auth/Verify/RADIUS.pm +++ b/Bugzilla/Auth/Verify/RADIUS.pm @@ -7,7 +7,7 @@ package Bugzilla::Auth::Verify::RADIUS; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Auth/Verify/Stack.pm b/Bugzilla/Auth/Verify/Stack.pm index 3e5db3cec..2e36388a6 100644 --- a/Bugzilla/Auth/Verify/Stack.pm +++ b/Bugzilla/Auth/Verify/Stack.pm @@ -7,7 +7,7 @@ package Bugzilla::Auth::Verify::Stack; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm index 37f492337..a41e4f1aa 100644 --- a/Bugzilla/Bug.pm +++ b/Bugzilla/Bug.pm @@ -7,7 +7,7 @@ package Bugzilla::Bug; -use 5.10.1; +use 5.14.0; use strict; use warnings; @@ -305,6 +305,9 @@ sub new { my $class = ref($invocant) || $invocant; my $param = shift; + # Let's not be abused by pseudo-numbers. + use re '/a'; + # Remove leading "#" mark if we've just been passed an id. if (!ref $param && $param =~ /^#(\d+)$/) { $param = $1; @@ -542,6 +545,9 @@ sub _extract_bug_ids { my $comments = shift; my @bug_ids; + # Let's not be abused by pseudo-numbers. + use re '/a'; + my $params = Bugzilla->params; my @urlbases = ($params->{'urlbase'}); push(@urlbases, $params->{'sslbase'}) if $params->{'sslbase'}; @@ -1735,7 +1741,7 @@ sub _check_dependencies { } } # Replace all aliases by their corresponding bug ID. - @bug_ids = map { $_ =~ /^(\d+)$/ ? $1 : $invocant->check($_, $type)->id } @bug_ids; + @bug_ids = map { $_ =~ /^(\d+)$/a ? $1 : $invocant->check($_, $type)->id } @bug_ids; $deps_in{$type} = \@bug_ids; } @@ -3694,8 +3700,6 @@ sub comments { # equivalent for characters above U+FFFF as MySQL older than 5.5.3 # cannot store them, see Bugzilla::Comment::_check_thetext(). if ($is_mysql) { - # Perl 5.13.8 and older complain about non-characters. - no warnings 'utf8'; $comment->{thetext} =~ s/\x{FDD0}\[U\+((?:[1-9A-F]|10)[0-9A-F]{4})\]\x{FDD1}/chr(hex $1)/eg } } diff --git a/Bugzilla/BugMail.pm b/Bugzilla/BugMail.pm index bfb57f158..5ab021869 100644 --- a/Bugzilla/BugMail.pm +++ b/Bugzilla/BugMail.pm @@ -7,7 +7,7 @@ package Bugzilla::BugMail; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/BugUrl.pm b/Bugzilla/BugUrl.pm index 1d75fe8f1..818253c69 100644 --- a/Bugzilla/BugUrl.pm +++ b/Bugzilla/BugUrl.pm @@ -7,7 +7,7 @@ package Bugzilla::BugUrl; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/BugUrl/Bugzilla.pm b/Bugzilla/BugUrl/Bugzilla.pm index 402ff1509..647181202 100644 --- a/Bugzilla/BugUrl/Bugzilla.pm +++ b/Bugzilla/BugUrl/Bugzilla.pm @@ -7,7 +7,7 @@ package Bugzilla::BugUrl::Bugzilla; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/BugUrl/Bugzilla/Local.pm b/Bugzilla/BugUrl/Bugzilla/Local.pm index 7b9cb6a4f..e60cb04fc 100644 --- a/Bugzilla/BugUrl/Bugzilla/Local.pm +++ b/Bugzilla/BugUrl/Bugzilla/Local.pm @@ -7,7 +7,7 @@ package Bugzilla::BugUrl::Bugzilla::Local; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/BugUrl/Debian.pm b/Bugzilla/BugUrl/Debian.pm index b726b0b5a..2067c9eb6 100644 --- a/Bugzilla/BugUrl/Debian.pm +++ b/Bugzilla/BugUrl/Debian.pm @@ -7,7 +7,7 @@ package Bugzilla::BugUrl::Debian; -use 5.10.1; +use 5.14.0; use strict; use warnings; @@ -28,8 +28,8 @@ sub should_handle { return ((lc($uri->authority) eq 'bugs.debian.org' or lc($uri->authority) eq 'debbugs.gnu.org') and (($uri->path =~ /bugreport\.cgi$/ - and $uri->query_param('bug') =~ m|^\d+$|) - or $uri->path =~ m|^/\d+$|)) ? 1 : 0; + and $uri->query_param('bug') =~ m|^\d+$|a) + or $uri->path =~ m|^/\d+$|a)) ? 1 : 0; } sub _check_value { @@ -39,7 +39,7 @@ sub _check_value { # This is the shortest standard URL form for Debian BTS URLs, # and so we reduce all URLs to this. - $uri->path =~ m|^/(\d+)$| || $uri->query_param('bug') =~ m|^(\d+)$|; + $uri->path =~ m|^/(\d+)$|a || $uri->query_param('bug') =~ m|^(\d+)$|a; $uri = new URI('https://' . $uri->authority . '/' . $1); return $uri; diff --git a/Bugzilla/BugUrl/GitHub.pm b/Bugzilla/BugUrl/GitHub.pm index f14f1d6b0..19ce5ef6b 100644 --- a/Bugzilla/BugUrl/GitHub.pm +++ b/Bugzilla/BugUrl/GitHub.pm @@ -7,7 +7,7 @@ package Bugzilla::BugUrl::GitHub; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/BugUrl/Google.pm b/Bugzilla/BugUrl/Google.pm index 71a9c46fb..4b5df7a87 100644 --- a/Bugzilla/BugUrl/Google.pm +++ b/Bugzilla/BugUrl/Google.pm @@ -7,7 +7,7 @@ package Bugzilla::BugUrl::Google; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/BugUrl/JIRA.pm b/Bugzilla/BugUrl/JIRA.pm index e9d2a2d2a..d117b0255 100644 --- a/Bugzilla/BugUrl/JIRA.pm +++ b/Bugzilla/BugUrl/JIRA.pm @@ -7,7 +7,7 @@ package Bugzilla::BugUrl::JIRA; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/BugUrl/Launchpad.pm b/Bugzilla/BugUrl/Launchpad.pm index 0362747a2..36a911130 100644 --- a/Bugzilla/BugUrl/Launchpad.pm +++ b/Bugzilla/BugUrl/Launchpad.pm @@ -7,7 +7,7 @@ package Bugzilla::BugUrl::Launchpad; -use 5.10.1; +use 5.14.0; use strict; use warnings; @@ -25,7 +25,7 @@ sub should_handle { # https://launchpad.net/bugs/1234 # All variations end with either "/bugs/1234" or "/+bug/1234" return ($uri->authority =~ /launchpad\.net$/ - and $uri->path =~ m|bugs?/\d+$|) ? 1 : 0; + and $uri->path =~ m|bugs?/\d+$|a) ? 1 : 0; } sub _check_value { @@ -35,7 +35,7 @@ sub _check_value { # This is the shortest standard URL form for Launchpad bugs, # and so we reduce all URLs to this. - $uri->path =~ m|bugs?/(\d+)$|; + $uri->path =~ m|bugs?/(\d+)$|a; $uri = new URI("https://launchpad.net/bugs/$1"); return $uri; diff --git a/Bugzilla/BugUrl/MantisBT.pm b/Bugzilla/BugUrl/MantisBT.pm index 60d3b578e..f90e3f67b 100644 --- a/Bugzilla/BugUrl/MantisBT.pm +++ b/Bugzilla/BugUrl/MantisBT.pm @@ -7,7 +7,7 @@ package Bugzilla::BugUrl::MantisBT; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/BugUrl/SourceForge.pm b/Bugzilla/BugUrl/SourceForge.pm index 4a330f34b..c29867362 100644 --- a/Bugzilla/BugUrl/SourceForge.pm +++ b/Bugzilla/BugUrl/SourceForge.pm @@ -7,7 +7,7 @@ package Bugzilla::BugUrl::SourceForge; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/BugUrl/Trac.pm b/Bugzilla/BugUrl/Trac.pm index fe74abf33..edcd1c453 100644 --- a/Bugzilla/BugUrl/Trac.pm +++ b/Bugzilla/BugUrl/Trac.pm @@ -7,7 +7,7 @@ package Bugzilla::BugUrl::Trac; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/BugUserLastVisit.pm b/Bugzilla/BugUserLastVisit.pm index d043b121a..1b4f90abf 100644 --- a/Bugzilla/BugUserLastVisit.pm +++ b/Bugzilla/BugUserLastVisit.pm @@ -7,7 +7,7 @@ package Bugzilla::BugUserLastVisit; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/CGI.pm b/Bugzilla/CGI.pm index 25ee0acbe..8d605b0d9 100644 --- a/Bugzilla/CGI.pm +++ b/Bugzilla/CGI.pm @@ -7,7 +7,7 @@ package Bugzilla::CGI; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Chart.pm b/Bugzilla/Chart.pm index 3c69006aa..d0a1312ad 100644 --- a/Bugzilla/Chart.pm +++ b/Bugzilla/Chart.pm @@ -13,7 +13,7 @@ # the same points. package Bugzilla::Chart; -use 5.10.1; +use 5.14.0; use strict; use warnings; @@ -59,7 +59,7 @@ sub init { # >=1&labelgt=Grand+Total foreach my $param ($cgi->param()) { # Store all the lines - if ($param =~ /^line(\d+)$/) { + if ($param =~ /^line(\d+)$/a) { foreach my $series_id ($cgi->param($param)) { detaint_natural($series_id) || ThrowCodeError("invalid_series_id"); @@ -69,7 +69,7 @@ sub init { } # Store all the labels - if ($param =~ /^label(\d+)$/) { + if ($param =~ /^label(\d+)$/a) { $self->{'labels'}[$1] = $cgi->param($param); } } diff --git a/Bugzilla/Classification.pm b/Bugzilla/Classification.pm index 09f71baaf..7f62e1ffa 100644 --- a/Bugzilla/Classification.pm +++ b/Bugzilla/Classification.pm @@ -7,7 +7,7 @@ package Bugzilla::Classification; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Comment.pm b/Bugzilla/Comment.pm index 7d7ac0d80..d995d4509 100644 --- a/Bugzilla/Comment.pm +++ b/Bugzilla/Comment.pm @@ -7,7 +7,7 @@ package Bugzilla::Comment; -use 5.10.1; +use 5.14.0; use strict; use warnings; @@ -447,8 +447,6 @@ sub _check_thetext { # XXX - Once we use utf8mb4 for comments, this hack for MySQL can go away. state $is_mysql = Bugzilla->dbh->isa('Bugzilla::DB::Mysql') ? 1 : 0; if ($is_mysql) { - # Perl 5.13.8 and older complain about non-characters. - no warnings 'utf8'; $thetext =~ s/([\x{10000}-\x{10FFFF}])/"\x{FDD0}[" . uc(sprintf('U+%04x', ord($1))) . "]\x{FDD1}"/eg; } diff --git a/Bugzilla/Comment/TagWeights.pm b/Bugzilla/Comment/TagWeights.pm index 7dba53e34..f4aa519a3 100644 --- a/Bugzilla/Comment/TagWeights.pm +++ b/Bugzilla/Comment/TagWeights.pm @@ -7,7 +7,7 @@ package Bugzilla::Comment::TagWeights; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Component.pm b/Bugzilla/Component.pm index 3e50dab80..22c424599 100644 --- a/Bugzilla/Component.pm +++ b/Bugzilla/Component.pm @@ -7,7 +7,7 @@ package Bugzilla::Component; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Config.pm b/Bugzilla/Config.pm index 64f228915..7a7ba3a3e 100644 --- a/Bugzilla/Config.pm +++ b/Bugzilla/Config.pm @@ -7,7 +7,7 @@ package Bugzilla::Config; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Config/Admin.pm b/Bugzilla/Config/Admin.pm index 41d929298..c21ae5310 100644 --- a/Bugzilla/Config/Admin.pm +++ b/Bugzilla/Config/Admin.pm @@ -7,7 +7,7 @@ package Bugzilla::Config::Admin; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Config/Advanced.pm b/Bugzilla/Config/Advanced.pm index 8356c3361..75afe7b22 100644 --- a/Bugzilla/Config/Advanced.pm +++ b/Bugzilla/Config/Advanced.pm @@ -7,7 +7,7 @@ package Bugzilla::Config::Advanced; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Config/Attachment.pm b/Bugzilla/Config/Attachment.pm index 5bf854293..daa844ba5 100644 --- a/Bugzilla/Config/Attachment.pm +++ b/Bugzilla/Config/Attachment.pm @@ -7,7 +7,7 @@ package Bugzilla::Config::Attachment; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Config/Auth.pm b/Bugzilla/Config/Auth.pm index 3c9ee31f2..219e834ee 100644 --- a/Bugzilla/Config/Auth.pm +++ b/Bugzilla/Config/Auth.pm @@ -7,7 +7,7 @@ package Bugzilla::Config::Auth; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Config/BugChange.pm b/Bugzilla/Config/BugChange.pm index 6126b7f35..b8a80dd94 100644 --- a/Bugzilla/Config/BugChange.pm +++ b/Bugzilla/Config/BugChange.pm @@ -7,7 +7,7 @@ package Bugzilla::Config::BugChange; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Config/BugFields.pm b/Bugzilla/Config/BugFields.pm index ef2faa64b..f6c20cd12 100644 --- a/Bugzilla/Config/BugFields.pm +++ b/Bugzilla/Config/BugFields.pm @@ -7,7 +7,7 @@ package Bugzilla::Config::BugFields; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Config/Common.pm b/Bugzilla/Config/Common.pm index 6e8ae7b61..860977b65 100644 --- a/Bugzilla/Config/Common.pm +++ b/Bugzilla/Config/Common.pm @@ -7,7 +7,7 @@ package Bugzilla::Config::Common; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Config/Core.pm b/Bugzilla/Config/Core.pm index de375e448..c9a291d4c 100644 --- a/Bugzilla/Config/Core.pm +++ b/Bugzilla/Config/Core.pm @@ -7,7 +7,7 @@ package Bugzilla::Config::Core; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Config/General.pm b/Bugzilla/Config/General.pm index 8513a1f02..1a03995f3 100644 --- a/Bugzilla/Config/General.pm +++ b/Bugzilla/Config/General.pm @@ -7,7 +7,7 @@ package Bugzilla::Config::General; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Config/GroupSecurity.pm b/Bugzilla/Config/GroupSecurity.pm index ec172216b..ba81a468e 100644 --- a/Bugzilla/Config/GroupSecurity.pm +++ b/Bugzilla/Config/GroupSecurity.pm @@ -7,7 +7,7 @@ package Bugzilla::Config::GroupSecurity; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Config/LDAP.pm b/Bugzilla/Config/LDAP.pm index 0bc8240df..1970b5791 100644 --- a/Bugzilla/Config/LDAP.pm +++ b/Bugzilla/Config/LDAP.pm @@ -7,7 +7,7 @@ package Bugzilla::Config::LDAP; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Config/MTA.pm b/Bugzilla/Config/MTA.pm index 467bdab3f..37f61aa20 100644 --- a/Bugzilla/Config/MTA.pm +++ b/Bugzilla/Config/MTA.pm @@ -7,7 +7,7 @@ package Bugzilla::Config::MTA; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Config/Memcached.pm b/Bugzilla/Config/Memcached.pm index 292803d86..e45c33da1 100644 --- a/Bugzilla/Config/Memcached.pm +++ b/Bugzilla/Config/Memcached.pm @@ -7,7 +7,7 @@ package Bugzilla::Config::Memcached; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Config/Query.pm b/Bugzilla/Config/Query.pm index f18bb90df..5e0d72e33 100644 --- a/Bugzilla/Config/Query.pm +++ b/Bugzilla/Config/Query.pm @@ -7,7 +7,7 @@ package Bugzilla::Config::Query; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Config/RADIUS.pm b/Bugzilla/Config/RADIUS.pm index 8e30b07a9..ddc8d9524 100644 --- a/Bugzilla/Config/RADIUS.pm +++ b/Bugzilla/Config/RADIUS.pm @@ -7,7 +7,7 @@ package Bugzilla::Config::RADIUS; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Config/ShadowDB.pm b/Bugzilla/Config/ShadowDB.pm index 5dbbb5202..20212629c 100644 --- a/Bugzilla/Config/ShadowDB.pm +++ b/Bugzilla/Config/ShadowDB.pm @@ -7,7 +7,7 @@ package Bugzilla::Config::ShadowDB; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Config/UserMatch.pm b/Bugzilla/Config/UserMatch.pm index 3f74a7c44..c8b6f8dc3 100644 --- a/Bugzilla/Config/UserMatch.pm +++ b/Bugzilla/Config/UserMatch.pm @@ -7,7 +7,7 @@ package Bugzilla::Config::UserMatch; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Constants.pm b/Bugzilla/Constants.pm index 6a469b376..6e8a469c5 100644 --- a/Bugzilla/Constants.pm +++ b/Bugzilla/Constants.pm @@ -7,7 +7,7 @@ package Bugzilla::Constants; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/DB.pm b/Bugzilla/DB.pm index 96a68af03..6832e0ce7 100644 --- a/Bugzilla/DB.pm +++ b/Bugzilla/DB.pm @@ -7,7 +7,7 @@ package Bugzilla::DB; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/DB/Mysql.pm b/Bugzilla/DB/Mysql.pm index 402e9c58b..858b58fee 100644 --- a/Bugzilla/DB/Mysql.pm +++ b/Bugzilla/DB/Mysql.pm @@ -21,7 +21,7 @@ For interface details see L<Bugzilla::DB> and L<DBI>. package Bugzilla::DB::Mysql; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/DB/Oracle.pm b/Bugzilla/DB/Oracle.pm index 51678dec9..e863bac42 100644 --- a/Bugzilla/DB/Oracle.pm +++ b/Bugzilla/DB/Oracle.pm @@ -21,7 +21,7 @@ For interface details see L<Bugzilla::DB> and L<DBI>. package Bugzilla::DB::Oracle; -use 5.10.1; +use 5.14.0; use strict; use warnings; @@ -719,7 +719,7 @@ sub _get_create_trigger_ddl { package Bugzilla::DB::Oracle::st; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/DB/Pg.pm b/Bugzilla/DB/Pg.pm index ac9ec6309..9ef7f77f1 100644 --- a/Bugzilla/DB/Pg.pm +++ b/Bugzilla/DB/Pg.pm @@ -21,7 +21,7 @@ For interface details see L<Bugzilla::DB> and L<DBI>. package Bugzilla::DB::Pg; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/DB/Schema.pm b/Bugzilla/DB/Schema.pm index d770f2358..ca3839ca6 100644 --- a/Bugzilla/DB/Schema.pm +++ b/Bugzilla/DB/Schema.pm @@ -15,7 +15,7 @@ package Bugzilla::DB::Schema; # ########################################################################### -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/DB/Schema/Mysql.pm b/Bugzilla/DB/Schema/Mysql.pm index db01e971d..59066bdc4 100644 --- a/Bugzilla/DB/Schema/Mysql.pm +++ b/Bugzilla/DB/Schema/Mysql.pm @@ -13,7 +13,7 @@ package Bugzilla::DB::Schema::Mysql; # ############################################################################### -use 5.10.1; +use 5.14.0; use strict; use warnings; @@ -311,7 +311,7 @@ sub column_info_to_column { $default = 0 if $default =~ /^0\.0+$/; # If we're not a number, we're a string and need to be # quoted. - $default = $dbh->quote($default) if !($default =~ /^(-)?(\d+)(.\d+)?$/); + $default = $dbh->quote($default) if !($default =~ /^(-)?(\d+)(\.\d+)?$/a); $column->{DEFAULT} = $default; } } diff --git a/Bugzilla/DB/Schema/Oracle.pm b/Bugzilla/DB/Schema/Oracle.pm index 8fb5479b1..c3868ad44 100644 --- a/Bugzilla/DB/Schema/Oracle.pm +++ b/Bugzilla/DB/Schema/Oracle.pm @@ -13,7 +13,7 @@ package Bugzilla::DB::Schema::Oracle; # ############################################################################### -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/DB/Schema/Pg.pm b/Bugzilla/DB/Schema/Pg.pm index dd8531927..c82c373b7 100644 --- a/Bugzilla/DB/Schema/Pg.pm +++ b/Bugzilla/DB/Schema/Pg.pm @@ -13,7 +13,7 @@ package Bugzilla::DB::Schema::Pg; # ############################################################################### -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/DB/Schema/Sqlite.pm b/Bugzilla/DB/Schema/Sqlite.pm index ccdbfd8aa..935bf8e37 100644 --- a/Bugzilla/DB/Schema/Sqlite.pm +++ b/Bugzilla/DB/Schema/Sqlite.pm @@ -7,7 +7,7 @@ package Bugzilla::DB::Schema::Sqlite; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/DB/Sqlite.pm b/Bugzilla/DB/Sqlite.pm index 0cdfa3477..e3cc93a82 100644 --- a/Bugzilla/DB/Sqlite.pm +++ b/Bugzilla/DB/Sqlite.pm @@ -7,7 +7,7 @@ package Bugzilla::DB::Sqlite; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Error.pm b/Bugzilla/Error.pm index 864024794..394e0a5e5 100644 --- a/Bugzilla/Error.pm +++ b/Bugzilla/Error.pm @@ -7,7 +7,7 @@ package Bugzilla::Error; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Extension.pm b/Bugzilla/Extension.pm index e24ceb9eb..fcd41ae86 100644 --- a/Bugzilla/Extension.pm +++ b/Bugzilla/Extension.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Field.pm b/Bugzilla/Field.pm index d0e392243..e9f9e1b2d 100644 --- a/Bugzilla/Field.pm +++ b/Bugzilla/Field.pm @@ -57,7 +57,7 @@ in addition to what is documented here. package Bugzilla::Field; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Field/Choice.pm b/Bugzilla/Field/Choice.pm index a66f69cee..140feb46e 100644 --- a/Bugzilla/Field/Choice.pm +++ b/Bugzilla/Field/Choice.pm @@ -7,7 +7,7 @@ package Bugzilla::Field::Choice; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Field/ChoiceInterface.pm b/Bugzilla/Field/ChoiceInterface.pm index 9ac508dc0..bae62c459 100644 --- a/Bugzilla/Field/ChoiceInterface.pm +++ b/Bugzilla/Field/ChoiceInterface.pm @@ -7,7 +7,7 @@ package Bugzilla::Field::ChoiceInterface; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Flag.pm b/Bugzilla/Flag.pm index bf37f2a9a..3d9540a94 100644 --- a/Bugzilla/Flag.pm +++ b/Bugzilla/Flag.pm @@ -7,7 +7,7 @@ package Bugzilla::Flag; -use 5.10.1; +use 5.14.0; use strict; use warnings; @@ -843,11 +843,11 @@ sub extract_flags_from_cgi { } # Extract a list of flag type IDs from field names. - my @flagtype_ids = map(/^flag_type-(\d+)$/ ? $1 : (), $cgi->param()); + my @flagtype_ids = map(/^flag_type-(\d+)$/a ? $1 : (), $cgi->param()); @flagtype_ids = grep($cgi->param("flag_type-$_") ne 'X', @flagtype_ids); # Extract a list of existing flag IDs. - my @flag_ids = map(/^flag-(\d+)$/ ? $1 : (), $cgi->param()); + my @flag_ids = map(/^flag-(\d+)$/a ? $1 : (), $cgi->param()); return ([], []) unless (scalar(@flagtype_ids) || scalar(@flag_ids)); @@ -986,7 +986,7 @@ sub multi_extract_flags_from_cgi { } # Extract a list of flag type IDs from field names. - my @flagtype_ids = map(/^flag_type-(\d+)$/ ? $1 : (), $cgi->param()); + my @flagtype_ids = map(/^flag_type-(\d+)$/a ? $1 : (), $cgi->param()); my (@new_flags, @flags); diff --git a/Bugzilla/FlagType.pm b/Bugzilla/FlagType.pm index 72b3f64c1..cbf831bc5 100644 --- a/Bugzilla/FlagType.pm +++ b/Bugzilla/FlagType.pm @@ -7,7 +7,7 @@ package Bugzilla::FlagType; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Group.pm b/Bugzilla/Group.pm index f7a50f7f1..9ea851c20 100644 --- a/Bugzilla/Group.pm +++ b/Bugzilla/Group.pm @@ -7,7 +7,7 @@ package Bugzilla::Group; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Hook.pm b/Bugzilla/Hook.pm index 9206cc993..8d0976d9c 100644 --- a/Bugzilla/Hook.pm +++ b/Bugzilla/Hook.pm @@ -7,7 +7,7 @@ package Bugzilla::Hook; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Install.pm b/Bugzilla/Install.pm index d02c43d2f..e1ed65c36 100644 --- a/Bugzilla/Install.pm +++ b/Bugzilla/Install.pm @@ -15,7 +15,7 @@ package Bugzilla::Install; # make those assumptions, then it should go into one of the # packages under the Bugzilla::Install namespace. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Install/DB.pm b/Bugzilla/Install/DB.pm index 8af0eeb12..a6ca1e90f 100644 --- a/Bugzilla/Install/DB.pm +++ b/Bugzilla/Install/DB.pm @@ -10,7 +10,7 @@ package Bugzilla::Install::DB; # NOTE: This package may "use" any modules that it likes, # localconfig is available, and params are up to date. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Install/Filesystem.pm b/Bugzilla/Install/Filesystem.pm index 679646df9..bbad2c467 100644 --- a/Bugzilla/Install/Filesystem.pm +++ b/Bugzilla/Install/Filesystem.pm @@ -15,7 +15,7 @@ package Bugzilla::Install::Filesystem; # * Files do not have the correct permissions. # * The database does not exist. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Install/Localconfig.pm b/Bugzilla/Install/Localconfig.pm index 6ff3f5e6c..4a3b09f83 100644 --- a/Bugzilla/Install/Localconfig.pm +++ b/Bugzilla/Install/Localconfig.pm @@ -15,7 +15,7 @@ package Bugzilla::Install::Localconfig; # * Files do not have the correct permissions # * The database is not up to date -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Install/Requirements.pm b/Bugzilla/Install/Requirements.pm index 924686f0a..af9152cf9 100644 --- a/Bugzilla/Install/Requirements.pm +++ b/Bugzilla/Install/Requirements.pm @@ -13,7 +13,7 @@ package Bugzilla::Install::Requirements; # Subroutines may "require" and "import" from modules, but they # MUST NOT "use." -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Install/Util.pm b/Bugzilla/Install/Util.pm index 82752b961..90ef2d4e3 100644 --- a/Bugzilla/Install/Util.pm +++ b/Bugzilla/Install/Util.pm @@ -11,7 +11,7 @@ package Bugzilla::Install::Util; # module may require *only* Bugzilla::Constants and built-in # perl modules. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Job/BugMail.pm b/Bugzilla/Job/BugMail.pm index b4887c470..96ccb719e 100644 --- a/Bugzilla/Job/BugMail.pm +++ b/Bugzilla/Job/BugMail.pm @@ -7,7 +7,7 @@ package Bugzilla::Job::BugMail; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Job/Mailer.pm b/Bugzilla/Job/Mailer.pm index 0f0e9c71f..f4b9baaa3 100644 --- a/Bugzilla/Job/Mailer.pm +++ b/Bugzilla/Job/Mailer.pm @@ -7,7 +7,7 @@ package Bugzilla::Job::Mailer; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/JobQueue.pm b/Bugzilla/JobQueue.pm index d5ceda8e9..0a5bcb116 100644 --- a/Bugzilla/JobQueue.pm +++ b/Bugzilla/JobQueue.pm @@ -7,7 +7,7 @@ package Bugzilla::JobQueue; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/JobQueue/Runner.pm b/Bugzilla/JobQueue/Runner.pm index 2367f8d77..113193cd8 100644 --- a/Bugzilla/JobQueue/Runner.pm +++ b/Bugzilla/JobQueue/Runner.pm @@ -11,7 +11,7 @@ package Bugzilla::JobQueue::Runner; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Keyword.pm b/Bugzilla/Keyword.pm index ef044a0c5..d2e1f91eb 100644 --- a/Bugzilla/Keyword.pm +++ b/Bugzilla/Keyword.pm @@ -7,7 +7,7 @@ package Bugzilla::Keyword; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/MIME.pm b/Bugzilla/MIME.pm index 20e667d83..0916133a0 100644 --- a/Bugzilla/MIME.pm +++ b/Bugzilla/MIME.pm @@ -9,7 +9,7 @@ package Bugzilla::MIME; use strict; use warnings; -use 5.10.1; +use 5.14.0; use parent qw(Email::MIME); use Encode qw(encode); diff --git a/Bugzilla/Mailer.pm b/Bugzilla/Mailer.pm index 20175db15..c35f12ef8 100644 --- a/Bugzilla/Mailer.pm +++ b/Bugzilla/Mailer.pm @@ -7,7 +7,7 @@ package Bugzilla::Mailer; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Markdown.pm b/Bugzilla/Markdown.pm index f73e25014..212f1e093 100644 --- a/Bugzilla/Markdown.pm +++ b/Bugzilla/Markdown.pm @@ -7,7 +7,7 @@ package Bugzilla::Markdown; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Memcached.pm b/Bugzilla/Memcached.pm index a468c7575..8a367ea25 100644 --- a/Bugzilla/Memcached.pm +++ b/Bugzilla/Memcached.pm @@ -7,7 +7,7 @@ package Bugzilla::Memcached; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Migrate.pm b/Bugzilla/Migrate.pm index 6ecdb5c0d..5a2defe15 100644 --- a/Bugzilla/Migrate.pm +++ b/Bugzilla/Migrate.pm @@ -7,7 +7,7 @@ package Bugzilla::Migrate; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Migrate/Gnats.pm b/Bugzilla/Migrate/Gnats.pm index 5feda4b8d..f16faf78c 100644 --- a/Bugzilla/Migrate/Gnats.pm +++ b/Bugzilla/Migrate/Gnats.pm @@ -7,7 +7,7 @@ package Bugzilla::Migrate::Gnats; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Milestone.pm b/Bugzilla/Milestone.pm index 9cee52248..2fd68dfba 100644 --- a/Bugzilla/Milestone.pm +++ b/Bugzilla/Milestone.pm @@ -7,7 +7,7 @@ package Bugzilla::Milestone; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Object.pm b/Bugzilla/Object.pm index d43c8ca34..6e66267f8 100644 --- a/Bugzilla/Object.pm +++ b/Bugzilla/Object.pm @@ -7,7 +7,7 @@ package Bugzilla::Object; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Product.pm b/Bugzilla/Product.pm index 09ca61c69..592653afd 100644 --- a/Bugzilla/Product.pm +++ b/Bugzilla/Product.pm @@ -7,7 +7,7 @@ package Bugzilla::Product; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/RNG.pm b/Bugzilla/RNG.pm index 96e442fa0..69693c722 100644 --- a/Bugzilla/RNG.pm +++ b/Bugzilla/RNG.pm @@ -7,7 +7,7 @@ package Bugzilla::RNG; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Report.pm b/Bugzilla/Report.pm index 10af2ea9e..9820bbc72 100644 --- a/Bugzilla/Report.pm +++ b/Bugzilla/Report.pm @@ -7,7 +7,7 @@ package Bugzilla::Report; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Search.pm b/Bugzilla/Search.pm index 29ca7b1d9..3274b57a6 100644 --- a/Bugzilla/Search.pm +++ b/Bugzilla/Search.pm @@ -7,7 +7,7 @@ package Bugzilla::Search; -use 5.10.1; +use 5.14.0; use strict; use warnings; @@ -1628,11 +1628,11 @@ sub _special_parse_email { my ($self) = @_; my $params = $self->_params; - my @email_params = grep { $_ =~ /^email\d+$/ } keys %$params; + my @email_params = grep { $_ =~ /^email\d+$/a } keys %$params; my $clause = new Bugzilla::Search::Clause(); foreach my $param (@email_params) { - $param =~ /(\d+)$/; + $param =~ /(\d+)$/a; my $id = $1; my $email = trim($params->{"email$id"}); next if !$email; @@ -1728,26 +1728,28 @@ sub _params_to_data_structure { sub _boolean_charts { my ($self) = @_; - + + use re '/a'; + my $params = $self->_params; my @param_list = keys %$params; - + my @all_field_params = grep { /^field-?\d+/ } @param_list; my @chart_ids = map { /^field(-?\d+)/; $1 } @all_field_params; @chart_ids = sort { $a <=> $b } uniq @chart_ids; - + my $clause = new Bugzilla::Search::Clause(); foreach my $chart_id (@chart_ids) { my @all_and = grep { /^field$chart_id-\d+/ } @param_list; my @and_ids = map { /^field$chart_id-(\d+)/; $1 } @all_and; @and_ids = sort { $a <=> $b } uniq @and_ids; - + my $and_clause = new Bugzilla::Search::Clause(); foreach my $and_id (@and_ids) { my @all_or = grep { /^field$chart_id-$and_id-\d+/ } @param_list; my @or_ids = map { /^field$chart_id-$and_id-(\d+)/; $1 } @all_or; @or_ids = sort { $a <=> $b } uniq @or_ids; - + my $or_clause = new Bugzilla::Search::Clause('OR'); foreach my $or_id (@or_ids) { my $identifier = "$chart_id-$and_id-$or_id"; @@ -1819,9 +1821,9 @@ sub _field_ids { my ($self) = @_; my $params = $self->_params; my @param_list = keys %$params; - - my @field_params = grep { /^f\d+$/ } @param_list; - my @field_ids = map { /(\d+)/; $1 } @field_params; + + my @field_params = grep { /^f\d+$/a } @param_list; + my @field_ids = map { /(\d+)/a; $1 } @field_params; @field_ids = sort { $a <=> $b } @field_ids; return @field_ids; } @@ -1916,9 +1918,6 @@ sub _handle_chart { # once we require MySQL 5.5.3 and use utf8mb4. sub _convert_unicode_characters { my $string = shift; - - # Perl 5.13.8 and older complain about non-characters. - no warnings 'utf8'; $string =~ s/([\x{10000}-\x{10FFFF}])/"\x{FDD0}[" . uc(sprintf('U+%04x', ord($1))) . "]\x{FDD1}"/eg; return $string; } @@ -2224,7 +2223,7 @@ sub SqlifyDate { return sprintf("%4d-%02d-%02d %02d:%02d:%02d", $year+1900, $month+1, $mday, $hour, $min, $sec); } - if ($str =~ /^(-|\+)?(\d+)([hdwmy])(s?)$/i) { # relative date + if ($str =~ /^(-|\+)?(\d+)([hdwmy])(s?)$/ai) { # relative date my ($sign, $amount, $unit, $startof, $date) = ($1, $2, lc $3, lc $4, time); my ($sec, $min, $hour, $mday, $month, $year, $wday) = localtime($date); if ($sign && $sign eq '+') { $amount = -$amount; } diff --git a/Bugzilla/Search/Clause.pm b/Bugzilla/Search/Clause.pm index 1d7872c78..87fb91692 100644 --- a/Bugzilla/Search/Clause.pm +++ b/Bugzilla/Search/Clause.pm @@ -7,7 +7,7 @@ package Bugzilla::Search::Clause; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Search/ClauseGroup.pm b/Bugzilla/Search/ClauseGroup.pm index 590c737fa..bae0bba55 100644 --- a/Bugzilla/Search/ClauseGroup.pm +++ b/Bugzilla/Search/ClauseGroup.pm @@ -7,7 +7,7 @@ package Bugzilla::Search::ClauseGroup; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Search/Condition.pm b/Bugzilla/Search/Condition.pm index 306a63eed..a963b1b89 100644 --- a/Bugzilla/Search/Condition.pm +++ b/Bugzilla/Search/Condition.pm @@ -7,7 +7,7 @@ package Bugzilla::Search::Condition; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Search/Quicksearch.pm b/Bugzilla/Search/Quicksearch.pm index 830177f8b..8e188161c 100644 --- a/Bugzilla/Search/Quicksearch.pm +++ b/Bugzilla/Search/Quicksearch.pm @@ -7,7 +7,7 @@ package Bugzilla::Search::Quicksearch; -use 5.10.1; +use 5.14.0; use strict; use warnings; @@ -537,7 +537,7 @@ sub _special_field_syntax { my ($word, $negate) = @_; # P1-5 Syntax - if ($word =~ m/^P(\d+)(?:-(\d+))?$/i) { + if ($word =~ m/^P(\d+)(?:-(\d+))?$/ai) { my ($p_start, $p_end) = ($1, $2); my $legal_priorities = get_legal_field_values('priority'); diff --git a/Bugzilla/Search/Recent.pm b/Bugzilla/Search/Recent.pm index e774c7fe0..18d08b2d0 100644 --- a/Bugzilla/Search/Recent.pm +++ b/Bugzilla/Search/Recent.pm @@ -7,7 +7,7 @@ package Bugzilla::Search::Recent; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Search/Saved.pm b/Bugzilla/Search/Saved.pm index 50a9cdd67..9f6addffe 100644 --- a/Bugzilla/Search/Saved.pm +++ b/Bugzilla/Search/Saved.pm @@ -7,7 +7,7 @@ package Bugzilla::Search::Saved; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Sender/Transport/Sendmail.pm b/Bugzilla/Sender/Transport/Sendmail.pm index 49f00777f..585ef9cd5 100644 --- a/Bugzilla/Sender/Transport/Sendmail.pm +++ b/Bugzilla/Sender/Transport/Sendmail.pm @@ -7,7 +7,7 @@ package Bugzilla::Sender::Transport::Sendmail; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Series.pm b/Bugzilla/Series.pm index 22202c6f1..2e6b3cfc3 100644 --- a/Bugzilla/Series.pm +++ b/Bugzilla/Series.pm @@ -14,7 +14,7 @@ package Bugzilla::Series; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Status.pm b/Bugzilla/Status.pm index 275510216..fbc731cea 100644 --- a/Bugzilla/Status.pm +++ b/Bugzilla/Status.pm @@ -7,7 +7,7 @@ package Bugzilla::Status; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Template.pm b/Bugzilla/Template.pm index 3cbff4733..48899cd78 100644 --- a/Bugzilla/Template.pm +++ b/Bugzilla/Template.pm @@ -8,7 +8,7 @@ package Bugzilla::Template; -use 5.10.1; +use 5.14.0; use strict; use warnings; @@ -159,9 +159,7 @@ sub quoteUrls { # mailto can't contain space or #, so we don't have to bother for that # Do this by replacing matches with \x{FDD2}$count\x{FDD3} # \x{FDDx} is used because it's unlikely to occur in the text - # and are reserved unicode characters. We disable warnings for now - # until we require Perl 5.13.9 or newer. - no warnings 'utf8'; + # and are reserved unicode characters. # If the comment is already wrapped, we should ignore newlines when # looking for matching regexps. Else we should take them into account. @@ -247,9 +245,9 @@ sub quoteUrls { # Also, we can't use $bug_re?$comment_re? because that will match the # empty string my $bug_word = template_var('terms')->{bug}; - my $bug_re = qr/\Q$bug_word\E$s*\#?$s*(\d+)/i; + my $bug_re = qr/\Q$bug_word\E$s*\#?$s*(\d+)/ai; my $comment_word = template_var('terms')->{comment}; - my $comment_re = qr/(?:\Q$comment_word\E|comment)$s*\#?$s*(\d+)/i; + my $comment_re = qr/(?:\Q$comment_word\E|comment)$s*\#?$s*(\d+)/ai; $text =~ s~\b($bug_re(?:$s*,?$s*$comment_re)?|$comment_re) ~ # We have several choices. $1 here is the link, and $2-4 are set # depending on which part matched diff --git a/Bugzilla/Template/Context.pm b/Bugzilla/Template/Context.pm index 470e6a9ee..3893504b3 100644 --- a/Bugzilla/Template/Context.pm +++ b/Bugzilla/Template/Context.pm @@ -8,7 +8,7 @@ # This exists to implement the template-before_process hook. package Bugzilla::Template::Context; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Template/Plugin/Bugzilla.pm b/Bugzilla/Template/Plugin/Bugzilla.pm index 806dd903b..4481e33d2 100644 --- a/Bugzilla/Template/Plugin/Bugzilla.pm +++ b/Bugzilla/Template/Plugin/Bugzilla.pm @@ -7,7 +7,7 @@ package Bugzilla::Template::Plugin::Bugzilla; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Template/Plugin/Hook.pm b/Bugzilla/Template/Plugin/Hook.pm index 669c77614..faba06b72 100644 --- a/Bugzilla/Template/Plugin/Hook.pm +++ b/Bugzilla/Template/Plugin/Hook.pm @@ -7,7 +7,7 @@ package Bugzilla::Template::Plugin::Hook; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Token.pm b/Bugzilla/Token.pm index be76be645..b6f07468e 100644 --- a/Bugzilla/Token.pm +++ b/Bugzilla/Token.pm @@ -7,7 +7,7 @@ package Bugzilla::Token; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Update.pm b/Bugzilla/Update.pm index 72a7108a8..8babf9864 100644 --- a/Bugzilla/Update.pm +++ b/Bugzilla/Update.pm @@ -7,7 +7,7 @@ package Bugzilla::Update; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/User.pm b/Bugzilla/User.pm index caaa6c51a..91defebb4 100644 --- a/Bugzilla/User.pm +++ b/Bugzilla/User.pm @@ -7,7 +7,7 @@ package Bugzilla::User; -use 5.10.1; +use 5.14.0; use strict; use warnings; @@ -1849,7 +1849,7 @@ sub match_field { # The field is a requestee field; in order for its name # to show up correctly on the confirmation page, we need # to find out the name of its flag type. - if ($field_name =~ /^requestee(_type)?-(\d+)$/) { + if ($field_name =~ /^requestee(_type)?-(\d+)$/a) { my $flag_type; if ($1) { require Bugzilla::FlagType; diff --git a/Bugzilla/User/APIKey.pm b/Bugzilla/User/APIKey.pm index d268a0a93..6a5124a3c 100644 --- a/Bugzilla/User/APIKey.pm +++ b/Bugzilla/User/APIKey.pm @@ -7,7 +7,7 @@ package Bugzilla::User::APIKey; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/User/Setting.pm b/Bugzilla/User/Setting.pm index aece3b7de..d0bf1f15b 100644 --- a/Bugzilla/User/Setting.pm +++ b/Bugzilla/User/Setting.pm @@ -8,7 +8,7 @@ package Bugzilla::User::Setting; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/User/Setting/Lang.pm b/Bugzilla/User/Setting/Lang.pm index d980b7a92..ba144aa30 100644 --- a/Bugzilla/User/Setting/Lang.pm +++ b/Bugzilla/User/Setting/Lang.pm @@ -7,7 +7,7 @@ package Bugzilla::User::Setting::Lang; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/User/Setting/Skin.pm b/Bugzilla/User/Setting/Skin.pm index 7b0688c0c..81ce6fd2c 100644 --- a/Bugzilla/User/Setting/Skin.pm +++ b/Bugzilla/User/Setting/Skin.pm @@ -8,7 +8,7 @@ package Bugzilla::User::Setting::Skin; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/User/Setting/Timezone.pm b/Bugzilla/User/Setting/Timezone.pm index 8959d1dda..2810395e8 100644 --- a/Bugzilla/User/Setting/Timezone.pm +++ b/Bugzilla/User/Setting/Timezone.pm @@ -7,7 +7,7 @@ package Bugzilla::User::Setting::Timezone; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/UserAgent.pm b/Bugzilla/UserAgent.pm index 14637038c..22e2639a3 100644 --- a/Bugzilla/UserAgent.pm +++ b/Bugzilla/UserAgent.pm @@ -7,7 +7,7 @@ package Bugzilla::UserAgent; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Util.pm b/Bugzilla/Util.pm index 4718efc88..e030ff8a8 100644 --- a/Bugzilla/Util.pm +++ b/Bugzilla/Util.pm @@ -7,7 +7,7 @@ package Bugzilla::Util; -use 5.10.1; +use 5.14.0; use strict; use warnings; @@ -49,13 +49,13 @@ sub trick_taint { } sub detaint_natural { - my $match = $_[0] =~ /^(\d+)$/; + my $match = $_[0] =~ /^(\d+)$/a; $_[0] = $match ? int($1) : undef; return (defined($_[0])); } sub detaint_signed { - my $match = $_[0] =~ /^([-+]?\d+)$/; + my $match = $_[0] =~ /^([-+]?\d+)$/a; # The "int()" call removes any leading plus sign. $_[0] = $match ? int($1) : undef; return (defined($_[0])); @@ -723,8 +723,8 @@ sub validate_date { if ($ts) { $date2 = time2str("%Y-%m-%d", $ts); - $date =~ s/(\d+)-0*(\d+?)-0*(\d+?)/$1-$2-$3/; - $date2 =~ s/(\d+)-0*(\d+?)-0*(\d+?)/$1-$2-$3/; + $date =~ s/(\d+)-0*(\d+?)-0*(\d+?)/$1-$2-$3/a; + $date2 =~ s/(\d+)-0*(\d+?)-0*(\d+?)/$1-$2-$3/a; } my $ret = ($ts && $date eq $date2); return $ret ? 1 : 0; diff --git a/Bugzilla/Version.pm b/Bugzilla/Version.pm index f6fedeba7..d135c4a7a 100644 --- a/Bugzilla/Version.pm +++ b/Bugzilla/Version.pm @@ -7,7 +7,7 @@ package Bugzilla::Version; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/WebService.pm b/Bugzilla/WebService.pm index f80813744..743d54c87 100644 --- a/Bugzilla/WebService.pm +++ b/Bugzilla/WebService.pm @@ -9,7 +9,7 @@ # actual RPC server, see Bugzilla::WebService::Server and its subclasses. package Bugzilla::WebService; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/WebService/Bug.pm b/Bugzilla/WebService/Bug.pm index a922c2bf0..aaf0d10e0 100644 --- a/Bugzilla/WebService/Bug.pm +++ b/Bugzilla/WebService/Bug.pm @@ -7,7 +7,7 @@ package Bugzilla::WebService::Bug; -use 5.10.1; +use 5.14.0; use strict; use warnings; @@ -530,7 +530,7 @@ sub search { my %options = ( fields => ['bug_id'] ); # Find the highest custom field id - my @field_ids = grep(/^f(\d+)$/, keys %$match_params); + my @field_ids = grep(/^f(\d+)$/a, keys %$match_params); my $last_field_id = @field_ids ? max @field_ids + 1 : 1; # Do special search types for certain fields. diff --git a/Bugzilla/WebService/BugUserLastVisit.pm b/Bugzilla/WebService/BugUserLastVisit.pm index 151327368..b82faa33a 100644 --- a/Bugzilla/WebService/BugUserLastVisit.pm +++ b/Bugzilla/WebService/BugUserLastVisit.pm @@ -7,7 +7,7 @@ package Bugzilla::WebService::BugUserLastVisit; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/WebService/Bugzilla.pm b/Bugzilla/WebService/Bugzilla.pm index c0b44a04c..67e40a15f 100644 --- a/Bugzilla/WebService/Bugzilla.pm +++ b/Bugzilla/WebService/Bugzilla.pm @@ -7,7 +7,7 @@ package Bugzilla::WebService::Bugzilla; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/WebService/Classification.pm b/Bugzilla/WebService/Classification.pm index cee597b68..e90444061 100644 --- a/Bugzilla/WebService/Classification.pm +++ b/Bugzilla/WebService/Classification.pm @@ -7,7 +7,7 @@ package Bugzilla::WebService::Classification; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/WebService/Component.pm b/Bugzilla/WebService/Component.pm index a59087492..1410a12f6 100644 --- a/Bugzilla/WebService/Component.pm +++ b/Bugzilla/WebService/Component.pm @@ -7,7 +7,7 @@ package Bugzilla::WebService::Component; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/WebService/Constants.pm b/Bugzilla/WebService/Constants.pm index 2387903bb..e5311d9e5 100644 --- a/Bugzilla/WebService/Constants.pm +++ b/Bugzilla/WebService/Constants.pm @@ -7,7 +7,7 @@ package Bugzilla::WebService::Constants; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/WebService/FlagType.pm b/Bugzilla/WebService/FlagType.pm index 9d7cce037..8fa29b8d0 100644 --- a/Bugzilla/WebService/FlagType.pm +++ b/Bugzilla/WebService/FlagType.pm @@ -7,7 +7,7 @@ package Bugzilla::WebService::FlagType; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/WebService/Group.pm b/Bugzilla/WebService/Group.pm index 468575a35..ec09604c4 100644 --- a/Bugzilla/WebService/Group.pm +++ b/Bugzilla/WebService/Group.pm @@ -7,7 +7,7 @@ package Bugzilla::WebService::Group; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/WebService/Product.pm b/Bugzilla/WebService/Product.pm index 75ec42c05..879d8eac1 100644 --- a/Bugzilla/WebService/Product.pm +++ b/Bugzilla/WebService/Product.pm @@ -7,7 +7,7 @@ package Bugzilla::WebService::Product; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/WebService/Server.pm b/Bugzilla/WebService/Server.pm index 7950c7a3b..da92b4d7f 100644 --- a/Bugzilla/WebService/Server.pm +++ b/Bugzilla/WebService/Server.pm @@ -7,7 +7,7 @@ package Bugzilla::WebService::Server; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/WebService/Server/JSONRPC.pm b/Bugzilla/WebService/Server/JSONRPC.pm index a75bba836..93d315fde 100644 --- a/Bugzilla/WebService/Server/JSONRPC.pm +++ b/Bugzilla/WebService/Server/JSONRPC.pm @@ -7,7 +7,7 @@ package Bugzilla::WebService::Server::JSONRPC; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/WebService/Server/XMLRPC.pm b/Bugzilla/WebService/Server/XMLRPC.pm index 33949ead0..f697f0927 100644 --- a/Bugzilla/WebService/Server/XMLRPC.pm +++ b/Bugzilla/WebService/Server/XMLRPC.pm @@ -7,7 +7,7 @@ package Bugzilla::WebService::Server::XMLRPC; -use 5.10.1; +use 5.14.0; use strict; use warnings; @@ -128,7 +128,7 @@ sub handle_login { # and also, in some cases, to more-usefully decode them. package Bugzilla::XMLRPC::Deserializer; -use 5.10.1; +use 5.14.0; use strict; use warnings; @@ -243,7 +243,7 @@ sub _validation_subs { package Bugzilla::XMLRPC::SOM; -use 5.10.1; +use 5.14.0; use strict; use warnings; @@ -270,7 +270,7 @@ sub paramsin { # See http://rt.cpan.org/Public/Bug/Display.html?id=32952. package Bugzilla::XMLRPC::Serializer; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/WebService/User.pm b/Bugzilla/WebService/User.pm index bacd08ba1..079e0782e 100644 --- a/Bugzilla/WebService/User.pm +++ b/Bugzilla/WebService/User.pm @@ -7,7 +7,7 @@ package Bugzilla::WebService::User; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/WebService/Util.pm b/Bugzilla/WebService/Util.pm index 052f7714d..752100649 100644 --- a/Bugzilla/WebService/Util.pm +++ b/Bugzilla/WebService/Util.pm @@ -7,7 +7,7 @@ package Bugzilla::WebService::Util; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Whine.pm b/Bugzilla/Whine.pm index eeaea6da4..6f322fe96 100644 --- a/Bugzilla/Whine.pm +++ b/Bugzilla/Whine.pm @@ -7,7 +7,7 @@ package Bugzilla::Whine; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Whine/Query.pm b/Bugzilla/Whine/Query.pm index b2a2c9e07..a691fd2ff 100644 --- a/Bugzilla/Whine/Query.pm +++ b/Bugzilla/Whine/Query.pm @@ -7,7 +7,7 @@ package Bugzilla::Whine::Query; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Bugzilla/Whine/Schedule.pm b/Bugzilla/Whine/Schedule.pm index 11f0bf16f..8417affb1 100644 --- a/Bugzilla/Whine/Schedule.pm +++ b/Bugzilla/Whine/Schedule.pm @@ -7,7 +7,7 @@ package Bugzilla::Whine::Schedule; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/Makefile.PL b/Makefile.PL index 9157b2358..3880acaff 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -12,9 +12,10 @@ # Initialization ###################################################################### -use 5.10.1; +use 5.14.0; use strict; use warnings; + use lib qw(. lib local/lib/perl5); use ExtUtils::MakeMaker 6.55; @@ -233,7 +234,7 @@ WriteMakefile( VERSION => BUGZILLA_VERSION, ABSTRACT => 'Bugzilla Bug Tracking System', LICENSE => 'Mozilla_2_0', - MIN_PERL_VERSION => '5.10.1', + MIN_PERL_VERSION => '5.14.0', CONFIGURE_REQUIRES => { 'ExtUtils::MakeMaker' => '6.55' }, PREREQ_PM => \%requires, TEST_REQUIRES => { @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/attachment.cgi b/attachment.cgi index ee1f24605..27a5b66c4 100755 --- a/attachment.cgi +++ b/attachment.cgi @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/buglist.cgi b/buglist.cgi index d67d274c7..fc00641cd 100755 --- a/buglist.cgi +++ b/buglist.cgi @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; @@ -27,7 +27,7 @@ # Bonus: # Offer subscription when you get a "series already exists" error? -use 5.10.1; +use 5.14.0; use strict; use warnings; @@ -231,7 +231,7 @@ sub getAndValidateSeriesIDs { # Return a list of IDs of all the lines selected in the UI. sub getSelectedLines { - my @ids = map { /^select(\d+)$/ ? $1 : () } $cgi->param(); + my @ids = map { /^select(\d+)$/a ? $1 : () } $cgi->param(); return @ids; } diff --git a/checksetup.pl b/checksetup.pl index 7c30a6e9d..aacdf41be 100755 --- a/checksetup.pl +++ b/checksetup.pl @@ -12,7 +12,7 @@ # Initialization ###################################################################### -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/clean-bug-user-last-visit.pl b/clean-bug-user-last-visit.pl index 810fe598c..4a6661dce 100755 --- a/clean-bug-user-last-visit.pl +++ b/clean-bug-user-last-visit.pl @@ -19,7 +19,7 @@ It takes no arguments and produces no output except in the case of errors. =cut -use 5.10.1; +use 5.14.0; use strict; use warnings; use lib qw(. lib local/lib/perl5); diff --git a/colchange.cgi b/colchange.cgi index aae7f9512..e1e78f443 100755 --- a/colchange.cgi +++ b/colchange.cgi @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/collectstats.pl b/collectstats.pl index e638e9fff..528df7529 100755 --- a/collectstats.pl +++ b/collectstats.pl @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/config.cgi b/config.cgi index 1eaa4e444..8e423ca00 100755 --- a/config.cgi +++ b/config.cgi @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/contrib/Bugzilla.pm b/contrib/Bugzilla.pm index 31e0a0f6d..bfc2fe385 100644 --- a/contrib/Bugzilla.pm +++ b/contrib/Bugzilla.pm @@ -4,7 +4,7 @@ package Bugzilla; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/contrib/bz_webservice_demo.pl b/contrib/bz_webservice_demo.pl index 6c8c21dfa..dda9a6f93 100755 --- a/contrib/bz_webservice_demo.pl +++ b/contrib/bz_webservice_demo.pl @@ -18,7 +18,7 @@ C<bz_webservice_demo.pl --help> for detailed help =cut -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/contrib/bzdbcopy.pl b/contrib/bzdbcopy.pl index 73160cf6a..887d6b60e 100755 --- a/contrib/bzdbcopy.pl +++ b/contrib/bzdbcopy.pl @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/contrib/convert-workflow.pl b/contrib/convert-workflow.pl index 1cbabca37..edabb5692 100755 --- a/contrib/convert-workflow.pl +++ b/contrib/convert-workflow.pl @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/contrib/extension-convert.pl b/contrib/extension-convert.pl index d4f29d855..f5e4977c3 100755 --- a/contrib/extension-convert.pl +++ b/contrib/extension-convert.pl @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/contrib/fixperms.pl b/contrib/fixperms.pl index a6e31fe70..55e8e90b8 100755 --- a/contrib/fixperms.pl +++ b/contrib/fixperms.pl @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/contrib/merge-users.pl b/contrib/merge-users.pl index 8e13b0934..16d50bb91 100755 --- a/contrib/merge-users.pl +++ b/contrib/merge-users.pl @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/contrib/mysqld-watcher.pl b/contrib/mysqld-watcher.pl index be93dcbb5..ff580a7ef 100755 --- a/contrib/mysqld-watcher.pl +++ b/contrib/mysqld-watcher.pl @@ -9,7 +9,7 @@ # mysqld-watcher.pl - a script that watches the running instance of # mysqld and kills off any long-running SELECTs against the shadow_db # -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/contrib/recode.pl b/contrib/recode.pl index edd9fe423..8894371b8 100755 --- a/contrib/recode.pl +++ b/contrib/recode.pl @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/contrib/replyrc b/contrib/replyrc index 2c5541e4c..b465135b6 100644 --- a/contrib/replyrc +++ b/contrib/replyrc @@ -5,7 +5,7 @@ script_line1 = use strict; script_line2 = use warnings; -script_line3 = use v5.10; +script_line3 = use v5.14; script_line4 = use Bugzilla; script_line5 = Bugzilla->extensions; 1; script_line6 = sub filter { Bugzilla->template->{SERVICE}->{CONTEXT}->{CONFIG}->{FILTERS}->{$_[0]} } diff --git a/contrib/sendbugmail.pl b/contrib/sendbugmail.pl index c48a6f713..2ebf163e7 100755 --- a/contrib/sendbugmail.pl +++ b/contrib/sendbugmail.pl @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/contrib/sendunsentbugmail.pl b/contrib/sendunsentbugmail.pl index 639762af9..16fd00aa1 100755 --- a/contrib/sendunsentbugmail.pl +++ b/contrib/sendunsentbugmail.pl @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/contrib/syncLDAP.pl b/contrib/syncLDAP.pl index 872dbc3d7..52ff067e3 100755 --- a/contrib/syncLDAP.pl +++ b/contrib/syncLDAP.pl @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/createaccount.cgi b/createaccount.cgi index d46bb72d8..754b1b552 100755 --- a/createaccount.cgi +++ b/createaccount.cgi @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/describecomponents.cgi b/describecomponents.cgi index 961324396..a81c8aa57 100755 --- a/describecomponents.cgi +++ b/describecomponents.cgi @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/describekeywords.cgi b/describekeywords.cgi index bb8cff7b0..dd7c6f881 100755 --- a/describekeywords.cgi +++ b/describekeywords.cgi @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/docs/en/rst/conf.py b/docs/en/rst/conf.py index d2cf20ba4..10d18cadb 100644 --- a/docs/en/rst/conf.py +++ b/docs/en/rst/conf.py @@ -46,7 +46,7 @@ master_doc = 'index' # General information about the project. project = u'Bugzilla' -copyright = u'2014, The Bugzilla Team' +copyright = u'2016, The Bugzilla Team' # The version info for the project you're documenting, acts as replacement for # |version| and |release|, also used in various other places throughout the @@ -115,7 +115,7 @@ rst_prolog = """ .. role:: field :class: field -.. |min-perl-ver| replace:: 5.10.1 +.. |min-perl-ver| replace:: 5.14.0 """ rst_epilog = """ diff --git a/docs/lib/Pod/Simple/HTML/Bugzilla.pm b/docs/lib/Pod/Simple/HTML/Bugzilla.pm index ffbd0775c..047a27bc7 100644 --- a/docs/lib/Pod/Simple/HTML/Bugzilla.pm +++ b/docs/lib/Pod/Simple/HTML/Bugzilla.pm @@ -7,7 +7,7 @@ package Pod::Simple::HTML::Bugzilla; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/docs/lib/Pod/Simple/HTMLBatch/Bugzilla.pm b/docs/lib/Pod/Simple/HTMLBatch/Bugzilla.pm index cb61082df..a4747eef0 100644 --- a/docs/lib/Pod/Simple/HTMLBatch/Bugzilla.pm +++ b/docs/lib/Pod/Simple/HTMLBatch/Bugzilla.pm @@ -7,7 +7,7 @@ package Pod::Simple::HTMLBatch::Bugzilla; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/docs/makedocs.pl b/docs/makedocs.pl index 6baf9a797..81d098a94 100755 --- a/docs/makedocs.pl +++ b/docs/makedocs.pl @@ -23,7 +23,7 @@ # All these TeX packages together are close to a gig :-| But after you've # installed them, you can remove texlive-latex-extra-doc to save 400MB. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/duplicates.cgi b/duplicates.cgi index 22a0c4006..0773400fd 100755 --- a/duplicates.cgi +++ b/duplicates.cgi @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/editclassifications.cgi b/editclassifications.cgi index 773aa20dc..0337e5511 100755 --- a/editclassifications.cgi +++ b/editclassifications.cgi @@ -7,7 +7,7 @@ # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/editcomponents.cgi b/editcomponents.cgi index 68de12a15..99bd3bb35 100755 --- a/editcomponents.cgi +++ b/editcomponents.cgi @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/editfields.cgi b/editfields.cgi index 87db4ce08..88961a4e4 100755 --- a/editfields.cgi +++ b/editfields.cgi @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/editflagtypes.cgi b/editflagtypes.cgi index e9d2ab42b..a319742d3 100755 --- a/editflagtypes.cgi +++ b/editflagtypes.cgi @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/editgroups.cgi b/editgroups.cgi index baff40f6b..ac0e6a8bd 100755 --- a/editgroups.cgi +++ b/editgroups.cgi @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/editkeywords.cgi b/editkeywords.cgi index cfa5e31b9..afa00ad7f 100755 --- a/editkeywords.cgi +++ b/editkeywords.cgi @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/editmilestones.cgi b/editmilestones.cgi index 432c0bc5b..2b6e041e7 100755 --- a/editmilestones.cgi +++ b/editmilestones.cgi @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/editparams.cgi b/editparams.cgi index 3894b4880..502d2a564 100755 --- a/editparams.cgi +++ b/editparams.cgi @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/editproducts.cgi b/editproducts.cgi index a1c06e91f..5f7434772 100755 --- a/editproducts.cgi +++ b/editproducts.cgi @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; @@ -343,7 +343,7 @@ if ($action eq 'updategroupcontrols') { my @now_na = (); my @now_mandatory = (); foreach my $f ($cgi->param()) { - if ($f =~ /^membercontrol_(\d+)$/) { + if ($f =~ /^membercontrol_(\d+)$/a) { my $id = $1; if ($cgi->param($f) == CONTROLMAPNA) { push @now_na,$id; diff --git a/editsettings.cgi b/editsettings.cgi index ef419c7e3..5a30e68c9 100755 --- a/editsettings.cgi +++ b/editsettings.cgi @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/editusers.cgi b/editusers.cgi index 54160b493..341176871 100755 --- a/editusers.cgi +++ b/editusers.cgi @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/editvalues.cgi b/editvalues.cgi index 8c80a04d0..4be8cfd44 100755 --- a/editvalues.cgi +++ b/editvalues.cgi @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/editversions.cgi b/editversions.cgi index 976c72224..4a102c438 100755 --- a/editversions.cgi +++ b/editversions.cgi @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/editwhines.cgi b/editwhines.cgi index 229a32e25..6597db893 100755 --- a/editwhines.cgi +++ b/editwhines.cgi @@ -10,7 +10,7 @@ # Script Initialization ################################################################################ -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/editworkflow.cgi b/editworkflow.cgi index 3739158a1..583bce688 100755 --- a/editworkflow.cgi +++ b/editworkflow.cgi @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/email_in.pl b/email_in.pl index 6951924f6..c34d2fc24 100755 --- a/email_in.pl +++ b/email_in.pl @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/enter_bug.cgi b/enter_bug.cgi index aa396b1be..d6cc90764 100755 --- a/enter_bug.cgi +++ b/enter_bug.cgi @@ -16,7 +16,7 @@ # ############################################################################## -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/extensions/BmpConvert/Config.pm b/extensions/BmpConvert/Config.pm index 4984f19a9..3c8e792ab 100644 --- a/extensions/BmpConvert/Config.pm +++ b/extensions/BmpConvert/Config.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::BmpConvert; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/extensions/BmpConvert/Extension.pm b/extensions/BmpConvert/Extension.pm index b8201f106..407ab3aaa 100644 --- a/extensions/BmpConvert/Extension.pm +++ b/extensions/BmpConvert/Extension.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::BmpConvert; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/extensions/Example/API/1_0/Resource/Example.pm b/extensions/Example/API/1_0/Resource/Example.pm index c4c5f9a32..38000fbdb 100644 --- a/extensions/Example/API/1_0/Resource/Example.pm +++ b/extensions/Example/API/1_0/Resource/Example.pm @@ -7,7 +7,7 @@ package Bugzilla::API::1_0::Resource::Example; -use 5.10.1; +use 5.14.0; use strict; use warnings; use parent qw(Bugzilla::API::1_0::Resource); diff --git a/extensions/Example/Config.pm b/extensions/Example/Config.pm index 16708e3f8..02ed01e77 100644 --- a/extensions/Example/Config.pm +++ b/extensions/Example/Config.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::Example; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/extensions/Example/Extension.pm b/extensions/Example/Extension.pm index 40ee9c2d1..ef27200ac 100644 --- a/extensions/Example/Extension.pm +++ b/extensions/Example/Extension.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::Example; -use 5.10.1; +use 5.14.0; use strict; use warnings; @@ -479,13 +479,7 @@ sub error_catch { my $new_error_msg = "Ah ah, you tried to access $page_id? Good try!"; $new_error_msg = html_quote($new_error_msg); # There are better tools to parse an HTML page, but it's just an example. - # Since Perl 5.16, we can no longer write "class" inside look-behind - # assertions, because "ss" is also seen as the german ß character, which - # makes Perl 5.16 complain. The right fix is to use the /aa modifier, - # but it's only understood since Perl 5.14. So the workaround is to write - # "clas[s]" instead of "class". Stupid and ugly hack, but it works with - # all Perl versions. - $$page =~ s/(?<=<td id="error_msg" clas[s]="throw_error">).*(?=<\/td>)/$new_error_msg/si; + $$page =~ s/<div id="error_msg" class="throw_error">\K(.*)/$new_error_msg<br>$1/siaa; } sub flag_end_of_update { diff --git a/extensions/Example/lib/Auth/Login.pm b/extensions/Example/lib/Auth/Login.pm index 15c58a881..77a113722 100644 --- a/extensions/Example/lib/Auth/Login.pm +++ b/extensions/Example/lib/Auth/Login.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::Example::Auth::Login; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/extensions/Example/lib/Auth/Verify.pm b/extensions/Example/lib/Auth/Verify.pm index 49fd9fbb7..8cda4a9e8 100644 --- a/extensions/Example/lib/Auth/Verify.pm +++ b/extensions/Example/lib/Auth/Verify.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::Example::Auth::Verify; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/extensions/Example/lib/Config.pm b/extensions/Example/lib/Config.pm index fac0046af..311ea4a6a 100644 --- a/extensions/Example/lib/Config.pm +++ b/extensions/Example/lib/Config.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::Example::Config; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/extensions/Example/lib/Migrate/ImportBugs.pm b/extensions/Example/lib/Migrate/ImportBugs.pm index 42a393c73..3160c91a8 100644 --- a/extensions/Example/lib/Migrate/ImportBugs.pm +++ b/extensions/Example/lib/Migrate/ImportBugs.pm @@ -18,8 +18,12 @@ implementation see L<Bugzilla::Migrate::Gnats>. =cut package Bugzilla::Extension::Example::Migrate::ImportBugs; + +use 5.14.0 use strict; -use base qw(Bugzilla::Migrate); +use warnings; + +use parent qw(Bugzilla::Migrate); use Bugzilla::Constants; use Bugzilla::Install::Util qw(indicate_progress); diff --git a/extensions/Example/lib/Util.pm b/extensions/Example/lib/Util.pm index ccc349c9c..88a9a5a84 100644 --- a/extensions/Example/lib/Util.pm +++ b/extensions/Example/lib/Util.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::Example::Util; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/extensions/Example/lib/WebService.pm b/extensions/Example/lib/WebService.pm index d8a96b5f5..4dc7dd2e5 100644 --- a/extensions/Example/lib/WebService.pm +++ b/extensions/Example/lib/WebService.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::Example::WebService; -use 5.10.1; +use 5.14.0; use strict; use warnings; use parent qw(Bugzilla::WebService); diff --git a/extensions/MoreBugUrl/Config.pm b/extensions/MoreBugUrl/Config.pm index e0eac5f8a..a93f350ff 100644 --- a/extensions/MoreBugUrl/Config.pm +++ b/extensions/MoreBugUrl/Config.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::MoreBugUrl; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/extensions/MoreBugUrl/Extension.pm b/extensions/MoreBugUrl/Extension.pm index 0a4223e19..d5fd661f6 100644 --- a/extensions/MoreBugUrl/Extension.pm +++ b/extensions/MoreBugUrl/Extension.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::MoreBugUrl; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/extensions/MoreBugUrl/lib/BitBucket.pm b/extensions/MoreBugUrl/lib/BitBucket.pm index dcc85992d..8b01f0bb1 100644 --- a/extensions/MoreBugUrl/lib/BitBucket.pm +++ b/extensions/MoreBugUrl/lib/BitBucket.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::MoreBugUrl::BitBucket; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/extensions/MoreBugUrl/lib/GetSatisfaction.pm b/extensions/MoreBugUrl/lib/GetSatisfaction.pm index 74951735b..f50160e89 100644 --- a/extensions/MoreBugUrl/lib/GetSatisfaction.pm +++ b/extensions/MoreBugUrl/lib/GetSatisfaction.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::MoreBugUrl::GetSatisfaction; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/extensions/MoreBugUrl/lib/PHP.pm b/extensions/MoreBugUrl/lib/PHP.pm index 6f201d7b1..0cca7262f 100644 --- a/extensions/MoreBugUrl/lib/PHP.pm +++ b/extensions/MoreBugUrl/lib/PHP.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::MoreBugUrl::PHP; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/extensions/MoreBugUrl/lib/Phabricator.pm b/extensions/MoreBugUrl/lib/Phabricator.pm index 818d9af8f..c282b1bda 100644 --- a/extensions/MoreBugUrl/lib/Phabricator.pm +++ b/extensions/MoreBugUrl/lib/Phabricator.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::MoreBugUrl::Phabricator; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/extensions/MoreBugUrl/lib/RT.pm b/extensions/MoreBugUrl/lib/RT.pm index acb90cf39..d25813e4b 100644 --- a/extensions/MoreBugUrl/lib/RT.pm +++ b/extensions/MoreBugUrl/lib/RT.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::MoreBugUrl::RT; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/extensions/MoreBugUrl/lib/Redmine.pm b/extensions/MoreBugUrl/lib/Redmine.pm index 57a071239..5be0e25a0 100644 --- a/extensions/MoreBugUrl/lib/Redmine.pm +++ b/extensions/MoreBugUrl/lib/Redmine.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::MoreBugUrl::Redmine; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/extensions/MoreBugUrl/lib/ReviewBoard.pm b/extensions/MoreBugUrl/lib/ReviewBoard.pm index af5ff0684..d4691f7a0 100644 --- a/extensions/MoreBugUrl/lib/ReviewBoard.pm +++ b/extensions/MoreBugUrl/lib/ReviewBoard.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::MoreBugUrl::ReviewBoard; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/extensions/MoreBugUrl/lib/Rietveld.pm b/extensions/MoreBugUrl/lib/Rietveld.pm index a4bf08492..4587c57b9 100644 --- a/extensions/MoreBugUrl/lib/Rietveld.pm +++ b/extensions/MoreBugUrl/lib/Rietveld.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::MoreBugUrl::Rietveld; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/extensions/MoreBugUrl/lib/Savane.pm b/extensions/MoreBugUrl/lib/Savane.pm index 5b35bbf7d..722d58bbc 100644 --- a/extensions/MoreBugUrl/lib/Savane.pm +++ b/extensions/MoreBugUrl/lib/Savane.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::MoreBugUrl::Savane; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/extensions/Voting/Config.pm b/extensions/Voting/Config.pm index 97c44933e..0fd8f37c3 100644 --- a/extensions/Voting/Config.pm +++ b/extensions/Voting/Config.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::Voting; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/extensions/Voting/Extension.pm b/extensions/Voting/Extension.pm index b125933ce..a0ed8f3fd 100644 --- a/extensions/Voting/Extension.pm +++ b/extensions/Voting/Extension.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::Voting; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/extensions/create.pl b/extensions/create.pl index f22734777..2f6f4a0be 100755 --- a/extensions/create.pl +++ b/extensions/create.pl @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/gen-cpanfile.pl b/gen-cpanfile.pl index 26b3ab326..51d717d7c 100755 --- a/gen-cpanfile.pl +++ b/gen-cpanfile.pl @@ -12,10 +12,12 @@ # Initialization ###################################################################### -use 5.10.1; +use 5.14.0; use strict; use warnings; -use lib qw(lib local/lib/perl5); + +use lib qw(. lib local/lib/perl5); + use Getopt::Long qw(:config gnu_getopt); if (-f "MYMETA.json") { diff --git a/importxml.pl b/importxml.pl index 463c6ef70..f4f9be956 100755 --- a/importxml.pl +++ b/importxml.pl @@ -10,7 +10,7 @@ # a new bug into bugzilla. Everything before the beginning <?xml line # is removed so you can pipe in email messages. -use 5.10.1; +use 5.14.0; use strict; use warnings; @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/jobqueue.pl b/jobqueue.pl index 4ce7c27f7..252397720 100755 --- a/jobqueue.pl +++ b/jobqueue.pl @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/jsonrpc.cgi b/jsonrpc.cgi index eab11af59..7a91b4b10 100755 --- a/jsonrpc.cgi +++ b/jsonrpc.cgi @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/migrate.pl b/migrate.pl index 0c2fad610..25b39b414 100755 --- a/migrate.pl +++ b/migrate.pl @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/mod_perl.pl b/mod_perl.pl index c61ad4629..873cf26b6 100644 --- a/mod_perl.pl +++ b/mod_perl.pl @@ -8,7 +8,7 @@ package Bugzilla::ModPerl; -use 5.10.1; +use 5.14.0; use strict; use warnings; @@ -115,7 +115,7 @@ foreach my $file (glob "$cgi_path/*.cgi") { package Bugzilla::ModPerl::ResponseHandler; -use 5.10.1; +use 5.14.0; use strict; use warnings; @@ -152,7 +152,7 @@ sub handler : method { package Bugzilla::ModPerl::CleanupHandler; -use 5.10.1; +use 5.14.0; use strict; use warnings; @@ -13,7 +13,7 @@ # a content-type, e.g. html. ############################################################################### -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/post_bug.cgi b/post_bug.cgi index 5deba2cdb..17d0fe4ea 100755 --- a/post_bug.cgi +++ b/post_bug.cgi @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/process_bug.cgi b/process_bug.cgi index 607520bb1..ea803d1f7 100755 --- a/process_bug.cgi +++ b/process_bug.cgi @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; @@ -309,9 +309,10 @@ if (defined $cgi->param('id')) { my %is_private; foreach my $field (grep(/^defined_isprivate/, $cgi->param())) { - $field =~ /(\d+)$/; - my $comment_id = $1; - $is_private{$comment_id} = $cgi->param("isprivate_$comment_id"); + if ($field =~ /(\d+)$/a) { + my $comment_id = $1; + $is_private{$comment_id} = $cgi->param("isprivate_$comment_id"); + } } $set_all_fields{comment_is_private} = \%is_private; @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/relogin.cgi b/relogin.cgi index 6836795c5..65c29a2c4 100755 --- a/relogin.cgi +++ b/relogin.cgi @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/report.cgi b/report.cgi index 8de3288d9..2f637fca4 100755 --- a/report.cgi +++ b/report.cgi @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/reports.cgi b/reports.cgi index b8c08cbe3..06890b38d 100755 --- a/reports.cgi +++ b/reports.cgi @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/request.cgi b/request.cgi index 3283722ce..95e4fd1fd 100755 --- a/request.cgi +++ b/request.cgi @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/sanitycheck.cgi b/sanitycheck.cgi index 7f1db26bc..bb131a65a 100755 --- a/sanitycheck.cgi +++ b/sanitycheck.cgi @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/sanitycheck.pl b/sanitycheck.pl index bf3680bd6..420cd393a 100755 --- a/sanitycheck.pl +++ b/sanitycheck.pl @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/search_plugin.cgi b/search_plugin.cgi index 938e5720b..0af134201 100755 --- a/search_plugin.cgi +++ b/search_plugin.cgi @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/show_activity.cgi b/show_activity.cgi index d2f7c9963..fa231ed51 100755 --- a/show_activity.cgi +++ b/show_activity.cgi @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/show_bug.cgi b/show_bug.cgi index 997fab60d..09cb91a86 100755 --- a/show_bug.cgi +++ b/show_bug.cgi @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; @@ -51,11 +51,11 @@ if ($single) { push @bugs, Bugzilla::Bug->check({ id => $id, cache => 1 }); if (defined $cgi->param('mark')) { foreach my $range (split ',', $cgi->param('mark')) { - if ($range =~ /^(\d+)-(\d+)$/) { + if ($range =~ /^(\d+)-(\d+)$/a) { foreach my $i ($1..$2) { $marks{$i} = 1; } - } elsif ($range =~ /^(\d+)$/) { + } elsif ($range =~ /^(\d+)$/a) { $marks{$1} = 1; } } diff --git a/showdependencygraph.cgi b/showdependencygraph.cgi index c5bcd5bdc..e692167de 100755 --- a/showdependencygraph.cgi +++ b/showdependencygraph.cgi @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/showdependencytree.cgi b/showdependencytree.cgi index 7f594632e..cbfcd59cd 100755 --- a/showdependencytree.cgi +++ b/showdependencytree.cgi @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/shutdown.cgi b/shutdown.cgi index b498349a0..4e04b1585 100755 --- a/shutdown.cgi +++ b/shutdown.cgi @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/summarize_time.cgi b/summarize_time.cgi index 85d68b2dd..193899f0d 100755 --- a/summarize_time.cgi +++ b/summarize_time.cgi @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/t/001compile.t b/t/001compile.t index e061b06c6..d9ec1b28d 100644 --- a/t/001compile.t +++ b/t/001compile.t @@ -10,7 +10,7 @@ #Bugzilla Test 1# ###Compilation### -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/t/002goodperl.t b/t/002goodperl.t index 7b2e74acc..400483a5a 100644 --- a/t/002goodperl.t +++ b/t/002goodperl.t @@ -10,7 +10,7 @@ #Bugzilla Test 2# ####GoodPerl##### -use 5.10.1; +use 5.14.0; use strict; use warnings; @@ -88,16 +88,16 @@ foreach my $file (@testitems) { next; } while (my $file_line = <FILE>) { - $found_use_perl = 1 if $file_line =~ m/^\s*use 5.10.1/; + $found_use_perl = 1 if $file_line =~ m/^\s*use 5\.14\.0/; $found_use_strict = 1 if $file_line =~ m/^\s*use strict/; $found_use_warnings = 1 if $file_line =~ m/^\s*use warnings/; last if ($found_use_perl && $found_use_strict && $found_use_warnings); } close (FILE); if ($found_use_perl) { - ok(1,"$file requires Perl 5.10.1"); + ok(1,"$file requires Perl 5.14.0"); } else { - ok(0,"$file DOES NOT require Perl 5.10.1 --WARNING"); + ok(0,"$file DOES NOT require Perl 5.14.0 --WARNING"); } if ($found_use_strict) { diff --git a/t/004template.t b/t/004template.t index 909f1a231..e6c241cc0 100644 --- a/t/004template.t +++ b/t/004template.t @@ -9,7 +9,7 @@ #Bugzilla Test 4# ####Templates#### -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/t/005whitespace.t b/t/005whitespace.t index be13890bb..5529392f6 100644 --- a/t/005whitespace.t +++ b/t/005whitespace.t @@ -9,7 +9,7 @@ #Bugzilla Test 5# #####no_tabs##### -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/t/006spellcheck.t b/t/006spellcheck.t index 2f6dbbf76..e675398f1 100644 --- a/t/006spellcheck.t +++ b/t/006spellcheck.t @@ -10,7 +10,7 @@ #Bugzilla Test 6# ####Spelling##### -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/t/007util.t b/t/007util.t index b8e9505d8..8f54e828e 100644 --- a/t/007util.t +++ b/t/007util.t @@ -9,7 +9,7 @@ #Bugzilla Test 7# #####Util.pm##### -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/t/008filter.t b/t/008filter.t index 65fecfb1f..cd0af0735 100644 --- a/t/008filter.t +++ b/t/008filter.t @@ -15,7 +15,7 @@ # Sample exploit code: '>"><script>alert('Oh dear...')</script> -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/t/009bugwords.t b/t/009bugwords.t index 740cbf6aa..af83d1eac 100644 --- a/t/009bugwords.t +++ b/t/009bugwords.t @@ -15,7 +15,7 @@ # "[% terms.bug %]". This test makes sure the relevant words aren't used # bare. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/t/010dependencies.t b/t/010dependencies.t index 777d42ed1..4b7ca223d 100644 --- a/t/010dependencies.t +++ b/t/010dependencies.t @@ -10,7 +10,7 @@ #Bugzilla Test 10# ## dependencies ## -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/t/011pod.t b/t/011pod.t index 380b866c9..8a8339672 100644 --- a/t/011pod.t +++ b/t/011pod.t @@ -10,7 +10,7 @@ #Bugzilla Test 11# ##POD validation## -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/t/012throwables.t b/t/012throwables.t index cb00eaf78..9d709c6ab 100644 --- a/t/012throwables.t +++ b/t/012throwables.t @@ -11,7 +11,7 @@ #Bugzilla Test 12# ######Errors###### -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/t/013dbschema.t b/t/013dbschema.t index 8313444d7..9770593aa 100644 --- a/t/013dbschema.t +++ b/t/013dbschema.t @@ -12,7 +12,7 @@ # Check the Bugzilla database schema to ensure no field names conflict # with SQL reserved words. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/t/014critic-core.t b/t/014critic-core.t index e38e64210..fb3bc279c 100644 --- a/t/014critic-core.t +++ b/t/014critic-core.t @@ -7,9 +7,12 @@ # Enforce high standards against code that will be installed -use 5.10.1; +use 5.14.0; use strict; use warnings; + +use lib qw(. lib local/lib/perl5 t); + use Test::More; use File::Spec::Functions ':ALL'; diff --git a/t/Support/Files.pm b/t/Support/Files.pm index e06cda738..e4e8f1ff8 100644 --- a/t/Support/Files.pm +++ b/t/Support/Files.pm @@ -8,7 +8,7 @@ package Support::Files; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/t/Support/Systemexec.pm b/t/Support/Systemexec.pm index e73763f8f..c3cf5a21b 100644 --- a/t/Support/Systemexec.pm +++ b/t/Support/Systemexec.pm @@ -7,7 +7,7 @@ package Support::Systemexec; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/t/Support/Templates.pm b/t/Support/Templates.pm index d17c7334b..2f53592a8 100644 --- a/t/Support/Templates.pm +++ b/t/Support/Templates.pm @@ -7,7 +7,7 @@ package Support::Templates; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/template/en/default/extensions/config.pm.tmpl b/template/en/default/extensions/config.pm.tmpl index 68ed260c1..599f9ea59 100644 --- a/template/en/default/extensions/config.pm.tmpl +++ b/template/en/default/extensions/config.pm.tmpl @@ -14,7 +14,7 @@ package Bugzilla::Extension::[% name %]; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/template/en/default/extensions/extension.pm.tmpl b/template/en/default/extensions/extension.pm.tmpl index 823440421..985d28ccc 100644 --- a/template/en/default/extensions/extension.pm.tmpl +++ b/template/en/default/extensions/extension.pm.tmpl @@ -14,7 +14,7 @@ package Bugzilla::Extension::[% name %]; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/template/en/default/extensions/util.pm.tmpl b/template/en/default/extensions/util.pm.tmpl index 3baab57fd..6e14428a6 100644 --- a/template/en/default/extensions/util.pm.tmpl +++ b/template/en/default/extensions/util.pm.tmpl @@ -14,7 +14,7 @@ package Bugzilla::Extension::[% name %]::Util; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/testagent.cgi b/testagent.cgi index dfb1ff228..c70c90779 100755 --- a/testagent.cgi +++ b/testagent.cgi @@ -10,7 +10,7 @@ # are being run instead of shown. This script does not rely on database access # or correct params. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/testserver.pl b/testserver.pl index a3d54f971..a5e36a825 100755 --- a/testserver.pl +++ b/testserver.pl @@ -10,7 +10,7 @@ # as its only argument. It attempts to troubleshoot as many installation # issues as possible. -use 5.10.1; +use 5.14.0; use strict; use warnings; @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/userprefs.cgi b/userprefs.cgi index bd5cfaf01..d7366a878 100755 --- a/userprefs.cgi +++ b/userprefs.cgi @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; @@ -332,7 +332,7 @@ sub SaveEmail { # Remove any bug ids the user no longer wants to ignore foreach my $key (grep(/^remove_ignored_bug_/, $cgi->param)) { - my ($bug_id) = $key =~ /(\d+)$/; + my ($bug_id) = $key =~ /(\d+)$/a; delete $ignored_bugs{$bug_id}; } diff --git a/view_job_queue.cgi b/view_job_queue.cgi index c778d0d61..d4c5c08e3 100755 --- a/view_job_queue.cgi +++ b/view_job_queue.cgi @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; @@ -9,7 +9,7 @@ # This script remains as a backwards-compatibility URL for before # the time that Voting was an extension. -use 5.10.1; +use 5.14.0; use strict; use warnings; @@ -10,7 +10,7 @@ # Script Initialization ################################################################################ -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/whineatnews.pl b/whineatnews.pl index 318ecda94..660cc617f 100755 --- a/whineatnews.pl +++ b/whineatnews.pl @@ -14,7 +14,7 @@ # param. (We have NEW and REOPENED in there to keep compatibility with old # Bugzillas.) -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xmlrpc.cgi b/xmlrpc.cgi index 75ff8a1a9..b4a035cda 100755 --- a/xmlrpc.cgi +++ b/xmlrpc.cgi @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/config/generate_test_data.pl b/xt/config/generate_test_data.pl index ab186698d..ce065998b 100755 --- a/xt/config/generate_test_data.pl +++ b/xt/config/generate_test_data.pl @@ -9,7 +9,7 @@ # -*- Mode: perl; indent-tabs-mode: nil -*- -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/extensions/QA/Config.pm b/xt/extensions/QA/Config.pm index b4f6bc9a2..c234e12c0 100644 --- a/xt/extensions/QA/Config.pm +++ b/xt/extensions/QA/Config.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::QA; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/extensions/QA/Extension.pm b/xt/extensions/QA/Extension.pm index 5befe3e36..9f60ea95b 100644 --- a/xt/extensions/QA/Extension.pm +++ b/xt/extensions/QA/Extension.pm @@ -7,11 +7,11 @@ package Bugzilla::Extension::QA; -use 5.10.1; +use 5.14.0; use strict; use warnings; -use base qw(Bugzilla::Extension); +use parent qw(Bugzilla::Extension); use Bugzilla::Extension::QA::Util; use Bugzilla::Constants; diff --git a/xt/extensions/QA/lib/Util.pm b/xt/extensions/QA/lib/Util.pm index e299adcc9..48ae944ef 100644 --- a/xt/extensions/QA/lib/Util.pm +++ b/xt/extensions/QA/lib/Util.pm @@ -7,11 +7,11 @@ package Bugzilla::Extension::QA::Util; -use 5.10.1; +use 5.14.0; use strict; use warnings; -use base qw(Exporter); +use parent qw(Exporter); our @EXPORT = qw( parse_output diff --git a/xt/lib/QA/REST.pm b/xt/lib/QA/REST.pm index 4de985668..1ceeb955b 100644 --- a/xt/lib/QA/REST.pm +++ b/xt/lib/QA/REST.pm @@ -7,7 +7,7 @@ package QA::REST; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/lib/QA/RPC.pm b/xt/lib/QA/RPC.pm index 63a7d9503..e2f1f7597 100644 --- a/xt/lib/QA/RPC.pm +++ b/xt/lib/QA/RPC.pm @@ -9,7 +9,7 @@ package QA::RPC; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/lib/QA/RPC/JSONRPC.pm b/xt/lib/QA/RPC/JSONRPC.pm index 7a085e026..ce3122869 100644 --- a/xt/lib/QA/RPC/JSONRPC.pm +++ b/xt/lib/QA/RPC/JSONRPC.pm @@ -9,7 +9,7 @@ package QA::RPC::JSONRPC; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/lib/QA/RPC/XMLRPC.pm b/xt/lib/QA/RPC/XMLRPC.pm index cb227fa9c..ced9f97ee 100644 --- a/xt/lib/QA/RPC/XMLRPC.pm +++ b/xt/lib/QA/RPC/XMLRPC.pm @@ -9,7 +9,7 @@ package QA::RPC::XMLRPC; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/lib/QA/Tests.pm b/xt/lib/QA/Tests.pm index fe5f2d067..d0a32cfc6 100644 --- a/xt/lib/QA/Tests.pm +++ b/xt/lib/QA/Tests.pm @@ -9,7 +9,7 @@ package QA::Tests; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/lib/QA/Util.pm b/xt/lib/QA/Util.pm index e122e41db..90a6902e5 100644 --- a/xt/lib/QA/Util.pm +++ b/xt/lib/QA/Util.pm @@ -9,7 +9,7 @@ package QA::Util; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/rest/bugzilla.t b/xt/rest/bugzilla.t index a176d1cf1..b7fd39664 100644 --- a/xt/rest/bugzilla.t +++ b/xt/rest/bugzilla.t @@ -9,7 +9,7 @@ # Tests for REST calls in Bugzilla.pm # ####################################### -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/rest/classification.t b/xt/rest/classification.t index d006de984..bcf0d7edb 100644 --- a/xt/rest/classification.t +++ b/xt/rest/classification.t @@ -9,7 +9,7 @@ # Tests for REST calls in Classification.pm # ############################################# -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/selenium/bug_edit.t b/xt/selenium/bug_edit.t index 46e7e6cb3..5f1983ba9 100644 --- a/xt/selenium/bug_edit.t +++ b/xt/selenium/bug_edit.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/selenium/choose_priority.t b/xt/selenium/choose_priority.t index 1089d2003..ef5bc6db7 100644 --- a/xt/selenium/choose_priority.t +++ b/xt/selenium/choose_priority.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/selenium/classifications.t b/xt/selenium/classifications.t index 4d5d012f0..1653d2e10 100644 --- a/xt/selenium/classifications.t +++ b/xt/selenium/classifications.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/selenium/config.t b/xt/selenium/config.t index b99927321..b2ff6e408 100644 --- a/xt/selenium/config.t +++ b/xt/selenium/config.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/selenium/create_user_accounts.t b/xt/selenium/create_user_accounts.t index 7c71273a6..2e7e8782f 100644 --- a/xt/selenium/create_user_accounts.t +++ b/xt/selenium/create_user_accounts.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/selenium/custom_fields.t b/xt/selenium/custom_fields.t index 6c0c8fa5d..e64eb6165 100644 --- a/xt/selenium/custom_fields.t +++ b/xt/selenium/custom_fields.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/selenium/custom_fields_admin.t b/xt/selenium/custom_fields_admin.t index d0ffb9db8..addbd17c8 100644 --- a/xt/selenium/custom_fields_admin.t +++ b/xt/selenium/custom_fields_admin.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/selenium/dependencies.t b/xt/selenium/dependencies.t index 133e17e07..315fff07a 100644 --- a/xt/selenium/dependencies.t +++ b/xt/selenium/dependencies.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/selenium/edit_products_properties.t b/xt/selenium/edit_products_properties.t index 1f9851729..efc5a6a25 100644 --- a/xt/selenium/edit_products_properties.t +++ b/xt/selenium/edit_products_properties.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/selenium/email_preferences.t b/xt/selenium/email_preferences.t index c1e60b05a..961f26096 100644 --- a/xt/selenium/email_preferences.t +++ b/xt/selenium/email_preferences.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/selenium/enter_new_bug.t b/xt/selenium/enter_new_bug.t index 404d30f10..86a55e56d 100644 --- a/xt/selenium/enter_new_bug.t +++ b/xt/selenium/enter_new_bug.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/selenium/flags.t b/xt/selenium/flags.t index dd4a0ffa8..c0b5ac7c0 100644 --- a/xt/selenium/flags.t +++ b/xt/selenium/flags.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/selenium/flags2.t b/xt/selenium/flags2.t index 9b921612c..06290336e 100644 --- a/xt/selenium/flags2.t +++ b/xt/selenium/flags2.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/selenium/groups.t b/xt/selenium/groups.t index b755cafc8..011dea25e 100644 --- a/xt/selenium/groups.t +++ b/xt/selenium/groups.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/selenium/keywords.t b/xt/selenium/keywords.t index 16ecf90e7..74ba14f16 100644 --- a/xt/selenium/keywords.t +++ b/xt/selenium/keywords.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/selenium/login.t b/xt/selenium/login.t index b41d9a2d2..6e4586981 100644 --- a/xt/selenium/login.t +++ b/xt/selenium/login.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/selenium/milestones.t b/xt/selenium/milestones.t index 35991fbd2..6a9d7a015 100644 --- a/xt/selenium/milestones.t +++ b/xt/selenium/milestones.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/selenium/password_complexity.t b/xt/selenium/password_complexity.t index e29ef8bec..0e75e6b9d 100644 --- a/xt/selenium/password_complexity.t +++ b/xt/selenium/password_complexity.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/selenium/private_attachments.t b/xt/selenium/private_attachments.t index 4dacd26b3..51f09c4bc 100644 --- a/xt/selenium/private_attachments.t +++ b/xt/selenium/private_attachments.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/selenium/qa_contact.t b/xt/selenium/qa_contact.t index c548a7182..e036cfd14 100644 --- a/xt/selenium/qa_contact.t +++ b/xt/selenium/qa_contact.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/selenium/require_login.t b/xt/selenium/require_login.t index d661121b5..2e69f014f 100644 --- a/xt/selenium/require_login.t +++ b/xt/selenium/require_login.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/selenium/sanity_check.t b/xt/selenium/sanity_check.t index 93b039d41..918e458e0 100644 --- a/xt/selenium/sanity_check.t +++ b/xt/selenium/sanity_check.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/selenium/saved_searches.t b/xt/selenium/saved_searches.t index a18b7fd49..85f83a236 100644 --- a/xt/selenium/saved_searches.t +++ b/xt/selenium/saved_searches.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/selenium/search.t b/xt/selenium/search.t index c8fa9d770..eefae1629 100644 --- a/xt/selenium/search.t +++ b/xt/selenium/search.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/selenium/security.t b/xt/selenium/security.t index b89ea114e..576d87a95 100644 --- a/xt/selenium/security.t +++ b/xt/selenium/security.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/selenium/shared_searches.t b/xt/selenium/shared_searches.t index f9443fa98..909c2f34f 100644 --- a/xt/selenium/shared_searches.t +++ b/xt/selenium/shared_searches.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/selenium/show_all_products.t b/xt/selenium/show_all_products.t index 894554665..9634fddc0 100644 --- a/xt/selenium/show_all_products.t +++ b/xt/selenium/show_all_products.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/selenium/shutdown.t b/xt/selenium/shutdown.t index 8751cd614..5cd2f1a93 100644 --- a/xt/selenium/shutdown.t +++ b/xt/selenium/shutdown.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/selenium/status_whiteboard.t b/xt/selenium/status_whiteboard.t index 3ddda7b86..c7c0e6b5d 100644 --- a/xt/selenium/status_whiteboard.t +++ b/xt/selenium/status_whiteboard.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/selenium/strict_isolation.t b/xt/selenium/strict_isolation.t index ecd72b207..08ef87c74 100644 --- a/xt/selenium/strict_isolation.t +++ b/xt/selenium/strict_isolation.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/selenium/sudo_sessions.t b/xt/selenium/sudo_sessions.t index 5a1b7c98b..31a516ac1 100644 --- a/xt/selenium/sudo_sessions.t +++ b/xt/selenium/sudo_sessions.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/selenium/target_milestones.t b/xt/selenium/target_milestones.t index 6c5cf637f..a69a8cc7b 100644 --- a/xt/selenium/target_milestones.t +++ b/xt/selenium/target_milestones.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/selenium/time_summary.t b/xt/selenium/time_summary.t index f60c952ca..f8a16ca0b 100644 --- a/xt/selenium/time_summary.t +++ b/xt/selenium/time_summary.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/selenium/user_groups.t b/xt/selenium/user_groups.t index aa393d47b..0e06e95b7 100644 --- a/xt/selenium/user_groups.t +++ b/xt/selenium/user_groups.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/selenium/user_matching.t b/xt/selenium/user_matching.t index 90c2dc608..28f27a850 100644 --- a/xt/selenium/user_matching.t +++ b/xt/selenium/user_matching.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/selenium/user_preferences.t b/xt/selenium/user_preferences.t index 0d7d87a5c..5dce12c0e 100644 --- a/xt/selenium/user_preferences.t +++ b/xt/selenium/user_preferences.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/selenium/user_privs.t b/xt/selenium/user_privs.t index f48792839..e8ca54205 100644 --- a/xt/selenium/user_privs.t +++ b/xt/selenium/user_privs.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/selenium/votes.t b/xt/selenium/votes.t index e5a7c853d..7a67e93ed 100644 --- a/xt/selenium/votes.t +++ b/xt/selenium/votes.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/webservice/bug_add_attachment.t b/xt/webservice/bug_add_attachment.t index f08e42c6c..7a5aeeaa2 100644 --- a/xt/webservice/bug_add_attachment.t +++ b/xt/webservice/bug_add_attachment.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/webservice/bug_add_comment.t b/xt/webservice/bug_add_comment.t index 6f234b37a..70e5f4980 100644 --- a/xt/webservice/bug_add_comment.t +++ b/xt/webservice/bug_add_comment.t @@ -9,7 +9,7 @@ # Test for xmlrpc call to Bug.add_comment() # ############################################# -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/webservice/bug_attachments.t b/xt/webservice/bug_attachments.t index d5283685d..50e366635 100644 --- a/xt/webservice/bug_attachments.t +++ b/xt/webservice/bug_attachments.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/webservice/bug_comments.t b/xt/webservice/bug_comments.t index d66e445cf..6e573e56a 100644 --- a/xt/webservice/bug_comments.t +++ b/xt/webservice/bug_comments.t @@ -9,7 +9,7 @@ # Test for xmlrpc call to Bug.comments() # ########################################## -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/webservice/bug_create.t b/xt/webservice/bug_create.t index 6d7c8e14a..18751b50f 100644 --- a/xt/webservice/bug_create.t +++ b/xt/webservice/bug_create.t @@ -9,7 +9,7 @@ # Test for xmlrpc call to Bug.create() # ######################################## -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/webservice/bug_fields.t b/xt/webservice/bug_fields.t index 097a607f5..89374df6d 100644 --- a/xt/webservice/bug_fields.t +++ b/xt/webservice/bug_fields.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/webservice/bug_get.t b/xt/webservice/bug_get.t index e05fe2cb2..25576d00a 100644 --- a/xt/webservice/bug_get.t +++ b/xt/webservice/bug_get.t @@ -9,7 +9,7 @@ # Test for xmlrpc call to Bug.get() # ########################################### -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/webservice/bug_history.t b/xt/webservice/bug_history.t index 02ec1c11a..de1e8339c 100644 --- a/xt/webservice/bug_history.t +++ b/xt/webservice/bug_history.t @@ -9,7 +9,7 @@ # Test for xmlrpc call to Bug.history() # ######################################### -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/webservice/bug_legal_values.t b/xt/webservice/bug_legal_values.t index 2f775e528..fa7f3d01c 100644 --- a/xt/webservice/bug_legal_values.t +++ b/xt/webservice/bug_legal_values.t @@ -9,7 +9,7 @@ # Test for xmlrpc call to Bug.legal_values() # ############################################## -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/webservice/bug_search.t b/xt/webservice/bug_search.t index 93a517e24..4e346390b 100644 --- a/xt/webservice/bug_search.t +++ b/xt/webservice/bug_search.t @@ -9,7 +9,7 @@ # Test for xmlrpc call to Bug.search() # ######################################## -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/webservice/bug_update.t b/xt/webservice/bug_update.t index dfc2f89e1..10736ea12 100644 --- a/xt/webservice/bug_update.t +++ b/xt/webservice/bug_update.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/webservice/bug_update_see_also.t b/xt/webservice/bug_update_see_also.t index 79c3b5ea8..78b6e7bc8 100644 --- a/xt/webservice/bug_update_see_also.t +++ b/xt/webservice/bug_update_see_also.t @@ -9,7 +9,7 @@ # Test for xmlrpc call to Bug.update_see_also() # ################################################# -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/webservice/bugzilla.t b/xt/webservice/bugzilla.t index 2ddb13092..53c994c2f 100644 --- a/xt/webservice/bugzilla.t +++ b/xt/webservice/bugzilla.t @@ -9,7 +9,7 @@ # Test for xmlrpc call functions in Bugzilla.pm # ################################################## -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/webservice/group_create.t b/xt/webservice/group_create.t index e46546a31..dd6a174ef 100644 --- a/xt/webservice/group_create.t +++ b/xt/webservice/group_create.t @@ -9,7 +9,7 @@ # Test for xmlrpc call to Group.create() # ########################################## -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/webservice/jsonp.t b/xt/webservice/jsonp.t index 75a0c0cfb..210f92434 100644 --- a/xt/webservice/jsonp.t +++ b/xt/webservice/jsonp.t @@ -5,7 +5,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/webservice/product_create.t b/xt/webservice/product_create.t index 0ca117c31..b74e9b474 100644 --- a/xt/webservice/product_create.t +++ b/xt/webservice/product_create.t @@ -9,7 +9,7 @@ # Test for xmlrpc call to Product.create() # ############################################ -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/webservice/product_get.t b/xt/webservice/product_get.t index 5cc6022d5..101c109ef 100644 --- a/xt/webservice/product_get.t +++ b/xt/webservice/product_get.t @@ -13,7 +13,7 @@ # Product.get() # ######################################## -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/webservice/user_create.t b/xt/webservice/user_create.t index 38b55e69a..386826809 100644 --- a/xt/webservice/user_create.t +++ b/xt/webservice/user_create.t @@ -9,7 +9,7 @@ # Test for xmlrpc call to User.Create() # ######################################### -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/webservice/user_get.t b/xt/webservice/user_get.t index 02cf00fe7..01eedf804 100644 --- a/xt/webservice/user_get.t +++ b/xt/webservice/user_get.t @@ -9,7 +9,7 @@ # Test for xmlrpc call to User.get() # ###################################### -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/webservice/user_login_logout.t b/xt/webservice/user_login_logout.t index fd5f8ef6b..2fc659a65 100644 --- a/xt/webservice/user_login_logout.t +++ b/xt/webservice/user_login_logout.t @@ -9,7 +9,7 @@ # Test for xmlrpc call to User.login() and User.logout() # ########################################################## -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/xt/webservice/user_offer_account_by_email.t b/xt/webservice/user_offer_account_by_email.t index 785932167..ca2c8d1f3 100644 --- a/xt/webservice/user_offer_account_by_email.t +++ b/xt/webservice/user_offer_account_by_email.t @@ -9,7 +9,7 @@ # Test for xmlrpc call to User.offer_account_by_email() # ######################################################### -use 5.10.1; +use 5.14.0; use strict; use warnings; |