diff options
| -rwxr-xr-x | buglist.cgi | 3 | ||||
| -rw-r--r-- | template/en/default/global/user-error.html.tmpl | 6 |
2 files changed, 6 insertions, 3 deletions
diff --git a/buglist.cgi b/buglist.cgi index d226ec8a8..44565f1af 100755 --- a/buglist.cgi +++ b/buglist.cgi @@ -221,8 +221,9 @@ sub LookupNamedQuery { $name || ThrowUserError("query_name_missing"); trick_taint($name); if ($sharer_id) { - trick_taint($sharer_id); $owner_id = $sharer_id; + detaint_natural($owner_id); + $owner_id || ThrowUserError('illegal_user_id', {'userid' => $sharer_id}); } else { $owner_id = $user->id; diff --git a/template/en/default/global/user-error.html.tmpl b/template/en/default/global/user-error.html.tmpl index 58eaf5893..3fdc24d4d 100644 --- a/template/en/default/global/user-error.html.tmpl +++ b/template/en/default/global/user-error.html.tmpl @@ -966,7 +966,7 @@ [% docslinks = {'query.html' => "Searching for $terms.bugs", 'list.html' => "$terms.Bug lists"} %] The search named <em>[% queryname FILTER html %]</em> - [% IF sharer_id %] + [% IF sharer_id && sharer_id != user.id %] has not been made visible to you. [% ELSE %] does not exist. @@ -1521,8 +1521,10 @@ # search from any error call location. %] [% namedcmd = Bugzilla.cgi.param("namedcmd") %] +[% sharer_id = Bugzilla.cgi.param("sharer_id") %] [% IF namedcmd AND error != "missing_query" - AND error != "saved_search_used_by_whines" %] + AND error != "saved_search_used_by_whines" + AND !sharer_id %] <p> Alternatively, you can <a href="buglist.cgi?cmdtype=dorem&remaction=forget&namedcmd= |