1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
|
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
#
# This Source Code Form is "Incompatible With Secondary Licenses", as
# defined by the Mozilla Public License, v. 2.0.
package Bugzilla::Extension::Needinfo;
use strict;
use base qw(Bugzilla::Extension);
use Bugzilla::Error;
use Bugzilla::Flag;
use Bugzilla::FlagType;
use Bugzilla::User;
use Bugzilla::User::Setting;
our $VERSION = '0.01';
BEGIN {
*Bugzilla::User::needinfo_blocked = \&_user_needinfo_blocked;
}
sub _user_needinfo_blocked {
return $_[0]->settings->{block_needinfo}->{value} eq 'on';
}
sub install_update_db {
my ($self, $args) = @_;
my $dbh = Bugzilla->dbh;
if (@{ Bugzilla::FlagType::match({ name => 'needinfo' }) }) {
return;
}
print "Creating needinfo flag ... " .
"enable the Needinfo feature by editing the flag's properties.\n";
# Initially populate the list of exclusions as __Any__:__Any__ to
# allow admin to decide which products to enable the flag for.
my $flagtype = Bugzilla::FlagType->create({
name => 'needinfo',
description => "Set this flag when the bug is in need of additional information",
target_type => 'bug',
cc_list => '',
sortkey => 1,
is_active => 1,
is_requestable => 1,
is_requesteeble => 1,
is_multiplicable => 0,
request_group => '',
grant_group => '',
inclusions => [],
exclusions => ['0:0'],
});
}
sub install_before_final_checks {
my ($self, $args) = @_;
add_setting({
name => 'block_needinfo',
options => ['on', 'off'],
default => 'off',
category => 'Reviews and Needinfo'
});
}
# Clear the needinfo? flag if comment is being given by
# requestee or someone used the override flag.
sub bug_start_of_update {
my ($self, $args) = @_;
my $bug = $args->{bug};
my $old_bug = $args->{old_bug};
my $user = Bugzilla->user;
my $cgi = Bugzilla->cgi;
my $params = Bugzilla->input_params;
if ($params->{needinfo}) {
# do a match if applicable
Bugzilla::User::match_field({
'needinfo_from' => { 'type' => 'multi' }
});
}
# Set needinfo_done param to true so as to not loop back here
return if $params->{needinfo_done};
$params->{needinfo_done} = 1;
Bugzilla->input_params($params);
my $add_needinfo = delete $params->{needinfo};
my $needinfo_from = delete $params->{needinfo_from};
my $needinfo_role = delete $params->{needinfo_role};
my $is_private = $params->{'comment_is_private'};
my @needinfo_overrides;
foreach my $key (grep(/^needinfo_override_/, keys %$params)) {
my ($id) = $key =~ /(\d+)$/;
# Should always be true if key exists (checkbox) but better to be sure
push(@needinfo_overrides, $id) if $id && $params->{$key};
}
# Set the needinfo flag if user is requesting more information
my @new_flags;
my $needinfo_requestee;
if ($add_needinfo) {
foreach my $type (@{ $bug->flag_types }) {
next if $type->name ne 'needinfo';
my %requestees;
# Allow anyone to be the requestee
if (!$needinfo_role) {
$requestees{'anyone'} = 1;
}
# Use assigned_to as requestee
elsif ($needinfo_role eq 'assigned_to') {
$requestees{$bug->assigned_to->login} = 1;
}
# Use reporter as requestee
elsif ($needinfo_role eq 'reporter') {
$requestees{$bug->reporter->login} = 1;
}
# Use qa_contact as requestee
elsif ($needinfo_role eq 'qa_contact') {
$requestees{$bug->qa_contact->login} = 1;
}
# Use current user as requestee
elsif ($needinfo_role eq 'user') {
$requestees{$user->login} = 1;
}
# Use user specified requestee
elsif ($needinfo_role eq 'other' && $needinfo_from) {
my @needinfo_from_list = ref $needinfo_from
? @$needinfo_from :
($needinfo_from);
foreach my $requestee (@needinfo_from_list) {
my $requestee_obj = Bugzilla::User->check($requestee);
$requestees{$requestee_obj->login} = 1;
}
}
# Requestee is a mentor
elsif ($needinfo_role
&& Bugzilla::User->check({ name => $needinfo_role, cache => 1 }))
{
$requestees{$needinfo_role} = 1;
}
# Find out if the requestee has already been used and skip if so
my $requestee_found;
foreach my $flag (@{ $type->{flags} }) {
if (!$flag->requestee && $requestees{'anyone'}) {
delete $requestees{'anyone'};
}
if ($flag->requestee && $requestees{$flag->requestee->login}) {
delete $requestees{$flag->requestee->login};
}
}
foreach my $requestee (keys %requestees) {
my $needinfo_flag = { type_id => $type->id, status => '?' };
if ($requestee ne 'anyone') {
_check_requestee($requestee);
$needinfo_flag->{requestee} = $requestee;
}
push(@new_flags, $needinfo_flag);
}
}
}
my @flags;
foreach my $flag (@{ $bug->flags }) {
next if $flag->type->name ne 'needinfo';
# Clear if somehow the flag has been set to +/-
# or if the "clear needinfo" override checkbox is selected
if ($flag->status ne '?'
or grep { $_ == $flag->id } @needinfo_overrides)
{
push(@flags, { id => $flag->id, status => 'X' });
}
}
if (@flags || @new_flags) {
$bug->set_flags(\@flags, \@new_flags);
}
}
sub _check_requestee {
my ($requestee) = @_;
my $user = ref($requestee)
? $requestee
: Bugzilla::User->new({ name => $requestee, cache => 1 });
if ($user->needinfo_blocked) {
ThrowUserError('needinfo_blocked', { requestee => $user });
}
}
sub object_end_of_create {
my ($self, $args) = @_;
my $object = $args->{object};
return unless $object->isa('Bugzilla::Flag')
&& $object->type->name eq 'needinfo'
&& $object->requestee;
_check_requestee($object->requestee);
}
sub object_end_of_update {
my ($self, $args) = @_;
my $object = $args->{object};
return unless exists $args->{changes}->{requestee_id}
&& $object->isa('Bugzilla::Flag')
&& $object->type->name eq 'needinfo'
&& $object->requestee;
_check_requestee($object->requestee);
}
sub object_before_delete {
my ($self, $args) = @_;
my $object = $args->{object};
return unless $object->isa('Bugzilla::Flag')
&& $object->type->name eq 'needinfo';
my $user = Bugzilla->user;
# Require canconfirm to clear requests targetted at someone else
if ($object->setter_id != $user->id
&& $object->requestee
&& $object->requestee->id != $user->id
&& !$user->in_group('canconfirm'))
{
ThrowUserError('needinfo_illegal_change');
}
}
sub user_preferences {
my ($self, $args) = @_;
return unless
$args->{current_tab} eq 'account'
&& $args->{save_changes};
my $input = Bugzilla->input_params;
my $settings = Bugzilla->user->settings;
my $value = $input->{block_needinfo} ? 'on' : 'off';
$settings->{block_needinfo}->validate_value($value);
$settings->{block_needinfo}->set($value);
clear_settings_cache(Bugzilla->user->id);
}
__PACKAGE__->NAME;
|
