1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
|
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
#
# This Source Code Form is "Incompatible With Secondary Licenses", as
# defined by the Mozilla Public License, v. 2.0.
package Bugzilla::Extension::Push;
use strict;
use warnings;
use base qw(Bugzilla::Extension);
use Bugzilla::Constants;
use Bugzilla::Comment;
use Bugzilla::Error;
use Bugzilla::Extension::Push::Admin;
use Bugzilla::Extension::Push::Connectors;
use Bugzilla::Extension::Push::Logger;
use Bugzilla::Extension::Push::Message;
use Bugzilla::Extension::Push::Push;
use Bugzilla::Extension::Push::Serialise;
use Bugzilla::Extension::Push::Util;
use Bugzilla::Install::Filesystem;
use Encode;
use Scalar::Util 'blessed';
use Storable 'dclone';
our $VERSION = '1';
$Carp::CarpInternal{'CGI::Carp'} = 1;
#
# monkey patch for convience
#
BEGIN {
*Bugzilla::push_ext = \&_get_instance;
}
sub _get_instance {
my $cache = Bugzilla->request_cache;
if (!$cache->{'push.instance'}) {
my $instance = Bugzilla::Extension::Push::Push->new();
$cache->{'push.instance'} = $instance;
$instance->logger(Bugzilla::Extension::Push::Logger->new());
$instance->connectors(Bugzilla::Extension::Push::Connectors->new());
}
return $cache->{'push.instance'};
}
#
# enabled
#
sub _enabled {
my ($self) = @_;
if (!exists $self->{'enabled'}) {
my $push = Bugzilla->push_ext;
$self->{'enabled'} = $push->config->{enabled} eq 'Enabled';
if ($self->{'enabled'}) {
# if no connectors are enabled, no need to push anything
$self->{'enabled'} = 0;
foreach my $connector (Bugzilla->push_ext->connectors->list) {
if ($connector->enabled) {
$self->{'enabled'} = 1;
last;
}
}
}
}
return $self->{'enabled'};
}
#
# deal with creation and updated events
#
sub _object_created {
my ($self, $args) = @_;
my $object = _get_object_from_args($args);
return unless $object;
return unless _should_push($object);
$self->_push_object('create', $object, change_set_id(), { timestamp => $args->{'timestamp'} });
}
sub _object_modified {
my ($self, $args) = @_;
my $object = _get_object_from_args($args);
return unless $object;
return unless _should_push($object);
my $changes = $args->{'changes'} || {};
return unless scalar keys %$changes;
my $change_set = change_set_id();
# detect when a bug changes from public to private (or back), so connectors
# can remove now-private bugs if required.
if ($object->isa('Bugzilla::Bug')) {
# we can't use user->can_see_bug(old_bug) as that works on IDs, and the
# bug has already been updated, so for now assume that a bug without
# groups is public.
my $old_bug = $args->{'old_bug'};
my $is_public = is_public($object);
my $was_public = $old_bug ? !@{$old_bug->groups_in} : $is_public;
if (!$is_public && $was_public) {
# bug is changing from public to private
# push a fake update with the just is_private change
my $private_changes = {
timestamp => $args->{'timestamp'},
changes => [
{
field => 'is_private',
removed => '0',
added => '1',
},
],
};
# note we're sending the old bug object so we don't leak any
# security sensitive information.
$self->_push_object('modify', $old_bug, $change_set, $private_changes);
} elsif ($is_public && !$was_public) {
# bug is changing from private to public
# push a fake update with the just is_private change
my $private_changes = {
timestamp => $args->{'timestamp'},
changes => [
{
field => 'is_private',
removed => '1',
added => '0',
},
],
};
# it's ok to send the new bug state here
$self->_push_object('modify', $object, $change_set, $private_changes);
}
}
# make flagtypes changes easier to process
if (exists $changes->{'flagtypes.name'}) {
_split_flagtypes($changes);
}
# TODO split group changes?
# restructure the changes hash
my $changes_data = {
timestamp => $args->{'timestamp'},
changes => [],
};
foreach my $field_name (sort keys %$changes) {
my $new_field_name = $field_name;
$new_field_name =~ s/isprivate/is_private/;
push @{$changes_data->{'changes'}}, {
field => $new_field_name,
removed => $changes->{$field_name}[0],
added => $changes->{$field_name}[1],
};
}
$self->_push_object('modify', $object, $change_set, $changes_data);
}
sub _get_object_from_args {
my ($args) = @_;
return get_first_value($args, qw(object bug flag group));
}
sub _should_push {
my ($object_or_class) = @_;
my $class = blessed($object_or_class) || $object_or_class;
return grep { $_ eq $class } qw(Bugzilla::Bug Bugzilla::Attachment Bugzilla::Comment);
}
# changes to bug flags are presented in a single field 'flagtypes.name' split
# into individual fields
sub _split_flagtypes {
my ($changes) = @_;
my @removed = _split_flagtype($changes->{'flagtypes.name'}->[0]);
my @added = _split_flagtype($changes->{'flagtypes.name'}->[1]);
delete $changes->{'flagtypes.name'};
foreach my $ra (@removed, @added) {
$changes->{$ra->[0]} = ['', ''];
}
foreach my $ra (@removed) {
my ($name, $value) = @$ra;
$changes->{$name}->[0] = $value;
}
foreach my $ra (@added) {
my ($name, $value) = @$ra;
$changes->{$name}->[1] = $value;
}
}
sub _split_flagtype {
my ($value) = @_;
my @result;
foreach my $change (split(/, /, $value)) {
my $requestee = '';
if ($change =~ s/\(([^\)]+)\)$//) {
$requestee = $1;
}
my ($name, $value) = $change =~ /^(.+)(.)$/;
$value .= " ($requestee)" if $requestee;
push @result, [ "flag.$name", $value ];
}
return @result;
}
# changes to attachment flags come in via flag_end_of_update which has a
# completely different structure for reporting changes than
# object_end_of_update. this morphs flag to object updates.
sub _morph_flag_updates {
my ($args) = @_;
my @removed = _morph_flag_update($args->{'old_flags'});
my @added = _morph_flag_update($args->{'new_flags'});
my $changes = {};
foreach my $ra (@removed, @added) {
$changes->{$ra->[0]} = ['', ''];
}
foreach my $ra (@removed) {
my ($name, $value) = @$ra;
$changes->{$name}->[0] = $value;
}
foreach my $ra (@added) {
my ($name, $value) = @$ra;
$changes->{$name}->[1] = $value;
}
foreach my $flag (keys %$changes) {
if ($changes->{$flag}->[0] eq $changes->{$flag}->[1]) {
delete $changes->{$flag};
}
}
$args->{'changes'} = $changes;
}
sub _morph_flag_update {
my ($values) = @_;
my @result;
foreach my $orig_change (@$values) {
my $change = $orig_change; # work on a copy
$change =~ s/^[^:]+://;
my $requestee = '';
if ($change =~ s/\(([^\)]+)\)$//) {
$requestee = $1;
}
my ($name, $value) = $change =~ /^(.+)(.)$/;
$value .= " ($requestee)" if $requestee;
push @result, [ "flag.$name", $value ];
}
return @result;
}
#
# serialise and insert into the table
#
sub _push_object {
my ($self, $message_type, $object, $change_set, $changes) = @_;
my $rh;
# serialise the object
my ($rh_object, $name) = Bugzilla::Extension::Push::Serialise->instance->object_to_hash($object);
if (!$rh_object) {
warn "empty hash from serialiser ($message_type $object)\n";
return;
}
$rh->{$name} = $rh_object;
# add in the events hash
my $rh_event = Bugzilla::Extension::Push::Serialise->instance->changes_to_event($changes);
return unless $rh_event;
$rh_event->{'action'} = $message_type;
$rh_event->{'target'} = $name;
$rh_event->{'change_set'} = $change_set;
$rh_event->{'routing_key'} = "$name.$message_type";
if (exists $rh_event->{'changes'}) {
$rh_event->{'routing_key'} .= ':' . join(',', map { $_->{'field'} } @{$rh_event->{'changes'}});
}
$rh->{'event'} = $rh_event;
# create message object
my $message = Bugzilla::Extension::Push::Message->new_transient({
payload => to_json($rh),
change_set => $change_set,
routing_key => $rh_event->{'routing_key'},
});
# don't hit the database unless there are interested connectors
my $should_push = 0;
foreach my $connector (Bugzilla->push_ext->connectors->list) {
next unless $connector->enabled;
next unless $connector->should_send($message);
$should_push = 1;
last;
}
return unless $should_push;
# insert into push table
$message->create_from_transient();
}
#
# update/create hooks
#
sub object_end_of_create {
my ($self, $args) = @_;
return unless $self->_enabled;
# it's better to process objects from a non-generic end_of_create where
# possible; don't process them here to avoid duplicate messages
my $object = _get_object_from_args($args);
return if !$object ||
$object->isa('Bugzilla::Bug') ||
blessed($object) =~ /^Bugzilla::Extension/;
$self->_object_created($args);
}
sub object_end_of_update {
my ($self, $args) = @_;
# User objects are updated with every page load (to touch the session
# token). Because we ignore user objects, there's no need to create an
# instance of Push to check if we're enabled.
my $object = _get_object_from_args($args);
return if !$object || $object->isa('Bugzilla::User');
return unless $self->_enabled;
# it's better to process objects from a non-generic end_of_update where
# possible; don't process them here to avoid duplicate messages
return if $object->isa('Bugzilla::Bug') ||
$object->isa('Bugzilla::Flag') ||
blessed($object) =~ /^Bugzilla::Extension/;
$self->_object_modified($args);
}
# process bugs once they are fully formed
# object_end_of_update is triggered while a bug is being created
sub bug_end_of_create {
my ($self, $args) = @_;
return unless $self->_enabled;
$self->_object_created($args);
}
sub bug_end_of_update {
my ($self, $args) = @_;
return unless $self->_enabled;
$self->_object_modified($args);
}
sub flag_end_of_update {
my ($self, $args) = @_;
return unless $self->_enabled;
_morph_flag_updates($args);
$self->_object_modified($args);
delete $args->{changes};
}
# comments in bugzilla 4.0 doesn't aren't included in the bug_end_of_* hooks,
# this code uses custom hooks to trigger
sub bug_comment_create {
my ($self, $args) = @_;
return unless $self->_enabled;
return unless _should_push('Bugzilla::Comment');
my $bug = $args->{'bug'} or return;
my $timestamp = $args->{'timestamp'} or return;
my $comments = Bugzilla::Comment->match({ bug_id => $bug->id, bug_when => $timestamp });
foreach my $comment (@$comments) {
if ($comment->body ne '') {
$self->_push_object('create', $comment, change_set_id(), { timestamp => $timestamp });
}
}
}
sub bug_comment_update {
my ($self, $args) = @_;
return unless $self->_enabled;
return unless _should_push('Bugzilla::Comment');
my $bug = $args->{'bug'} or return;
my $timestamp = $args->{'timestamp'} or return;
my $comment_id = $args->{'comment_id'};
if ($comment_id) {
# XXX this should set changes. only is_private changes will trigger this event
my $comment = Bugzilla::Comment->new($comment_id);
$self->_push_object('update', $comment, change_set_id(), { timestamp => $timestamp });
} else {
# when a bug is created, an update is also triggered; we don't want to sent
# update messages for the initial comment, or for empty comments
my $comments = Bugzilla::Comment->match({ bug_id => $bug->id, bug_when => $timestamp });
foreach my $comment (@$comments) {
if ($comment->body ne '' && $comment->count) {
$self->_push_object('create', $comment, change_set_id(), { timestamp => $timestamp });
}
}
}
}
#
# admin hooks
#
sub page_before_template {
my ($self, $args) = @_;
my $page = $args->{'page_id'};
my $vars = $args->{'vars'};
if ($page eq 'push_config.html') {
Bugzilla->user->in_group('admin')
|| ThrowUserError('auth_failure',
{ group => 'admin',
action => 'access',
object => 'administrative_pages' });
admin_config($vars);
} elsif ($page eq 'push_queues.html'
|| $page eq 'push_queues_view.html'
) {
Bugzilla->user->in_group('admin')
|| ThrowUserError('auth_failure',
{ group => 'admin',
action => 'access',
object => 'administrative_pages' });
admin_queues($vars, $page);
} elsif ($page eq 'push_log.html') {
Bugzilla->user->in_group('admin')
|| ThrowUserError('auth_failure',
{ group => 'admin',
action => 'access',
object => 'administrative_pages' });
admin_log($vars);
}
}
#
# installation/config hooks
#
sub db_schema_abstract_schema {
my ($self, $args) = @_;
$args->{'schema'}->{'push'} = {
FIELDS => [
id => {
TYPE => 'MEDIUMSERIAL',
NOTNULL => 1,
PRIMARYKEY => 1,
},
push_ts => {
TYPE => 'DATETIME',
NOTNULL => 1,
},
payload => {
TYPE => 'LONGTEXT',
NOTNULL => 1,
},
change_set => {
TYPE => 'VARCHAR(32)',
NOTNULL => 1,
},
routing_key => {
TYPE => 'VARCHAR(64)',
NOTNULL => 1,
},
],
};
$args->{'schema'}->{'push_backlog'} = {
FIELDS => [
id => {
TYPE => 'MEDIUMSERIAL',
NOTNULL => 1,
PRIMARYKEY => 1,
},
message_id => {
TYPE => 'INT3',
NOTNULL => 1,
},
push_ts => {
TYPE => 'DATETIME',
NOTNULL => 1,
},
payload => {
TYPE => 'LONGTEXT',
NOTNULL => 1,
},
change_set => {
TYPE => 'VARCHAR(32)',
NOTNULL => 1,
},
routing_key => {
TYPE => 'VARCHAR(64)',
NOTNULL => 1,
},
connector => {
TYPE => 'VARCHAR(32)',
NOTNULL => 1,
},
attempt_ts => {
TYPE => 'DATETIME',
},
attempts => {
TYPE => 'INT2',
NOTNULL => 1,
},
last_error => {
TYPE => 'MEDIUMTEXT',
},
],
INDEXES => [
push_backlog_idx => {
FIELDS => ['message_id', 'connector'],
TYPE => 'UNIQUE',
},
],
};
$args->{'schema'}->{'push_backoff'} = {
FIELDS => [
id => {
TYPE => 'MEDIUMSERIAL',
NOTNULL => 1,
PRIMARYKEY => 1,
},
connector => {
TYPE => 'VARCHAR(32)',
NOTNULL => 1,
},
next_attempt_ts => {
TYPE => 'DATETIME',
},
attempts => {
TYPE => 'INT2',
NOTNULL => 1,
},
],
INDEXES => [
push_backoff_idx => {
FIELDS => ['connector'],
TYPE => 'UNIQUE',
},
],
};
$args->{'schema'}->{'push_options'} = {
FIELDS => [
id => {
TYPE => 'MEDIUMSERIAL',
NOTNULL => 1,
PRIMARYKEY => 1,
},
connector => {
TYPE => 'VARCHAR(32)',
NOTNULL => 1,
},
option_name => {
TYPE => 'VARCHAR(32)',
NOTNULL => 1,
},
option_value => {
TYPE => 'VARCHAR(255)',
NOTNULL => 1,
},
],
INDEXES => [
push_options_idx => {
FIELDS => ['connector', 'option_name'],
TYPE => 'UNIQUE',
},
],
};
$args->{'schema'}->{'push_log'} = {
FIELDS => [
id => {
TYPE => 'MEDIUMSERIAL',
NOTNULL => 1,
PRIMARYKEY => 1,
},
message_id => {
TYPE => 'INT3',
NOTNULL => 1,
},
change_set => {
TYPE => 'VARCHAR(32)',
NOTNULL => 1,
},
routing_key => {
TYPE => 'VARCHAR(64)',
NOTNULL => 1,
},
connector => {
TYPE => 'VARCHAR(32)',
NOTNULL => 1,
},
push_ts => {
TYPE => 'DATETIME',
NOTNULL => 1,
},
processed_ts => {
TYPE => 'DATETIME',
NOTNULL => 1,
},
result => {
TYPE => 'INT1',
NOTNULL => 1,
},
data => {
TYPE => 'MEDIUMTEXT',
},
],
};
}
sub install_filesystem {
my ($self, $args) = @_;
my $files = $args->{'files'};
my $extensionsdir = bz_locations()->{'extensionsdir'};
my $scriptname = $extensionsdir . "/Push/bin/bugzilla-pushd.pl";
$files->{$scriptname} = {
perms => Bugzilla::Install::Filesystem::WS_EXECUTE
};
}
sub db_sanitize {
my $dbh = Bugzilla->dbh;
print "Deleting push extension logs and messages...\n";
$dbh->do("DELETE FROM push");
$dbh->do("DELETE FROM push_backlog");
$dbh->do("DELETE FROM push_backoff");
$dbh->do("DELETE FROM push_log");
$dbh->do("DELETE FROM push_options");
}
__PACKAGE__->NAME;
|