1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
|
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
#
# This Source Code Form is "Incompatible With Secondary Licenses", as
# defined by the Mozilla Public License, v. 2.0.
# -*- Mode: perl; indent-tabs-mode: nil -*-
package QA::RPC;
use 5.14.0;
use strict;
use warnings;
use FindBin qw($RealBin);
use lib "$RealBin/../../lib", "$RealBin/../../../local/lib/perl5";
use Data::Dumper;
use QA::Util;
use QA::Tests qw(PRIVATE_BUG_USER create_bug_fields);
use Storable qw(dclone);
use Test::More;
sub bz_config {
my $self = shift;
$self->{bz_config} ||= QA::Util::get_config();
return $self->{bz_config};
}
# True if we're doing calls over GET instead of POST.
sub bz_get_mode { return 0 }
# When doing bz_log_in over GET, we can't actually call User.login,
# we just store credentials here and then pass them as Bugzilla_login
# and Bugzilla_password with every future call until User.logout is called
# (which actually just calls _bz_clear_credentials, under GET).
sub _bz_credentials {
my ($self, $user, $pass) = @_;
if (@_ == 3) {
$self->{_bz_credentials}->{user} = $user;
$self->{_bz_credentials}->{pass} = $pass;
}
return $self->{_bz_credentials};
}
sub _bz_clear_credentials { delete $_[0]->{_bz_credentials} }
################################
# Helpers for RPC test scripts #
################################
sub bz_log_in {
my ($self, $user) = @_;
my $username = $self->bz_config->{"${user}_user_login"};
my $password = $self->bz_config->{"${user}_user_passwd"};
if ($self->bz_get_mode) {
$self->_bz_credentials($username, $password);
return;
}
my $call = $self->bz_call_success(
'User.login', { login => $username, password => $password });
cmp_ok($call->result->{id}, 'gt', 0, $self->TYPE . ": Logged in as $user");
$self->{_bz_credentials}->{token} = $call->result->{token};
}
sub bz_call_success {
my ($self, $method, $orig_args, $test_name) = @_;
my $args = $orig_args ? dclone($orig_args) : {};
if ($self->bz_get_mode and $method eq 'User.logout') {
$self->_bz_clear_credentials();
return;
}
my $call;
# Under XMLRPC::Lite, if we pass undef as the second argument,
# it sends a single param <value />, which shows up as an
# empty string on the Bugzilla side.
if ($self->{_bz_credentials}->{token}) {
$args->{Bugzilla_token} = $self->{_bz_credentials}->{token};
}
if (scalar keys %$args) {
$call = $self->call($method, $args);
}
else {
$call = $self->call($method);
}
$test_name ||= "$method returned successfully";
$self->_handle_undef_response($test_name) if !$call;
ok(!$call->fault, $self->TYPE . ": $test_name")
or diag($call->faultstring);
if ($method eq 'User.logout') {
delete $self->{_bz_credentials}->{token};
}
return $call;
}
sub bz_call_fail {
my ($self, $method, $orig_args, $faultstring, $test_name) = @_;
my $args = $orig_args ? dclone($orig_args) : {};
if ($self->{_bz_credentials}->{token}) {
$args->{Bugzilla_token} = $self->{_bz_credentials}->{token};
}
$test_name ||= "$method failed (as intended)";
my $call = $self->call($method, $args);
$self->_handle_undef_response($test_name) if !$call;
ok($call->fault, $self->TYPE . ": $test_name")
or diag("Returned: " . Dumper($call->result));
if (defined $faultstring) {
cmp_ok(trim($call->faultstring), '=~', $faultstring,
$self->TYPE . ": Got correct fault for $method");
}
ok($call->faultcode
&& (($call->faultcode < 32000 && $call->faultcode > -32000)
# Fault codes 32610 and above are OK because they are errors
# that we expect and test for sometimes.
|| $call->faultcode >= 32610),
$self->TYPE . ': Fault code is set properly')
or diag("Code: " . $call->faultcode
. " Message: " . $call->faultstring);
return $call;
}
sub _handle_undef_response {
my ($self, $test_name) = @_;
my $response = $self->transport->http_response;
die "$test_name:\n", $response->as_string;
}
sub bz_get_products {
my ($self) = @_;
$self->bz_log_in('QA_Selenium_TEST');
my $accessible = $self->bz_call_success('Product.get_accessible_products');
my $prod_call = $self->bz_call_success('Product.get', $accessible->result);
my %products;
foreach my $prod (@{ $prod_call->result->{products} }) {
$products{$prod->{name}} = $prod->{id};
}
$self->bz_call_success('User.logout');
return \%products;
}
sub _string_array { map { random_string() } (1..$_[0]) }
sub bz_create_test_bugs {
my ($self, $second_private) = @_;
my $config = $self->bz_config;
my @whiteboard_strings = _string_array(3);
my @summary_strings = _string_array(3);
my $public_bug = create_bug_fields($config);
$public_bug->{whiteboard} = join(' ', @whiteboard_strings);
$public_bug->{summary} = join(' ', @summary_strings);
my $private_bug = dclone($public_bug);
if ($second_private) {
$private_bug->{product} = 'QA-Selenium-TEST';
$private_bug->{component} = 'QA-Selenium-TEST';
$private_bug->{target_milestone} = 'QAMilestone';
$private_bug->{version} = 'QAVersion';
# Although we don't directly use this, this helps some tests that
# depend on the values in $private_bug.
$private_bug->{creator} = $config->{PRIVATE_BUG_USER . '_user_login'};
}
my @create_bugs = (
{ user => 'editbugs',
args => $public_bug,
test => 'Create a public bug' },
{ user => $second_private ? PRIVATE_BUG_USER : 'editbugs',
args => $private_bug,
test => $second_private ? 'Create a private bug'
: 'Create a second public bug' },
);
my $post_success = sub {
my ($call, $t) = @_;
my $id = $call->result->{id};
$t->{args}->{id} = $id;
};
# Creating the bugs isn't really a test, it's just preliminary work
# for the tests. So we just run it with one of the RPC clients.
$self->bz_run_tests(tests => \@create_bugs, method => 'Bug.create',
post_success => $post_success);
return ($public_bug, $private_bug);
}
sub bz_run_tests {
my ($self, %params) = @_;
# Required params
my $config = $self->bz_config;
my $tests = $params{tests};
my $method = $params{method};
# Optional params
my $post_success = $params{post_success};
my $pre_call = $params{pre_call};
my $former_user = '';
foreach my $t (@$tests) {
# Only logout/login if the user has changed since the last test
# (this saves us LOTS of needless logins).
my $user = $t->{user} || '';
if ($former_user ne $user) {
$self->bz_call_success('User.logout') if $former_user;
$self->bz_log_in($user) if $user;
$former_user = $user;
}
$pre_call->($t, $self) if $pre_call;
if ($t->{error}) {
$self->bz_call_fail($method, $t->{args}, $t->{error}, $t->{test});
}
else {
my $call = $self->bz_call_success($method, $t->{args}, $t->{test});
if ($call->result && $post_success) {
$post_success->($call, $t, $self);
}
}
}
$self->bz_call_success('User.logout') if $former_user;
}
sub bz_test_bug {
my ($self, $fields, $bug, $expect, $t, $creation_time) = @_;
foreach my $field (sort @$fields) {
# "description" is used by Bug.create but comments are not returned
# by Bug.get or Bug.search.
next if $field eq 'description';
my @include = @{ $t->{args}->{include_fields} || [] };
my @exclude = @{ $t->{args}->{exclude_fields} || [] };
if ( (@include and !grep($_ eq $field, @include))
or (@exclude and grep($_ eq $field, @exclude)) )
{
ok(!exists $bug->{$field}, "$field is not included")
or diag Dumper($bug);
next;
}
if ($field =~ /^is_/) {
ok(defined $bug->{$field}, $self->TYPE . ": $field is not null");
is($bug->{$field} ? 1 : 0, $expect->{$field} ? 1 : 0,
$self->TYPE . ": $field has the right boolean value");
}
elsif ($field eq 'cc') {
foreach my $cc_item (@{ $expect->{cc} || [] }) {
ok(grep($_ eq $cc_item, @{ $bug->{cc} }),
$self->TYPE . ": $field contains $cc_item");
}
}
elsif ($field eq 'creation_time' or $field eq 'last_change_time') {
my $creation_day;
# XML-RPC and JSON-RPC have different date formats.
if ($self->isa('QA::RPC::XMLRPC')) {
$creation_day = $creation_time->ymd('');
}
else {
$creation_day = $creation_time->ymd;
}
like($bug->{$field}, qr/^\Q${creation_day}\ET\d\d:\d\d:\d\d/,
$self->TYPE . ": $field has the right format");
}
else {
is_deeply($bug->{$field}, $expect->{$field},
$self->TYPE . ": $field value is correct");
}
}
}
1;
__END__
|