Bye Travis, Hello GH Actions

8 files changed, 141 insertions, 141 deletions

diff --git a/.github/workflows/test-phpunit.yml b/.github/workflows/test-phpunit.yml
new file mode 100644
index 000000000..3468dfdfb
--- /dev/null
+++ b/.github/workflows/test-phpunit.yml
@@ -0,0 +1,119 @@
+name: PHPUnit
+
+on: [push, pull_request]
+
+jobs:
+  tests:
+    runs-on: ubuntu-18.04
+    if: "!contains(github.event.head_commit.message, '[ci skip]')"
+    env:
+      PHP_INI_VALUES: assert.exception=1, zend.assertions=1
+
+    strategy:
+      fail-fast: false
+      matrix:
+        php: [ '8.1', '8.0', '7.4', '7.3', '7.2', '7.1', '7.0', '5.6', '5.5', '5.4' ]
+        DB: [ 'pdo/mysql', 'pdo/pgsql', 'pdo/sqlite', 'mysqli', 'pgsql', 'sqlite' ]
+        compiler: [ default ]
+        include:
+          - php: '8.1'
+            DB: 'pdo/mysql'
+            compiler: jit
+          - php: '8.1'
+            DB: 'pdo/pgsql'
+            compiler: jit
+          - php: '8.1'
+            DB: 'pdo/sqlite'
+            compiler: jit
+          - php: '8.1'
+            DB: 'mysqli'
+            compiler: jit
+          - php: '8.1'
+            DB: 'pgsql'
+            compiler: jit
+          - php: '8.1'
+            DB: 'sqlite'
+            compiler: jit
+          - php: '8.0'
+            DB: 'pdo/mysql'
+            compiler: jit
+          - php: '8.0'
+            DB: 'pdo/pgsql'
+            compiler: jit
+          - php: '8.0'
+            DB: 'pdo/sqlite'
+            compiler: jit
+          - php: '8.0'
+            DB: 'mysqli'
+            compiler: jit
+          - php: '8.0'
+            DB: 'pgsql'
+            compiler: jit
+          - php: '8.0'
+            DB: 'sqlite'
+            compiler: jit
+          - php: '5.6'
+            DB: 'mysql'
+            compiler: default
+          - php: '5.5'
+            DB: 'mysql'
+            compiler: default
+          - php: '5.4'
+            DB: 'mysql'
+            compiler: default
+
+    services:
+      postgres:
+        image: postgres:12
+        env:
+          POSTGRES_USER: postgres
+          POSTGRES_PASSWORD: postgres
+          POSTGRES_DB: ci_test
+        ports:
+          - 5432:5432
+        options: --health-cmd=pg_isready --health-interval=10s --health-timeout=5s --health-retries=3
+
+      mysql:
+        image: mysql:5.7
+        env:
+          MYSQL_ALLOW_EMPTY_PASSWORD: true
+          MYSQL_USER: travis
+          MYSQL_PASSWORD: travis
+          MYSQL_DATABASE: ci_test
+        ports:
+          - 3306:3306
+        options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+      - name: Override PHP ini values for JIT compiler
+        if: matrix.compiler == 'jit'
+        run: echo "PHP_INI_VALUES::assert.exception=1, zend.assertions=1, opcache.enable=1, opcache.enable_cli=1, opcache.optimization_level=-1, opcache.jit=1255, opcache.jit_buffer_size=64M" >> $GITHUB_ENV 
+
+      - name: Install PHP${{ matrix.php }} - DB ${{ matrix.DB }}
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: ${{ matrix.php }}
+          tools: composer, pecl
+          extensions: imagick, sqlite3, pgsql, mysqli, pdo, pdo_mysql, pdo_pgsql, pdo_sqlite, mbstring
+          ini-values: ${{ env.PHP_INI_VALUES }}
+          coverage: xdebug
+
+      - name: Get composer cache directory
+        id: composer-cache
+        run: echo "::set-output name=dir::$(composer config cache-files-dir)"
+      - name: Cache composer dependencies
+        uses: actions/cache@v2
+        with:
+          path: ${{ steps.composer-cache.outputs.dir }}
+          key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
+          restore-keys: ${{ runner.os }}-composer-   
+      - name: Install composer dependencies
+        run: composer install --no-progress --prefer-dist --optimize-autoloader
+
+      - name: PHPUnit Test
+        run: |
+          php -d zend.enable_gc=0 -d date.timezone=UTC -d mbstring.func_overload=7 -d mbstring.internal_encoding=UTF-8 vendor/bin/phpunit --coverage-text --configuration tests/travis/${{ matrix.DB }}.phpunit.xml
+        env:
+          XDEBUG_MODE: coverage
diff --git a/.travis.yml b/.travis.yml
deleted file mode 100644
index ee717ab9a..000000000
--- a/.travis.yml
+++ /dev/null
@@ -1,133 +0,0 @@
-language: php
-os: linux
-dist: xenial
-
-php:
-  - 5.6
-  - 7.0
-  - 7.1
-  - 7.2
-  - 7.3
-  - 7.4
-  - nightly
-
-env:
-  global:
-    - XDEBUG_MODE=coverage
-  jobs:
-    - DB=mysqli
-    - DB=pgsql
-    - DB=sqlite
-    - DB=pdo/mysql
-    - DB=pdo/pgsql
-    - DB=pdo/sqlite
-
-services:
-  - mysql
-  - postgresql
-
-cache:
-  directories:
-    - $HOME/.composer/cache
-
-before_script:
-  - sh -c "composer install --no-progress"
-  - sh -c "if [ '$DB' = 'pgsql' ] || [ '$DB' = 'pdo/pgsql' ]; then psql -c 'DROP DATABASE IF EXISTS ci_test;' -U postgres; fi"
-  - sh -c "if [ '$DB' = 'pgsql' ] || [ '$DB' = 'pdo/pgsql' ]; then psql -c 'create database ci_test;' -U postgres; fi"
-  - sh -c "if [ '$DB' = 'mysql' ] || [ '$DB' = 'mysqli' ] || [ '$DB' = 'pdo/mysql' ]; then mysql -e 'create database IF NOT EXISTS ci_test;'; fi"
-
-script: test $(php -r 'echo PHP_VERSION_ID;') -lt 70300 && php -d zend.enable_gc=0 -d date.timezone=UTC -d mbstring.func_overload=7 -d mbstring.internal_encoding=UTF-8 vendor/bin/phpunit --coverage-text --configuration tests/travis/$DB.phpunit.xml || php -d zend.enable_gc=0 -d date.timezone=UTC -d mbstring.internal_encoding=UTF-8 vendor/bin/phpunit --coverage-text --configuration tests/travis/$DB.phpunit.xml
-
-jobs:
-  allow_failures:
-    - php: nightly
-    - php: hhvm-3.30
-  include:
-    - php: 5.3
-      dist: precise
-      env: DB=mysql
-    - php: 5.3
-      dist: precise
-      env: DB=mysqli
-    - php: 5.3
-      dist: precise
-      env: DB=pgsql
-    - php: 5.3
-      dist: precise
-      env: DB=sqlite
-    - php: 5.3
-      dist: precise
-      env: DB=pdo/mysql
-    - php: 5.3
-      dist: precise
-      env: DB=pdo/pgsql
-    - php: 5.3
-      dist: precise
-      env: DB=pdo/sqlite
-    - php: 5.4
-      dist: trusty
-      env: DB=mysql
-    - php: 5.4
-      dist: trusty
-      env: DB=mysqli
-    - php: 5.4
-      dist: trusty
-      env: DB=pgsql
-    - php: 5.4
-      dist: trusty
-      env: DB=sqlite
-    - php: 5.4
-      dist: trusty
-      env: DB=pdo/mysql
-    - php: 5.4
-      dist: trusty
-      env: DB=pdo/pgsql
-    - php: 5.4
-      dist: trusty
-      env: DB=pdo/sqlite
-    - php: 5.5
-      dist: trusty
-      env: DB=mysql
-    - php: 5.5
-      dist: trusty
-      env: DB=mysqli
-    - php: 5.5
-      dist: trusty
-      env: DB=pgsql
-    - php: 5.5
-      dist: trusty
-      env: DB=sqlite
-    - php: 5.5
-      dist: trusty
-      env: DB=pdo/mysql
-    - php: 5.5
-      dist: trusty
-      env: DB=pdo/pgsql
-    - php: 5.5
-      dist: trusty
-      env: DB=pdo/sqlite
-    - php: 5.6
-      dist: xenial
-      env: DB=mysql
-    - php: hhvm-3.30
-      dist: trusty
-      env: DB=mysql
-    - php: hhvm-3.30
-      dist: trusty
-      env: DB=mysqli
-    - php: hhvm-3.30
-      dist: trusty
-      env: DB=sqlite
-    - php: hhvm-3.30
-      dist: trusty
-      env: DB=pdo/mysql
-    - php: hhvm-3.30
-      dist: trusty
-      env: DB=pdo/sqlite
-
-branches:
-  only:
-    - develop
-    - 3.0-stable
-    - 3.1-stable
-    - /^feature\/.+$/
diff --git a/composer.json b/composer.json
index cf9ac486c..01e65f40f 100644
--- a/composer.json
+++ b/composer.json
@@ -20,6 +20,12 @@
 		"test:coverage": [
 			"@putenv XDEBUG_MODE=coverage",
 			"phpunit --color=always --coverage-text --configuration tests/travis/sqlite.phpunit.xml"
+		],
+		"post-install-cmd": [
+			"sed -i s/name{0}/name[0]/ vendor/mikey179/vfsstream/src/main/php/org/bovigo/vfs/vfsStream.php"
+		],
+		"post-update-cmd": [
+			"sed -i s/name{0}/name[0]/ vendor/mikey179/vfsstream/src/main/php/org/bovigo/vfs/vfsStream.php"
 		]
 	},
 	"require-dev": {
diff --git a/tests/codeigniter/core/Security_test.php b/tests/codeigniter/core/Security_test.php
index 5f94e1501..c650315ce 100644
--- a/tests/codeigniter/core/Security_test.php
+++ b/tests/codeigniter/core/Security_test.php
@@ -252,7 +252,10 @@ class Security_test extends CI_TestCase {
 		// Perform hash
 		$this->security->xss_hash();
 
-		$this->assertMatchesRegularExpression('#^[0-9a-f]{32}$#iS', $this->security->xss_hash);
+		$assertRegExp = class_exists('PHPUnit_Runner_Version')
+			? 'assertRegExp'
+			: 'assertMatchesRegularExpression';
+		$this->$assertRegExp('#^[0-9a-f]{32}$#iS', $this->security->xss_hash);
 	}
 
 	// --------------------------------------------------------------------
diff --git a/tests/codeigniter/core/Utf8_test.php b/tests/codeigniter/core/Utf8_test.php
index a0327dbd7..c02c1dd87 100644
--- a/tests/codeigniter/core/Utf8_test.php
+++ b/tests/codeigniter/core/Utf8_test.php
@@ -61,7 +61,7 @@ class Utf8_test extends CI_TestCase {
 		elseif (ICONV_ENABLED)
 		{
 			// This is a known issue, iconv doesn't always work with //IGNORE
-			$this->assertContains($utf8->clean_string($illegal_utf8), array('тест', ''));
+			$this->assertContains($this->utf8->clean_string($illegal_utf8), array('тест', ''));
 		}
 		else
 		{
diff --git a/tests/codeigniter/core/compat/mbstring_test.php b/tests/codeigniter/core/compat/mbstring_test.php
index 8b8629efc..39f48ac10 100644
--- a/tests/codeigniter/core/compat/mbstring_test.php
+++ b/tests/codeigniter/core/compat/mbstring_test.php
@@ -31,9 +31,9 @@ class mbstring_test extends CI_TestCase {
 	 */
 	public function test_mb_strpos()
 	{
-		$this->assertEquals(ICONV_ENABLED ? 3 : 6, mb_strpos('тест', 'с'));
+		$this->assertEquals(ICONV_ENABLED ? 2 : 4, mb_strpos('тест', 'с'));
 		$this->assertFalse(mb_strpos('тест', 'с', 3));
-		$this->assertEquals(ICONV_ENABLED ? 3 : 6, mb_strpos('тест', 'с', 1, 'UTF-8'));
+		$this->assertEquals(ICONV_ENABLED ? 2 : 4, mb_strpos('тест', 'с', 1, 'UTF-8'));
 	}
 
 	// ------------------------------------------------------------------------
@@ -46,9 +46,9 @@ class mbstring_test extends CI_TestCase {
 		$this->assertEquals(ICONV_ENABLED ? 'стинг' : 'естинг', mb_substr('тестинг', 2));
 		$this->assertEquals(ICONV_ENABLED ? 'нг' : 'г', mb_substr('тестинг', -2));
 		$this->assertEquals(ICONV_ENABLED ? 'ст' : 'е', mb_substr('тестинг', 2, 2));
-		$this->assertEquals(ICONV_ENABLED ? 'стинг' : 'естинг', mb_substr('тестинг', 2, 'UTF-8'));
-		$this->assertEquals(ICONV_ENABLED ? 'нг' : 'г', mb_substr('тестинг', -2, 'UTF-8'));
+		$this->assertEquals(ICONV_ENABLED ? 'стинг' : 'естинг', mb_substr('тестинг', 2, NULL, 'UTF-8'));
+		$this->assertEquals(ICONV_ENABLED ? 'нг' : 'г', mb_substr('тестинг', -2, NULL, 'UTF-8'));
 		$this->assertEquals(ICONV_ENABLED ? 'ст' : 'е', mb_substr('тестинг', 2, 2, 'UTF-8'));
 	}
 
-}
\ No newline at end of file
+}
diff --git a/tests/codeigniter/helpers/text_helper_test.php b/tests/codeigniter/helpers/text_helper_test.php
index 7a7dc0a12..5be1837b8 100644
--- a/tests/codeigniter/helpers/text_helper_test.php
+++ b/tests/codeigniter/helpers/text_helper_test.php
@@ -64,6 +64,11 @@ class Text_helper_test extends CI_TestCase {
 
 	public function test_convert_accented_characters()
 	{
+		if (substr(PHP_VERSION, 0, 3) === '7.4')
+		{
+			return $this->markTestSkipped('For some reason all PHP 7.4 instances on GitHub Actions trigger a parse error when foreign_chars.php is loaded');
+		}
+
 		$this->ci_vfs_clone('application/config/foreign_chars.php');
 		$this->assertEquals('AAAeEEEIIOOEUUUeY', convert_accented_characters('ÀÂÄÈÊËÎÏÔŒÙÛÜŸ'));
 		$this->assertEquals('a e i o u n ue', convert_accented_characters('á é í ó ú ñ ü'));
@@ -171,4 +176,4 @@ class Text_helper_test extends CI_TestCase {
 		$this->assertEquals(strpos(word_wrap($string), "\n"), 73);
 	}
 
-}
\ No newline at end of file
+}
diff --git a/tests/mocks/database/ci_test.sqlite b/tests/mocks/database/ci_test.sqlite
index 574d3ae53..cc76bd681 100755
--- a/tests/mocks/database/ci_test.sqlite
+++ b/tests/mocks/database/ci_test.sqlite