summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEli Schwartz <eschwartz@archlinux.org>2018-06-01 02:31:23 +0200
committerAllan McRae <allan@archlinux.org>2018-06-18 05:15:51 +0200
commitde8c5e78bbaec3aea16523d1a7c5cc6801154c80 (patch)
treee6e9491d7927160eae777f9d11334cb3d1d4f5ca
parent737596f038590878d9ac73e6e8de01ad22b2b340 (diff)
downloadpacman-de8c5e78bbaec3aea16523d1a7c5cc6801154c80.tar.gz
pacman-de8c5e78bbaec3aea16523d1a7c5cc6801154c80.tar.xz
libmakepkg/lint_pkgbuild: squelch syntax error when a pkgname is empty
We fail with an error, but then we also fail with: ==> ERROR: depends is not allowed to be empty. /usr/share/makepkg/lint_pkgbuild/pkgname.sh: line 39: continue: only meaningful in a `for', `while', or `until' loop During the refactor to provide enhanced pkgname=pkgver linting, this was moved out of the ${pkgname[@]} loop to a distinct function, at which time it should have been modified to return rather than continue. Signed-off-by: Eli Schwartz <eschwartz@archlinux.org> Signed-off-by: Allan McRae <allan@archlinux.org>
-rw-r--r--scripts/libmakepkg/lint_pkgbuild/pkgname.sh.in3
1 files changed, 1 insertions, 2 deletions
diff --git a/scripts/libmakepkg/lint_pkgbuild/pkgname.sh.in b/scripts/libmakepkg/lint_pkgbuild/pkgname.sh.in
index d51c6313..84666a29 100644
--- a/scripts/libmakepkg/lint_pkgbuild/pkgname.sh.in
+++ b/scripts/libmakepkg/lint_pkgbuild/pkgname.sh.in
@@ -35,8 +35,7 @@ lint_one_pkgname() {
if [[ -z $name ]]; then
error "$(gettext "%s is not allowed to be empty.")" "$type"
- ret=1
- continue
+ return 1
fi
if [[ ${name:0:1} = "-" ]]; then
error "$(gettext "%s is not allowed to start with a hyphen.")" "$type"