summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDave Reisner <dreisner@archlinux.org>2020-02-06 13:48:39 +0100
committerAllan McRae <allan@archlinux.org>2020-02-12 09:37:44 +0100
commit4246a4cc4f0f87642cbbb6b375524b2e4c713412 (patch)
treee9a8d9833df78da28ce8b3d6e19e930642788a95
parente76ec94083235ddc5510ab57b7c2bc12a1d34e8a (diff)
downloadpacman-4246a4cc4f0f87642cbbb6b375524b2e4c713412.tar.gz
pacman-4246a4cc4f0f87642cbbb6b375524b2e4c713412.tar.xz
makepkg: drop duplicate reporting of missing dependencies
When pacman fails to satisfy deps, we might see output like the following: ==> Making package: spiderfoot 3.0-1 (Thu 06 Feb 2020 12:45:10 PM CET) ==> Checking runtime dependencies... ==> Installing missing dependencies... error: target not found: python-pygexf ==> ERROR: 'pacman' failed to install missing dependencies. ==> Missing dependencies: -> python-dnspython -> python-exifread -> python-cherrypy -> python-beautifulsoup4 -> python-netaddr -> python-pysocks -> python-ipwhois -> python-ipaddress -> python-phonenumbers -> python-pypdf2 -> python-stem -> python-whois -> python-future -> python-pyopenssl -> python-docx -> python-pptx -> python-networkx -> python-cryptography -> python-secure -> python-pygexf -> python-adblockparser ==> Checking buildtime dependencies... ==> ERROR: Could not resolve all dependencies. This is misleading -- the only truly missing package is python-pygexf, but we fail to remove sync-able deps from our deplist and report everything as if it were missing. Simply drop this extra reporting because pacman already tells us exactly what couldn't be resolved. Signed-off-by: Allan McRae <allan@archlinux.org>
-rw-r--r--scripts/makepkg.sh.in6
1 files changed, 0 insertions, 6 deletions
diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
index 7ebdfdd6..d1416d15 100644
--- a/scripts/makepkg.sh.in
+++ b/scripts/makepkg.sh.in
@@ -316,12 +316,6 @@ resolve_deps() {
[[ -z $deplist ]] && return $R_DEPS_SATISFIED
fi
- msg "$(gettext "Missing dependencies:")"
- local dep
- for dep in ${deplist[@]}; do
- msg2 "$dep"
- done
-
return $R_DEPS_MISSING
}