summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEli Schwartz <eschwartz@archlinux.org>2018-06-12 16:00:29 +0200
committerAllan McRae <allan@archlinux.org>2018-08-10 04:37:20 +0200
commit885bbb504afbf014194c8c20a51fc862980da45b (patch)
tree82c7e54a24ef0068ed34e597f2f044d7b7514845
parent9e960d9d5a735bbc7d418f2ad81d3f3e92d99968 (diff)
downloadpacman-885bbb504afbf014194c8c20a51fc862980da45b.tar.gz
pacman-885bbb504afbf014194c8c20a51fc862980da45b.tar.xz
makepkg: when signing packages, report package filename on failure
In commit c6b04c04653ba9933fe978829148312e412a9ea7 the signing function was moved out of fakeroot, and thus out of the create_package loop. This meant that if package signing failed, it was no longer possible to tell which package it failed on by checking which package creation is currently running. Successful signing attempts do not have this problem as we already printed the name of the signature file. Signed-off-by: Eli Schwartz <eschwartz@archlinux.org> Signed-off-by: Allan McRae <allan@archlinux.org>
-rw-r--r--scripts/libmakepkg/integrity/generate_signature.sh.in2
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/libmakepkg/integrity/generate_signature.sh.in b/scripts/libmakepkg/integrity/generate_signature.sh.in
index b53a90d0..e6ff3b1b 100644
--- a/scripts/libmakepkg/integrity/generate_signature.sh.in
+++ b/scripts/libmakepkg/integrity/generate_signature.sh.in
@@ -40,7 +40,7 @@ create_signature() {
if (( ! ret )); then
msg2 "$(gettext "Created signature file %s.")" "${filename##*/}.sig"
else
- warning "$(gettext "Failed to sign package file.")"
+ warning "$(gettext "Failed to sign package file %s.")" "${filename##*/}"
fi
return $ret