summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan McGee <dan@archlinux.org>2007-02-16 23:41:51 +0100
committerDan McGee <dan@archlinux.org>2007-02-16 23:41:51 +0100
commit8e34023bbd43b916af91c7eb65890557b7db4fd8 (patch)
tree27b54315ddf6bc0a3c0cf7546d4de4fba215028e
parentc40c2e1137f92d11d3aa62341c892c0c0ba6eb9a (diff)
downloadpacman-8e34023bbd43b916af91c7eb65890557b7db4fd8.tar.gz
pacman-8e34023bbd43b916af91c7eb65890557b7db4fd8.tar.xz
* Removed unnecessary #define
* Added comment for something I noticed while looking through code
-rw-r--r--lib/libalpm/alpm_list.h1
-rw-r--r--lib/libalpm/deps.c1
2 files changed, 1 insertions, 1 deletions
diff --git a/lib/libalpm/alpm_list.h b/lib/libalpm/alpm_list.h
index be78245c..f8fd082c 100644
--- a/lib/libalpm/alpm_list.h
+++ b/lib/libalpm/alpm_list.h
@@ -60,7 +60,6 @@ alpm_list_t *alpm_list_nth(alpm_list_t *list, int n);
alpm_list_t *alpm_list_next(alpm_list_t *list);
alpm_list_t *alpm_list_last(alpm_list_t *list);
void *alpm_list_getdata(const alpm_list_t *entry);
-#define alpm_list_data(type, list) (type)alpm_list_getdata((list))
/* misc */
int alpm_list_count(const alpm_list_t *list);
diff --git a/lib/libalpm/deps.c b/lib/libalpm/deps.c
index 492b64a0..ae378658 100644
--- a/lib/libalpm/deps.c
+++ b/lib/libalpm/deps.c
@@ -138,6 +138,7 @@ alpm_list_t *_alpm_sortbydeps(alpm_list_t *targets, pmtranstype_t mode)
for(i = newtargs; i; i = i->next) {
pmpkg_t *p = (pmpkg_t*)i->data;
_alpm_log(PM_LOG_DEBUG, "sorting %s", p->name);
+ /* TODO this may not always work if p->data is a fd, not db */
_alpm_db_read(p->data, INFRQ_DEPENDS, p);
for(j = p->depends; j; j = j->next) {
pmdepend_t dep;